Use [Environment]::MachineName instead of $env:COMPUTERNAME
Live kernel NetBIOS name instead of the PowerShell process-env cache. $env:COMPUTERNAME is populated when PowerShell starts and does not update if the PC gets renamed (common on Intune-managed Autopilot / AADJ devices that come up with a DESKTOP-XXXXXXXX name and get renamed by policy post-imaging). Until the next reboot, the env var stays stale while 'hostname.exe' already reports the new name. That mismatch showed up live on the first production retrofit: the status.json was written under _outputs/logs/DESKTOP-XXXXXXXX/ instead of under the device's current name, and the TargetHostnames filter and monitor drift-check would likewise see the stale name. [Environment]::MachineName reads from the kernel on each call, so it always returns the current NetBIOS name. Swapped at all five callsites in GE-Enforce.ps1, Register-GEEnforce.ps1, and Install-FromManifest.ps1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -182,7 +182,11 @@ try {
|
||||
# continues if the share path is not writable.
|
||||
# ------------------------------------------------------------------
|
||||
try {
|
||||
$statusDir = Join-Path (Join-Path $driveLetter '_outputs') (Join-Path 'logs' $env:COMPUTERNAME)
|
||||
# Live NetBIOS name from kernel - not $env:COMPUTERNAME, which is
|
||||
# cached in the process env block and goes stale after a post-image
|
||||
# rename on Intune-managed PCs.
|
||||
$hostname = [System.Environment]::MachineName
|
||||
$statusDir = Join-Path (Join-Path $driveLetter '_outputs') (Join-Path 'logs' $hostname)
|
||||
if (-not (Test-Path $statusDir)) {
|
||||
New-Item -Path $statusDir -ItemType Directory -Force -ErrorAction Stop | Out-Null
|
||||
}
|
||||
@@ -223,7 +227,7 @@ try {
|
||||
}
|
||||
|
||||
$status = [ordered]@{
|
||||
hostname = $env:COMPUTERNAME
|
||||
hostname = $hostname
|
||||
lastCheckIn = (Get-Date).ToUniversalTime().ToString('o')
|
||||
pcType = $pcType
|
||||
pcSubType = $pcSubType
|
||||
|
||||
Reference in New Issue
Block a user