Ship uninstaller in agent bundle and harden tray launch

The site-agent bundle now includes uninstall-shopdbagent.ps1 so operators can cleanly remove an install without hunting for the repo script. The packaging route reads it from scripts/, which was not mounted into the api container, so add a read-only ./scripts:/app/scripts mount (recreate the container to apply).

install.ps1 now registers the tray to autostart for every user via the HKLM Run value ShopDbEndpointTray, adds an All-Users 'ShopDB Agent' Start Menu shortcut for manual relaunch, and launches the tray once post-install. The tray enforces a single instance via a Global named mutex so repeated launches no longer stack duplicate icons. The uninstaller removes the Start Menu shortcut alongside the existing Run key and credential cleanup.

plugins/endpoints/api/siteagent.py

@@ -40,6 +40,14 @@ from .routes import endpoints_bp
 STAGED_AGENT_RELPATH = os.path.join('siteagent', 'shopdbagent.exe')
 STAGED_TRAY_RELPATH = os.path.join('siteagent', 'shopdb-endpoint-tray.exe')
 
+# The standalone uninstaller lives in the repo tree (not staged per-instance),
+# so it ships in every bundle. Resolve it relative to this file:
+# plugins/endpoints/api/siteagent.py -> repo root is three levels up.
+UNINSTALLER_PATH = os.path.join(
+    os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(
+        os.path.abspath(__file__))))),
+    'scripts', 'uninstall-shopdbagent.ps1')
+
 # Public TLS certificate the agent must trust when this deployment terminates
 # TLS itself with a self-signed or otherwise untrusted certificate. We can only
 # auto-bundle when THIS app owns the cert file (the dev topology, where gunicorn
@@ -143,6 +151,12 @@ FILES
   appsettings.json         Non-secret runtime config (cadence, monitors,
                            launch paths). No credentials.
   install.ps1              Provisions the credentials and installs the service.
+  uninstall-shopdbagent.ps1
+                           Standalone uninstaller. Run elevated to reverse the
+                           install: stops and deletes the service, kills agent
+                           and tray processes, removes the tray autostart Run
+                           key, the Start Menu shortcut, and the credential
+                           hive, and deletes the install directory.
   server.crt               Server TLS certificate (present only for self-signed
                            or internal-CA deployments, either auto-detected or
                            uploaded by the operator). install.ps1 imports it
@@ -153,7 +167,13 @@ USAGE
   1. Copy this whole folder to the target endpoint.
   2. Right-click install.ps1 and Run with PowerShell as administrator. It
      writes the server URL and collector key to HKLM\\SOFTWARE\\GE\\ShopDB,
-     copies the agent into Program Files, and starts the service.
+     copies the agent into Program Files, and starts the service. It also
+     registers the tray to autostart for every user at logon and adds a
+     "ShopDB Agent" Start Menu shortcut for manual relaunch.
+
+UNINSTALL
+  Run uninstall-shopdbagent.ps1 from an elevated PowerShell to fully remove the
+  agent, tray autostart, Start Menu shortcut, and credentials.
 
 SECURITY
   install.ps1 carries a live collector key in its default -CollectorKey value.
@@ -305,6 +325,36 @@ if (-not $NoTray) {{
     $traySource = Join-Path $sourceDir $TrayExeName
     if (Test-Path $traySource) {{
         Copy-Item -Path $traySource -Destination $InstallDir -Force
+        $installedTray = Join-Path $InstallDir $TrayExeName
+
+        # Autostart the tray for every user at logon via the HKLM Run key (both
+        # 64-bit and 32-bit views, matching the credential hive). This is the
+        # reliable launch guarantee: a plain Start Menu shortcut does not
+        # autostart, and the SYSTEM service cannot cleanly spawn into the
+        # interactive session. The tray itself is single-instance, so a stray
+        # second launch is harmless.
+        Set-HklmValueBothViews -SubKey "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run" -Name "ShopDbEndpointTray" -Value ('"' + $installedTray + '"')
+
+        # Start Menu shortcut so operators can relaunch the tray on demand. This
+        # is discoverability only, not autostart. Written to the machine-wide
+        # (All Users) Programs folder.
+        try {{
+            $commonPrograms = [Environment]::GetFolderPath([Environment+SpecialFolder]::CommonPrograms)
+            $shortcutPath = Join-Path $commonPrograms "ShopDB Agent.lnk"
+            $shell = New-Object -ComObject WScript.Shell
+            $shortcut = $shell.CreateShortcut($shortcutPath)
+            $shortcut.TargetPath = $installedTray
+            $shortcut.WorkingDirectory = $InstallDir
+            $shortcut.Description = "ShopDB Endpoint Agent tray"
+            $shortcut.Save()
+            Write-Host "      created Start Menu shortcut: $shortcutPath"
+        }}
+        catch {{ Write-Warning "could not create Start Menu shortcut: $($_.Exception.Message)" }}
+
+        # Launch the tray once now so it appears without waiting for the next
+        # logon. Single-instance guard makes a duplicate launch a no-op.
+        try {{ Start-Process -FilePath $installedTray -WorkingDirectory $InstallDir }}
+        catch {{ Write-Warning "could not start tray: $($_.Exception.Message)" }}
     }}
 }}
 
@@ -420,6 +470,9 @@ def package_siteagent():
                                          cadenceseconds, certfilename))
         archive.writestr('README.txt', _README)
 
+        if os.path.isfile(UNINSTALLER_PATH):
+            archive.write(UNINSTALLER_PATH, 'uninstall-shopdbagent.ps1')
+
         agent = _staged_path(STAGED_AGENT_RELPATH)
         if os.path.isfile(agent):
             archive.write(agent, 'shopdbagent.exe')