From 024751896ea71eceff80990f871cf6f45658a5c4 Mon Sep 17 00:00:00 2001 From: cproudlock Date: Wed, 26 Aug 2026 15:08:37 -0400 Subject: [PATCH] Keep the site-literal patterns out of the published copy The comment explaining the concatenation fix spelled the example hostname out in full, which tripped the publication scrub - the same trap the surrounding comment warns about, since the scrub greps this file for the very strings the patterns are assembled from. Reworded with a neutral example. Re-verified after the reword by planting a violation and watching the gate fail. --- scripts/check-naming-and-style.sh | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/check-naming-and-style.sh b/scripts/check-naming-and-style.sh index 8730db14..8b61831d 100755 --- a/scripts/check-naming-and-style.sh +++ b/scripts/check-naming-and-style.sh @@ -233,12 +233,13 @@ echo "==> Checking for site-specific literals in product code (ADR-015)..." # publication scrub greps for the very strings below - written literally, the # rule's own definition trips the gate that enforces it. Same reason # tests/test_docs_publishable.py splits its terms. -# Adjacent quoted strings CONCATENATE: 'tsg''wp00525' is tsgwp00525. The -# apostrophe-escape form ('tsg'\''wp00525') looks similar and is not - it -# embeds a literal ' in the middle, and every one of these patterns then matches -# nothing. This check silently passed everything from the day it was written -# until 2026-08-26, which is how a QA ServiceNow tenant sat in the shipped -# defaults for months with the gate green. +# Adjacent quoted strings CONCATENATE: 'ab''cd' is the four-character string +# abcd. The apostrophe-escape form ('ab'\''cd') looks almost identical and is +# not - it embeds a literal ' in the middle, so every pattern below matched +# nothing and this check silently passed everything from the day it was written +# until 2026-08-26. That is how a QA SaaS tenant sat in the shipped defaults for +# months with the gate green. Keep the fragments split (the scrub greps this +# file for the very strings the patterns are made of) and keep them ADJACENT. SITE_HOST='tsg''wp00525' SITE_DOMAIN='\.geaero''space\.net' SITE_NAME='West Jeff''erson'