Dashboard cards, backup last-seen

plugins/backups/plugin.py

@@ -161,6 +161,17 @@ class BackupsPlugin(BasePlugin):
                 'description': 'UNC root that opaque (non-JSON) backups are '
                                'written under by the collecting PC. Site-specific.',
             },
+            {
+                'key': 'backups_staledays',
+                'value': '3',
+                'valuetype': 'integer',
+                'category': 'backups',
+                'description': 'Days without a CONFIRMED check before a backup '
+                               'is listed as stopped on the dashboard. Measured '
+                               'from the last check, not the last change - an '
+                               'unchanged config writes no revision. 0 disables '
+                               'the card.',
+            },
             {
                 'key': 'backups_retentioncount',
                 'value': '50',
@@ -180,6 +191,36 @@ class BackupsPlugin(BasePlugin):
             },
         ]
 
+    def get_dashboard_widgets(self) -> List[Dict]:
+        """Dashboard card: backups that have stopped running.
+
+        Keyed on the last CONFIRMED check, never on the last change. Dedup means
+        an unchanged config writes no revision, so a card keyed on revision age
+        would flag most of a healthy fleet.
+        """
+        return [
+            {
+                'id': 'backups-stale',
+                'title': 'Backups stopped',
+                'endpoint': '/api/backups/dashboard/stale',
+                'render': 'exceptions',
+                'severity': 'warning',
+                'permission': 'backups.view',
+                'empty': 'hide',
+                'position': 30,
+                'map': {
+                    'title': 'assetnumber',
+                    'detail': 'backupkind',
+                    'meta': [
+                        {'key': 'sourcehostname', 'label': 'from'},
+                        {'key': 'quietdays', 'label': 'last checked',
+                         'suffix': ' days ago'},
+                    ],
+                    'link': '/backups/asset/{assetid}',
+                },
+            },
+        ]
+
     # ---- ADR-006 collector contract -------------------------------------
 
     def get_collector_schema(self) -> Optional[dict]:
@@ -299,6 +340,13 @@ class BackupsPlugin(BasePlugin):
                   .first())
 
         if latest is not None and latest.contenthash == contenthash:
+            # Unchanged, so no revision - but RECORD THE CHECK. Without this the
+            # only evidence a backup still runs is a line in a log on the PC,
+            # and a config stable for six months is indistinguishable from a
+            # backup that died six months ago. Cheap: one column on a row that
+            # already exists, no new history.
+            latest.lastseenat = datetime.utcnow()
+            db.session.flush()
             return {
                 'action': 'noop',
                 'assetid': assetid,
@@ -330,6 +378,7 @@ class BackupsPlugin(BasePlugin):
             bytesize=bytesize,
             sourcehostname=payload.get('sourcehostname'),
             collectedat=collectedat or datetime.utcnow(),
+            lastseenat=datetime.utcnow(),
         )
         revision.payload = projection
         db.session.add(revision)