Import the wilm agent store and WINC adoption work, with four fixes
Eleven commits from the sister site: a reversible Maximo/WINC machine-adoption import, a versioned agent binary store with upload and rollback, remote-BuildKit CI, tray version reporting, and UI fixes. Applied as a patch again - the published mirror rewrites hashes, so the branches have unrelated histories and git refuses to merge them. Reviewed by three agents before merging. Four things fixed here. THE PUBLISH WORKFLOW WAS DEAD. The new remote-BuildKit step in publish-images.yml sits at column 0 instead of indented under steps:, so the whole file is invalid YAML and GitHub would refuse it. Their entire GHCR distribution channel - which Start-ShopDBDev.ps1 and the compose files consume - was broken at the source and clearly never run. Indented; all five workflows now parse. THE IMPORT'S APPROVAL CHECK COULD NOT FAIL. commit() built the plan and the approval packet from the same upload and then asked the writer whether they matched, so packet_matches_plan compared a hash against itself. The documented contract - "a human approves a specific, frozen plan, and the writer can prove nothing drifted" - did not exist in the web path: an admin could preview file A and commit file B, gated only by the needs-create group NAMES they ticked. The preview's planhash is now required at commit and checked against a freshly rebuilt plan. Their tests committed without previewing, which is what let this through; they go through the real flow now, and three new tests pin it - all confirmed to fail with the check stubbed out. endpoints.agentpackage QUIETLY GREW. It used to mean "wrap the staged exe in a ZIP"; with the upload routes it also means "choose the executable every future package installs and runs as SYSTEM". Before this, staging needed filesystem access to the server. The permission description still said only "generate and download a package", so an admin granting it could not see what they were granting. Reworded. NOTHING RECORDED WHAT WAS STAGED, OR BY WHOM. The manifest held version, size and timestamp; re-uploading a version replaces the bytes in place under the same label. A sha256 of the stored file is now recorded, and the upload is audit-logged with it - after an incident there was previously no answer to who put that binary on the fleet. Also documented the nine new routes in docs/api-inventory.json (that gate cannot run on the mirror, so it falls to us at promotion time again), regenerated the spec and the project map, and kept our own docs where they conflicted: docs/ is scrubbed from the mirror, so their DEV-BUILD-TEST.md still had the dev-be channel mapping we corrected, and their PLUGIN-HOOKS.md was a new 45-line file rather than our 737-line canonical one. Their journal section is appended to ours. Contract version comes across as 0.30.0 for a genuinely additive surface. Suite 2369, frontend 324, gate green. Scope: product
This commit is contained in:
@@ -23,6 +23,8 @@ from .setting import Setting
|
||||
from .auditlog import AuditLog
|
||||
from .customfield import CustomField, CustomFieldValue
|
||||
from .apitoken import ApiToken
|
||||
from .importbatch import (ImportBatch, ImportJournalEntry, BATCH_APPLIED,
|
||||
BATCH_UNDONE, OP_UPDATE, OP_INSERT)
|
||||
|
||||
__all__ = [
|
||||
# Base
|
||||
@@ -82,4 +84,11 @@ __all__ = [
|
||||
'CustomFieldValue',
|
||||
# Personal API tokens
|
||||
'ApiToken',
|
||||
# Import batch + journal (reversible bulk imports)
|
||||
'ImportBatch',
|
||||
'ImportJournalEntry',
|
||||
'BATCH_APPLIED',
|
||||
'BATCH_UNDONE',
|
||||
'OP_UPDATE',
|
||||
'OP_INSERT',
|
||||
]
|
||||
|
||||
86
shopdb/core/models/importbatch.py
Normal file
86
shopdb/core/models/importbatch.py
Normal file
@@ -0,0 +1,86 @@
|
||||
"""Import batch + journal models (reversible bulk imports).
|
||||
|
||||
PLATFORM-LEVEL, IMPORT-AGNOSTIC. These two tables let any bulk-import writer
|
||||
record exactly what it changed so the change can be reversed later. Nothing here
|
||||
knows about Maximo, WINC, machines, or any one source: an importer records
|
||||
primitive mutations (set column X on row Y, or insert row Y) tied to a batch id,
|
||||
and a generic undo replays them in reverse.
|
||||
|
||||
importbatches one row per approved write - the identity that approval, the
|
||||
write, and the eventual undo all reference (the same value
|
||||
the approval packet calls batchid).
|
||||
importjournalentries one row per primitive mutation the writer made, ordered so
|
||||
undo can reverse them (inserts removed after the updates that
|
||||
pointed at them are reverted).
|
||||
|
||||
The undo contract, kept deliberately conservative:
|
||||
- update is reverted only if the cell still holds the value we wrote; a value a
|
||||
human changed since is left as-is and reported (never clobbered).
|
||||
- insert is hard-deleted, but ONLY the row this batch created and only when
|
||||
nothing outside the batch still references it.
|
||||
"""
|
||||
|
||||
from shopdb.extensions import db
|
||||
|
||||
|
||||
# Batch lifecycle.
|
||||
BATCH_APPLIED = 'applied'
|
||||
BATCH_UNDONE = 'undone'
|
||||
|
||||
# Journal operation kinds.
|
||||
OP_UPDATE = 'update'
|
||||
OP_INSERT = 'insert'
|
||||
|
||||
|
||||
class ImportBatch(db.Model):
|
||||
"""One approved import write. The batchid is the approval packet's batchid,
|
||||
carried through write and undo so all three reference one identity."""
|
||||
__tablename__ = 'importbatches'
|
||||
|
||||
batchid = db.Column(db.String(36), primary_key=True)
|
||||
kind = db.Column(db.String(64), nullable=False)
|
||||
planhash = db.Column(db.String(64), nullable=False)
|
||||
rowcount = db.Column(db.Integer, nullable=False, default=0)
|
||||
createdat = db.Column(db.DateTime, nullable=False)
|
||||
createdby = db.Column(db.String(100), nullable=True)
|
||||
status = db.Column(db.String(16), nullable=False, default=BATCH_APPLIED)
|
||||
undoneat = db.Column(db.DateTime, nullable=True)
|
||||
|
||||
entries = db.relationship(
|
||||
'ImportJournalEntry',
|
||||
backref='batch',
|
||||
cascade='all, delete-orphan',
|
||||
order_by='ImportJournalEntry.sequence',
|
||||
)
|
||||
|
||||
def __repr__(self):
|
||||
return f"<ImportBatch {self.kind} {self.batchid} {self.status}>"
|
||||
|
||||
|
||||
class ImportJournalEntry(db.Model):
|
||||
"""One reversible primitive mutation made by an import writer."""
|
||||
__tablename__ = 'importjournalentries'
|
||||
|
||||
# SQLite only autoincrements a plain INTEGER PRIMARY KEY, not BIGINT, so the
|
||||
# test database needs the Integer variant while MySQL keeps BIGINT for range.
|
||||
entryid = db.Column(
|
||||
db.BigInteger().with_variant(db.Integer, 'sqlite'),
|
||||
primary_key=True)
|
||||
batchid = db.Column(
|
||||
db.String(36),
|
||||
db.ForeignKey('importbatches.batchid', ondelete='CASCADE'),
|
||||
nullable=False,
|
||||
index=True,
|
||||
)
|
||||
sequence = db.Column(db.Integer, nullable=False)
|
||||
operation = db.Column(db.String(16), nullable=False)
|
||||
targettable = db.Column(db.String(64), nullable=False)
|
||||
targetid = db.Column(db.BigInteger, nullable=False)
|
||||
columnname = db.Column(db.String(64), nullable=True)
|
||||
oldvalue = db.Column(db.Text, nullable=True)
|
||||
newvalue = db.Column(db.Text, nullable=True)
|
||||
isreverted = db.Column(db.Boolean, nullable=False, default=False)
|
||||
|
||||
def __repr__(self):
|
||||
return (f"<ImportJournalEntry {self.operation} "
|
||||
f"{self.targettable}.{self.targetid}>")
|
||||
Reference in New Issue
Block a user