From 23dc9fa379f497d06fa7693efff1dadb3bf687c3 Mon Sep 17 00:00:00 2001
From: cproudlock <cproudlock@localhost>
Date: Sat, 18 Jul 2026 23:51:23 -0400
Subject: [PATCH] ADR-013 Phase 4: relocate 4 self-contained plugin frontends

Relocate applications, geenforce, knowledgebase, and machines - each owns only
its own views dir, so a clean move to plugins/<name>/frontend/ (views/ +
routes.js, core imports rewritten to @/). geenforce's entryForm.js helper + its
vitest spec move with it (ManifestEditor imports it as a sibling).

Machinery fixes this batch surfaced:
- routes.gen.js codegen uses namespace imports (import * as p_x). A route file
  without a `toplevel` export is undefined on the namespace instead of a strict-
  ESM missing-binding build error.
- vitest gains a `pretest` stage so plugin-frontend specs (now under
  plugins/<name>/frontend/) run from their staged copy in src/.plugins-staged/.

Verified live: GE-Enforce (the most complex, uses the entryForm sibling helper)
renders fully from its staged frontend. Build + 58 vitest + naming green.
---
 frontend/package.json                              |  1 +
 frontend/vitest.config.js                          |  2 ++
 .../applications/frontend/routes.js                |  8 ++++----
 .../frontend/views}/ApplicationDetail.vue          |  4 ++--
 .../frontend/views}/ApplicationForm.vue            |  4 ++--
 .../frontend/views}/ApplicationsList.vue           |  4 ++--
 .../geenforce/frontend/routes.js                   |  6 +++---
 .../frontend/views}/EnforcementReports.vue         |  2 +-
 .../geenforce/frontend/views}/GeEnforceLayout.vue  |  0
 .../geenforce/frontend/views}/ManifestEditor.vue   |  2 +-
 .../geenforce/frontend/views}/entryForm.js         |  0
 .../geenforce/frontend/views}/entryForm.spec.js    |  0
 .../knowledgebase/frontend/routes.js               |  8 ++++----
 .../frontend/views}/KnowledgeBaseDetail.vue        |  2 +-
 .../frontend/views}/KnowledgeBaseForm.vue          |  4 ++--
 .../frontend/views}/KnowledgeBaseList.vue          |  4 ++--
 .../machines/frontend/routes.js                    |  8 ++++----
 .../machines/frontend/views}/MachineDetail.vue     | 14 +++++++-------
 .../machines/frontend/views}/MachineForm.vue       | 14 +++++++-------
 .../machines/frontend/views}/MachinesList.vue      |  4 ++--
 scripts/stage-frontend.mjs                         | 10 +++++-----
 21 files changed, 52 insertions(+), 49 deletions(-)
 rename frontend/src/router/routes/applications.js => plugins/applications/frontend/routes.js (54%)
 rename {frontend/src/views/applications => plugins/applications/frontend/views}/ApplicationDetail.vue (95%)
 rename {frontend/src/views/applications => plugins/applications/frontend/views}/ApplicationForm.vue (98%)
 rename {frontend/src/views/applications => plugins/applications/frontend/views}/ApplicationsList.vue (98%)
 rename frontend/src/router/routes/geenforce.js => plugins/geenforce/frontend/routes.js (78%)
 rename {frontend/src/views/geenforce => plugins/geenforce/frontend/views}/EnforcementReports.vue (99%)
 rename {frontend/src/views/geenforce => plugins/geenforce/frontend/views}/GeEnforceLayout.vue (100%)
 rename {frontend/src/views/geenforce => plugins/geenforce/frontend/views}/ManifestEditor.vue (99%)
 rename {frontend/src/views/geenforce => plugins/geenforce/frontend/views}/entryForm.js (100%)
 rename {frontend/src/views/geenforce => plugins/geenforce/frontend/views}/entryForm.spec.js (100%)
 rename frontend/src/router/routes/knowledgebase.js => plugins/knowledgebase/frontend/routes.js (62%)
 rename {frontend/src/views/knowledgebase => plugins/knowledgebase/frontend/views}/KnowledgeBaseDetail.vue (94%)
 rename {frontend/src/views/knowledgebase => plugins/knowledgebase/frontend/views}/KnowledgeBaseForm.vue (97%)
 rename {frontend/src/views/knowledgebase => plugins/knowledgebase/frontend/views}/KnowledgeBaseList.vue (94%)
 rename frontend/src/router/routes/machines.js => plugins/machines/frontend/routes.js (62%)
 rename {frontend/src/views/machines => plugins/machines/frontend/views}/MachineDetail.vue (96%)
 rename {frontend/src/views/machines => plugins/machines/frontend/views}/MachineForm.vue (98%)
 rename {frontend/src/views/machines => plugins/machines/frontend/views}/MachinesList.vue (97%)

diff --git a/frontend/package.json b/frontend/package.json
index b6d303c..49b9aca 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -10,6 +10,7 @@
     "prebuild": "npm run stage",
     "build": "vite build",
     "preview": "vite preview",
+    "pretest": "npm run stage",
     "test": "vitest run",
     "test:watch": "vitest"
   },
diff --git a/frontend/vitest.config.js b/frontend/vitest.config.js
index 0f2577e..f40201a 100644
--- a/frontend/vitest.config.js
+++ b/frontend/vitest.config.js
@@ -14,6 +14,8 @@ export default defineConfig({
   test: {
     environment: 'jsdom',
     globals: true,
+    // Core specs plus plugin-frontend specs, which the pretest stage copies
+    // into src/.plugins-staged/ (under root, so this glob finds them).
     include: ['src/**/*.spec.js'],
   },
 })
diff --git a/frontend/src/router/routes/applications.js b/plugins/applications/frontend/routes.js
similarity index 54%
rename from frontend/src/router/routes/applications.js
rename to plugins/applications/frontend/routes.js
index 754aacc..9c1ea75 100644
--- a/frontend/src/router/routes/applications.js
+++ b/plugins/applications/frontend/routes.js
@@ -5,23 +5,23 @@ export default [
   {
     path: 'applications',
     name: 'applications',
-    component: () => import('../../views/applications/ApplicationsList.vue')
+    component: () => import('./views/ApplicationsList.vue')
   },
   {
     path: 'applications/new',
     name: 'application-new',
-    component: () => import('../../views/applications/ApplicationForm.vue'),
+    component: () => import('./views/ApplicationForm.vue'),
     meta: { requiresAuth: true }
   },
   {
     path: 'applications/:id',
     name: 'application-detail',
-    component: () => import('../../views/applications/ApplicationDetail.vue')
+    component: () => import('./views/ApplicationDetail.vue')
   },
   {
     path: 'applications/:id/edit',
     name: 'application-edit',
-    component: () => import('../../views/applications/ApplicationForm.vue'),
+    component: () => import('./views/ApplicationForm.vue'),
     meta: { requiresAuth: true }
   }
 ]
diff --git a/frontend/src/views/applications/ApplicationDetail.vue b/plugins/applications/frontend/views/ApplicationDetail.vue
similarity index 95%
rename from frontend/src/views/applications/ApplicationDetail.vue
rename to plugins/applications/frontend/views/ApplicationDetail.vue
index 1f93ab3..f2c6fae 100644
--- a/frontend/src/views/applications/ApplicationDetail.vue
+++ b/plugins/applications/frontend/views/ApplicationDetail.vue
@@ -156,8 +156,8 @@
 <script setup>
 import { ref, onMounted } from 'vue'
 import { useRoute } from 'vue-router'
-import { applicationsApi } from '../../api'
-import { getContactEmailDomain } from '../../utils/siteSettings'
+import { applicationsApi } from '@/api'
+import { getContactEmailDomain } from '@/utils/siteSettings'
 
 const route = useRoute()
 
diff --git a/frontend/src/views/applications/ApplicationForm.vue b/plugins/applications/frontend/views/ApplicationForm.vue
similarity index 98%
rename from frontend/src/views/applications/ApplicationForm.vue
rename to plugins/applications/frontend/views/ApplicationForm.vue
index 38f6331..d6fc1a6 100644
--- a/frontend/src/views/applications/ApplicationForm.vue
+++ b/plugins/applications/frontend/views/ApplicationForm.vue
@@ -154,8 +154,8 @@
 <script setup>
 import { ref, onMounted, computed } from 'vue'
 import { useRoute, useRouter } from 'vue-router'
-import { applicationsApi, supportteamsApi } from '../../api'
-import { apiError } from '../../utils/apiError'
+import { applicationsApi, supportteamsApi } from '@/api'
+import { apiError } from '@/utils/apiError'
 
 const route = useRoute()
 const router = useRouter()
diff --git a/frontend/src/views/applications/ApplicationsList.vue b/plugins/applications/frontend/views/ApplicationsList.vue
similarity index 98%
rename from frontend/src/views/applications/ApplicationsList.vue
rename to plugins/applications/frontend/views/ApplicationsList.vue
index 9ce783a..3a7c6ec 100644
--- a/frontend/src/views/applications/ApplicationsList.vue
+++ b/plugins/applications/frontend/views/ApplicationsList.vue
@@ -99,8 +99,8 @@
 
 <script setup>
 import { ref, onMounted } from 'vue'
-import { applicationsApi } from '../../api'
-import PaginationBar from '../../components/PaginationBar.vue'
+import { applicationsApi } from '@/api'
+import PaginationBar from '@/components/PaginationBar.vue'
 import { useListQuery } from '@/composables/listQuery'
 
 const applications = ref([])
diff --git a/frontend/src/router/routes/geenforce.js b/plugins/geenforce/frontend/routes.js
similarity index 78%
rename from frontend/src/router/routes/geenforce.js
rename to plugins/geenforce/frontend/routes.js
index a3953c2..caa3d75 100644
--- a/frontend/src/router/routes/geenforce.js
+++ b/plugins/geenforce/frontend/routes.js
@@ -9,20 +9,20 @@
 export default [
   {
     path: 'geenforce',
-    component: () => import('../../views/geenforce/GeEnforceLayout.vue'),
+    component: () => import('./views/GeEnforceLayout.vue'),
     meta: { requiresAuth: true, requiresAdmin: true, plugin: 'geenforce' },
     children: [
       { path: '', redirect: '/geenforce/manifests' },
       {
         path: 'manifests',
         name: 'geenforce-manifests',
-        component: () => import('../../views/geenforce/ManifestEditor.vue'),
+        component: () => import('./views/ManifestEditor.vue'),
         meta: { requiresAuth: true, requiresAdmin: true, plugin: 'geenforce' }
       },
       {
         path: 'reports',
         name: 'geenforce-reports',
-        component: () => import('../../views/geenforce/EnforcementReports.vue'),
+        component: () => import('./views/EnforcementReports.vue'),
         meta: { requiresAuth: true, requiresAdmin: true, plugin: 'geenforce' }
       }
     ]
diff --git a/frontend/src/views/geenforce/EnforcementReports.vue b/plugins/geenforce/frontend/views/EnforcementReports.vue
similarity index 99%
rename from frontend/src/views/geenforce/EnforcementReports.vue
rename to plugins/geenforce/frontend/views/EnforcementReports.vue
index a0aa093..e497ca0 100644
--- a/frontend/src/views/geenforce/EnforcementReports.vue
+++ b/plugins/geenforce/frontend/views/EnforcementReports.vue
@@ -104,7 +104,7 @@
 
 <script setup>
 import { ref } from 'vue'
-import api from '../../api'
+import api from '@/api'
 
 const reports = ref([])
 const detail = ref(null)
diff --git a/frontend/src/views/geenforce/GeEnforceLayout.vue b/plugins/geenforce/frontend/views/GeEnforceLayout.vue
similarity index 100%
rename from frontend/src/views/geenforce/GeEnforceLayout.vue
rename to plugins/geenforce/frontend/views/GeEnforceLayout.vue
diff --git a/frontend/src/views/geenforce/ManifestEditor.vue b/plugins/geenforce/frontend/views/ManifestEditor.vue
similarity index 99%
rename from frontend/src/views/geenforce/ManifestEditor.vue
rename to plugins/geenforce/frontend/views/ManifestEditor.vue
index 7607bf8..71d0ee8 100644
--- a/frontend/src/views/geenforce/ManifestEditor.vue
+++ b/plugins/geenforce/frontend/views/ManifestEditor.vue
@@ -570,7 +570,7 @@
 
 <script setup>
 import { ref, computed } from 'vue'
-import api from '../../api'
+import api from '@/api'
 // Pure entry-form logic lives in entryForm.js (unit-tested by entryForm.spec.js);
 // this component wires it to reactive state so the tests cover the shipped code.
 import {
diff --git a/frontend/src/views/geenforce/entryForm.js b/plugins/geenforce/frontend/views/entryForm.js
similarity index 100%
rename from frontend/src/views/geenforce/entryForm.js
rename to plugins/geenforce/frontend/views/entryForm.js
diff --git a/frontend/src/views/geenforce/entryForm.spec.js b/plugins/geenforce/frontend/views/entryForm.spec.js
similarity index 100%
rename from frontend/src/views/geenforce/entryForm.spec.js
rename to plugins/geenforce/frontend/views/entryForm.spec.js
diff --git a/frontend/src/router/routes/knowledgebase.js b/plugins/knowledgebase/frontend/routes.js
similarity index 62%
rename from frontend/src/router/routes/knowledgebase.js
rename to plugins/knowledgebase/frontend/routes.js
index 0bd05e3..3dc2ef8 100644
--- a/frontend/src/router/routes/knowledgebase.js
+++ b/plugins/knowledgebase/frontend/routes.js
@@ -5,25 +5,25 @@ export default [
   {
     path: 'knowledgebase',
     name: 'knowledgebase',
-    component: () => import('../../views/knowledgebase/KnowledgeBaseList.vue'),
+    component: () => import('./views/KnowledgeBaseList.vue'),
     meta: { plugin: 'knowledgebase' }
   },
   {
     path: 'knowledgebase/new',
     name: 'knowledgebase-new',
-    component: () => import('../../views/knowledgebase/KnowledgeBaseForm.vue'),
+    component: () => import('./views/KnowledgeBaseForm.vue'),
     meta: { requiresAuth: true, plugin: 'knowledgebase' }
   },
   {
     path: 'knowledgebase/:id',
     name: 'knowledgebase-detail',
-    component: () => import('../../views/knowledgebase/KnowledgeBaseDetail.vue'),
+    component: () => import('./views/KnowledgeBaseDetail.vue'),
     meta: { plugin: 'knowledgebase' }
   },
   {
     path: 'knowledgebase/:id/edit',
     name: 'knowledgebase-edit',
-    component: () => import('../../views/knowledgebase/KnowledgeBaseForm.vue'),
+    component: () => import('./views/KnowledgeBaseForm.vue'),
     meta: { requiresAuth: true, plugin: 'knowledgebase' }
   }
 ]
diff --git a/frontend/src/views/knowledgebase/KnowledgeBaseDetail.vue b/plugins/knowledgebase/frontend/views/KnowledgeBaseDetail.vue
similarity index 94%
rename from frontend/src/views/knowledgebase/KnowledgeBaseDetail.vue
rename to plugins/knowledgebase/frontend/views/KnowledgeBaseDetail.vue
index d3f7f0e..2d2d8b8 100644
--- a/frontend/src/views/knowledgebase/KnowledgeBaseDetail.vue
+++ b/plugins/knowledgebase/frontend/views/KnowledgeBaseDetail.vue
@@ -79,7 +79,7 @@
 <script setup>
 import { ref, onMounted } from 'vue'
 import { useRoute } from 'vue-router'
-import { knowledgebaseApi } from '../../api'
+import { knowledgebaseApi } from '@/api'
 
 const route = useRoute()
 
diff --git a/frontend/src/views/knowledgebase/KnowledgeBaseForm.vue b/plugins/knowledgebase/frontend/views/KnowledgeBaseForm.vue
similarity index 97%
rename from frontend/src/views/knowledgebase/KnowledgeBaseForm.vue
rename to plugins/knowledgebase/frontend/views/KnowledgeBaseForm.vue
index 2726e4a..50f01e6 100644
--- a/frontend/src/views/knowledgebase/KnowledgeBaseForm.vue
+++ b/plugins/knowledgebase/frontend/views/KnowledgeBaseForm.vue
@@ -82,8 +82,8 @@
 <script setup>
 import { ref, onMounted, computed } from 'vue'
 import { useRoute, useRouter } from 'vue-router'
-import { knowledgebaseApi, applicationsApi } from '../../api'
-import { apiError } from '../../utils/apiError'
+import { knowledgebaseApi, applicationsApi } from '@/api'
+import { apiError } from '@/utils/apiError'
 
 const route = useRoute()
 const router = useRouter()
diff --git a/frontend/src/views/knowledgebase/KnowledgeBaseList.vue b/plugins/knowledgebase/frontend/views/KnowledgeBaseList.vue
similarity index 94%
rename from frontend/src/views/knowledgebase/KnowledgeBaseList.vue
rename to plugins/knowledgebase/frontend/views/KnowledgeBaseList.vue
index fd20ebd..fca1b5d 100644
--- a/frontend/src/views/knowledgebase/KnowledgeBaseList.vue
+++ b/plugins/knowledgebase/frontend/views/KnowledgeBaseList.vue
@@ -109,8 +109,8 @@
 
 <script setup>
 import { ref, onMounted } from 'vue'
-import { knowledgebaseApi, applicationsApi } from '../../api'
-import PaginationBar from '../../components/PaginationBar.vue'
+import { knowledgebaseApi, applicationsApi } from '@/api'
+import PaginationBar from '@/components/PaginationBar.vue'
 import { useListQuery } from '@/composables/listQuery'
 
 const loading = ref(true)
diff --git a/frontend/src/router/routes/machines.js b/plugins/machines/frontend/routes.js
similarity index 62%
rename from frontend/src/router/routes/machines.js
rename to plugins/machines/frontend/routes.js
index a3e4660..282a6f3 100644
--- a/frontend/src/router/routes/machines.js
+++ b/plugins/machines/frontend/routes.js
@@ -5,25 +5,25 @@ export default [
   {
     path: 'machines',
     name: 'machines',
-    component: () => import('../../views/machines/MachinesList.vue'),
+    component: () => import('./views/MachinesList.vue'),
     meta: { plugin: 'machines' }
   },
   {
     path: 'machines/new',
     name: 'machine-new',
-    component: () => import('../../views/machines/MachineForm.vue'),
+    component: () => import('./views/MachineForm.vue'),
     meta: { requiresAuth: true, plugin: 'machines' }
   },
   {
     path: 'machines/:id',
     name: 'machine-detail',
-    component: () => import('../../views/machines/MachineDetail.vue'),
+    component: () => import('./views/MachineDetail.vue'),
     meta: { plugin: 'machines' }
   },
   {
     path: 'machines/:id/edit',
     name: 'machine-edit',
-    component: () => import('../../views/machines/MachineForm.vue'),
+    component: () => import('./views/MachineForm.vue'),
     meta: { requiresAuth: true, plugin: 'machines' }
   }
 ]
diff --git a/frontend/src/views/machines/MachineDetail.vue b/plugins/machines/frontend/views/MachineDetail.vue
similarity index 96%
rename from frontend/src/views/machines/MachineDetail.vue
rename to plugins/machines/frontend/views/MachineDetail.vue
index 61cab8b..aa3841c 100644
--- a/frontend/src/views/machines/MachineDetail.vue
+++ b/plugins/machines/frontend/views/MachineDetail.vue
@@ -234,13 +234,13 @@
 <script setup>
 import { ref, onMounted } from 'vue'
 import { useRoute } from 'vue-router'
-import { machinesApi } from '../../api'
-import LocationMapTooltip from '../../components/LocationMapTooltip.vue'
-import CustomFieldsSection from '../../components/CustomFieldsSection.vue'
-import PluginAssetPanels from '../../components/PluginAssetPanels.vue'
-import AssetRelationships from '../../components/AssetRelationships.vue'
-import { useWarrantyBadge } from '../../composables/warrantyBadge'
-import { useIdentifierFlags } from '../../composables/identifierSettings'
+import { machinesApi } from '@/api'
+import LocationMapTooltip from '@/components/LocationMapTooltip.vue'
+import CustomFieldsSection from '@/components/CustomFieldsSection.vue'
+import PluginAssetPanels from '@/components/PluginAssetPanels.vue'
+import AssetRelationships from '@/components/AssetRelationships.vue'
+import { useWarrantyBadge } from '@/composables/warrantyBadge'
+import { useIdentifierFlags } from '@/composables/identifierSettings'
 
 const route = useRoute()
 const { isEnabled } = useIdentifierFlags()
diff --git a/frontend/src/views/machines/MachineForm.vue b/plugins/machines/frontend/views/MachineForm.vue
similarity index 98%
rename from frontend/src/views/machines/MachineForm.vue
rename to plugins/machines/frontend/views/MachineForm.vue
index 7b9c209..dde53cd 100644
--- a/frontend/src/views/machines/MachineForm.vue
+++ b/plugins/machines/frontend/views/MachineForm.vue
@@ -347,13 +347,13 @@
 <script setup>
 import { ref, onMounted, computed, watch } from 'vue'
 import { useRoute, useRouter } from 'vue-router'
-import { machinesApi, vendorsApi, locationsApi, modelsApi, businessunitsApi, computersApi, assetsApi, relationshipTypesApi } from '../../api'
-import ShopFloorMap from '../../components/ShopFloorMap.vue'
-import Modal from '../../components/Modal.vue'
-import CustomFieldsInputs from '../../components/CustomFieldsInputs.vue'
-import { currentTheme } from '../../stores/theme'
-import { useIdentifierFlags } from '../../composables/identifierSettings'
-import { apiError } from '../../utils/apiError'
+import { machinesApi, vendorsApi, locationsApi, modelsApi, businessunitsApi, computersApi, assetsApi, relationshipTypesApi } from '@/api'
+import ShopFloorMap from '@/components/ShopFloorMap.vue'
+import Modal from '@/components/Modal.vue'
+import CustomFieldsInputs from '@/components/CustomFieldsInputs.vue'
+import { currentTheme } from '@/stores/theme'
+import { useIdentifierFlags } from '@/composables/identifierSettings'
+import { apiError } from '@/utils/apiError'
 
 const { isEnabled } = useIdentifierFlags()
 
diff --git a/frontend/src/views/machines/MachinesList.vue b/plugins/machines/frontend/views/MachinesList.vue
similarity index 97%
rename from frontend/src/views/machines/MachinesList.vue
rename to plugins/machines/frontend/views/MachinesList.vue
index b31db8f..a1afc13 100644
--- a/frontend/src/views/machines/MachinesList.vue
+++ b/plugins/machines/frontend/views/MachinesList.vue
@@ -85,8 +85,8 @@
 <script setup>
 import { ref, onMounted } from 'vue'
 import { colorStyle } from "@/utils/colorStyle"
-import { machinesApi } from '../../api'
-import PaginationBar from '../../components/PaginationBar.vue'
+import { machinesApi } from '@/api'
+import PaginationBar from '@/components/PaginationBar.vue'
 import { useListQuery } from '@/composables/listQuery'
 
 const machines = ref([])
diff --git a/scripts/stage-frontend.mjs b/scripts/stage-frontend.mjs
index 6e2ac2f..a38bb6c 100644
--- a/scripts/stage-frontend.mjs
+++ b/scripts/stage-frontend.mjs
@@ -45,11 +45,11 @@ const childParts = []
 const topParts = []
 for (const name of chosen) {
   const id = 'p_' + name.replace(/[^a-zA-Z0-9]/g, '_')
-  lines.push(
-    `import ${id}Default, { toplevel as ${id}Top } from `
-    + `'../.plugins-staged/${name}/routes.js'`)
-  childParts.push(`...(${id}Default || [])`)
-  topParts.push(`...(${id}Top || [])`)
+  // Namespace import so a route file without a `toplevel` export is not a
+  // (strict ESM) build error - the binding is just undefined on the namespace.
+  lines.push(`import * as ${id} from '../.plugins-staged/${name}/routes.js'`)
+  childParts.push(`...(${id}.default || [])`)
+  topParts.push(`...(${id}.toplevel || [])`)
 }
 lines.push('')
 lines.push(`export const stagedChildren = [${childParts.join(', ')}]`)