Fleet list rebuild and the endpoints permission split

shopdb/__init__.py

@@ -81,7 +81,14 @@ from .plugins import plugin_manager
 # endpoints command claim/result long-poll callbacks) on the same per-plugin
 # collector key + managed-token check the ingest route uses, without importing
 # core collector internals. Additive name on the surface, minor bump.
-__contract_version__ = '0.24.0'
+# 0.25.0: added caller_holds(permission) to shopdb.api so a route can ask
+# whether THIS caller holds a permission without refusing the request. It is for
+# a surface that serves everyone but should only OFFER what the caller can use:
+# the endpoints services panel emitted Start/Stop to every reader because the
+# emission never consulted the caller, so a read-only viewer was shown controls
+# over a shop-floor PC that 403 on click. Guests are included, since a signed-out
+# visitor holds whatever the guest role was granted. Additive name, minor bump.
+__contract_version__ = '0.25.0'
 
 # Product release version (see ADR-007). The product version and the
 # plugin-contract version above are distinct series with independent

shopdb/api/__init__.py

@@ -68,7 +68,8 @@ from shopdb.utils.responses import (
 from shopdb.utils.pagination import get_pagination_params, paginate_query
 
 # Authorization decorators for gating plugin write routes
-from shopdb.utils.authz import require_permission, require_any_permission, require_role
+from shopdb.utils.authz import (require_permission, require_any_permission,
+                                require_role, caller_holds)
 
 # Service-token authorization for unattended plugin endpoints (collector,
 # GE-Enforce fetch, ...): checks a scoped managed token without exposing token
@@ -331,6 +332,7 @@ __all__ = [
     # Authorization decorators
     'require_permission',
     'require_any_permission',
+    'caller_holds',
     'require_role',
     'service_token_authorized',
     'authorized_service_token',

shopdb/utils/authz.py

@@ -86,6 +86,32 @@ def guestholds(permission_name: str) -> bool:
     return any(p.name == permission_name for p in role.permissions)
 
 
+def caller_holds(permission_name: str) -> bool:
+    """Whether THIS caller holds a permission, without refusing the request.
+
+    require_permission answers the same question by returning 401/403. This
+    answers it in the body, for the case where a route serves everyone but
+    should only OFFER something to the callers who can use it.
+
+    The endpoints services panel is the example that prompted it: it emitted
+    Start/Stop buttons for every reader, because the emission never consulted
+    the caller. Clicking them 403s, so nothing was exploitable, but showing a
+    read-only viewer controls over a shop-floor PC is the wrong signal - and it
+    gets worse the moment a site grants that panel to guests.
+
+    Guests are included on purpose: a signed-out visitor holds whatever the
+    guest role was granted, so the answer must come from the same place
+    require_permission gets it.
+    """
+    user = currentuser()
+    if user is None:
+        return guestholds(permission_name)
+    try:
+        return bool(user.haspermission(permission_name))
+    except Exception:
+        return False
+
+
 def require_permission(permission_name: str):
     """Gate a route behind a single permission. Admin role bypasses.