From 592ff49abefcd227f90658679bdf9bbc0fcdc168 Mon Sep 17 00:00:00 2001
From: cproudlock <cproudlock@localhost>
Date: Sun, 19 Jul 2026 00:02:32 -0400
Subject: [PATCH] ADR-013 Phase 4: extract the 11 plugin routes embedded in
 core.js

core.js still routed plugin-owned pages directly. Extracted all 11 into the
owning plugin's route file + moved their views into plugins/<name>/frontend/:
- computers: reports/pc-relationships, settings/pctypemapping
- printers: reports/toner, settings/printertypes, settings/zabbix (toner/supply
  monitoring)
- machines: settings/machinetypes
- network: settings/networktypes
- warranty: settings/dellwarranty
- slides: settings/slides (its route file gains a default export; it was
  toplevel-only)
- employees: NEW plugin frontend (employees/:sso + settings/employeedirectory) -
  employees had no route file before; its pages lived only in core.js.

core.js now holds only core routes; all 14 bundled plugins are self-contained
under plugins/<name>/frontend/. Verified live: the extracted Machine Types
settings page renders in the settings rail from the machines plugin frontend.
Build + 58 vitest + naming green.
---
 frontend/src/router/routes/core.js            | 66 -------------------
 plugins/computers/frontend/routes.js          | 12 ++++
 .../frontend/views}/PCRelationshipsReport.vue |  2 +-
 .../frontend/views}/PCTypeMappingSettings.vue |  0
 plugins/employees/frontend/routes.js          | 18 +++++
 .../frontend/views}/EmployeeDetail.vue        |  4 +-
 .../frontend/views}/EmployeeDirectory.vue     |  6 +-
 plugins/machines/frontend/routes.js           |  6 ++
 .../frontend/views}/MachineTypesList.vue      |  6 +-
 plugins/network/frontend/routes.js            |  6 ++
 .../frontend/views}/NetworkTypesList.vue      |  6 +-
 plugins/printers/frontend/routes.js           | 18 +++++
 .../frontend/views}/PrinterTypesList.vue      |  6 +-
 .../printers/frontend/views}/TonerReport.vue  |  2 +-
 .../frontend/views}/ZabbixSettings.vue        |  2 +-
 plugins/slides/frontend/routes.js             |  9 +++
 .../slides/frontend/views}/SlideManager.vue   |  0
 plugins/warranty/frontend/routes.js           |  6 ++
 .../frontend/views}/DellWarrantySettings.vue  |  2 +-
 19 files changed, 93 insertions(+), 84 deletions(-)
 rename {frontend/src/views/reports => plugins/computers/frontend/views}/PCRelationshipsReport.vue (95%)
 rename {frontend/src/views/settings => plugins/computers/frontend/views}/PCTypeMappingSettings.vue (100%)
 create mode 100644 plugins/employees/frontend/routes.js
 rename {frontend/src/views/employees => plugins/employees/frontend/views}/EmployeeDetail.vue (99%)
 rename {frontend/src/views/settings => plugins/employees/frontend/views}/EmployeeDirectory.vue (98%)
 rename {frontend/src/views/settings => plugins/machines/frontend/views}/MachineTypesList.vue (97%)
 rename {frontend/src/views/settings => plugins/network/frontend/views}/NetworkTypesList.vue (97%)
 rename {frontend/src/views/settings => plugins/printers/frontend/views}/PrinterTypesList.vue (97%)
 rename {frontend/src/views/reports => plugins/printers/frontend/views}/TonerReport.vue (95%)
 rename {frontend/src/views/settings => plugins/printers/frontend/views}/ZabbixSettings.vue (97%)
 rename {frontend/src/views/settings => plugins/slides/frontend/views}/SlideManager.vue (100%)
 rename {frontend/src/views/settings => plugins/warranty/frontend/views}/DellWarrantySettings.vue (98%)

diff --git a/frontend/src/router/routes/core.js b/frontend/src/router/routes/core.js
index 34b094d..0d98321 100644
--- a/frontend/src/router/routes/core.js
+++ b/frontend/src/router/routes/core.js
@@ -28,24 +28,6 @@ export default [
     name: 'reports',
     component: () => import('../../views/reports/ReportsIndex.vue')
   },
-  {
-    path: 'reports/pc-relationships',
-    name: 'report-pc-relationships',
-    component: () => import('../../views/reports/PCRelationshipsReport.vue'),
-    meta: { plugin: 'computers' }
-  },
-  {
-    path: 'reports/toner',
-    name: 'toner-report',
-    component: () => import('../../views/reports/TonerReport.vue'),
-    meta: { plugin: 'printers' }
-  },
-  {
-    path: 'employees/:sso',
-    name: 'employee-detail',
-    component: () => import('../../views/employees/EmployeeDetail.vue'),
-    meta: { plugin: 'employees' }
-  },
   // Settings
   {
     path: 'settings',
@@ -107,30 +89,6 @@ export default [
     component: () => import('../../views/settings/SiteSettings.vue'),
     meta: { requiresAuth: true, requiresAdmin: true }
   },
-  {
-    path: 'settings/slides',
-    name: 'slide-manager',
-    component: () => import('../../views/settings/SlideManager.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'slides' }
-  },
-  {
-    path: 'settings/machinetypes',
-    name: 'machinetypes',
-    component: () => import('../../views/settings/MachineTypesList.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true }
-  },
-  {
-    path: 'settings/networktypes',
-    name: 'network-types',
-    component: () => import('../../views/settings/NetworkTypesList.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true }
-  },
-  {
-    path: 'settings/printertypes',
-    name: 'printer-types',
-    component: () => import('../../views/settings/PrinterTypesList.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true }
-  },
   {
     path: 'settings/relationshiptypes',
     name: 'relationship-types',
@@ -155,12 +113,6 @@ export default [
     component: () => import('../../views/settings/CustomFieldsList.vue'),
     meta: { requiresAuth: true, requiresAdmin: true }
   },
-  {
-    path: 'settings/employeedirectory',
-    name: 'employee-directory',
-    component: () => import('../../views/settings/EmployeeDirectory.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true }
-  },
   // The old monolithic System Settings tab page is split into one routed page
   // per section (below). This redirect keeps old bookmarks working: bare
   // /settings/system and every /settings/system?tab=<key> land on the right page.
@@ -192,24 +144,6 @@ export default [
     component: () => import('../../views/settings/ServiceNowSettings.vue'),
     meta: { requiresAuth: true, requiresAdmin: true }
   },
-  {
-    path: 'settings/zabbix',
-    name: 'zabbix-settings',
-    component: () => import('../../views/settings/ZabbixSettings.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true }
-  },
-  {
-    path: 'settings/dellwarranty',
-    name: 'dell-warranty-settings',
-    component: () => import('../../views/settings/DellWarrantySettings.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true }
-  },
-  {
-    path: 'settings/pctypemapping',
-    name: 'pctype-mapping-settings',
-    component: () => import('../../views/settings/PCTypeMappingSettings.vue'),
-    meta: { requiresAuth: true, requiresAdmin: true }
-  },
   {
     path: 'settings/branding',
     name: 'branding-settings',
diff --git a/plugins/computers/frontend/routes.js b/plugins/computers/frontend/routes.js
index 71ad106..7a91ba8 100644
--- a/plugins/computers/frontend/routes.js
+++ b/plugins/computers/frontend/routes.js
@@ -2,6 +2,18 @@
  * Computers plugin routes
  */
 export default [
+  {
+    path: 'reports/pc-relationships',
+    name: 'report-pc-relationships',
+    component: () => import('./views/PCRelationshipsReport.vue'),
+    meta: { plugin: 'computers' }
+  },
+  {
+    path: 'settings/pctypemapping',
+    name: 'pctype-mapping-settings',
+    component: () => import('./views/PCTypeMappingSettings.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'computers' }
+  },
   {
     path: 'pcs',
     name: 'pcs',
diff --git a/frontend/src/views/reports/PCRelationshipsReport.vue b/plugins/computers/frontend/views/PCRelationshipsReport.vue
similarity index 95%
rename from frontend/src/views/reports/PCRelationshipsReport.vue
rename to plugins/computers/frontend/views/PCRelationshipsReport.vue
index 9cc0862..c6aea90 100644
--- a/frontend/src/views/reports/PCRelationshipsReport.vue
+++ b/plugins/computers/frontend/views/PCRelationshipsReport.vue
@@ -54,7 +54,7 @@
 
 <script setup>
 import { ref, onMounted } from 'vue'
-import { reportsApi } from '../../api'
+import { reportsApi } from '@/api'
 
 const loading = ref(true)
 const data = ref([])
diff --git a/frontend/src/views/settings/PCTypeMappingSettings.vue b/plugins/computers/frontend/views/PCTypeMappingSettings.vue
similarity index 100%
rename from frontend/src/views/settings/PCTypeMappingSettings.vue
rename to plugins/computers/frontend/views/PCTypeMappingSettings.vue
diff --git a/plugins/employees/frontend/routes.js b/plugins/employees/frontend/routes.js
new file mode 100644
index 0000000..1ac2366
--- /dev/null
+++ b/plugins/employees/frontend/routes.js
@@ -0,0 +1,18 @@
+/**
+ * Employees plugin frontend routes (ADR-013 Phase 4). Extracted from core.js -
+ * employee detail + the directory settings page belong to the employees plugin.
+ */
+export default [
+  {
+    path: 'employees/:sso',
+    name: 'employee-detail',
+    component: () => import('./views/EmployeeDetail.vue'),
+    meta: { plugin: 'employees' }
+  },
+  {
+    path: 'settings/employeedirectory',
+    name: 'employee-directory',
+    component: () => import('./views/EmployeeDirectory.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'employees' }
+  }
+]
diff --git a/frontend/src/views/employees/EmployeeDetail.vue b/plugins/employees/frontend/views/EmployeeDetail.vue
similarity index 99%
rename from frontend/src/views/employees/EmployeeDetail.vue
rename to plugins/employees/frontend/views/EmployeeDetail.vue
index 138bf3a..56dc967 100644
--- a/frontend/src/views/employees/EmployeeDetail.vue
+++ b/plugins/employees/frontend/views/EmployeeDetail.vue
@@ -149,10 +149,10 @@
 <script setup>
 import { ref, computed, onMounted } from 'vue'
 import { useRoute } from 'vue-router'
-import { withBase } from '../../utils/basePath'
+import { withBase } from '@/utils/basePath'
 import { employeesApi, usbApi, notificationsApi } from '@/api'
 import { isPluginEnabled, loadEnabledPlugins } from '@/composables/enabledPlugins'
-import { useToast } from '../../composables/toast'
+import { useToast } from '@/composables/toast'
 const toast = useToast()
 
 const route = useRoute()
diff --git a/frontend/src/views/settings/EmployeeDirectory.vue b/plugins/employees/frontend/views/EmployeeDirectory.vue
similarity index 98%
rename from frontend/src/views/settings/EmployeeDirectory.vue
rename to plugins/employees/frontend/views/EmployeeDirectory.vue
index 404e085..3d4c0db 100644
--- a/frontend/src/views/settings/EmployeeDirectory.vue
+++ b/plugins/employees/frontend/views/EmployeeDirectory.vue
@@ -134,9 +134,9 @@
 
 <script setup>
 import { ref, computed, watch, onMounted } from 'vue'
-import { employeesApi, settingsApi } from '../../api'
-import { useToast } from '../../composables/toast'
-import { apiError } from '../../utils/apiError'
+import { employeesApi, settingsApi } from '@/api'
+import { useToast } from '@/composables/toast'
+import { apiError } from '@/utils/apiError'
 
 const toast = useToast()
 const selfhosted = ref(false)
diff --git a/plugins/machines/frontend/routes.js b/plugins/machines/frontend/routes.js
index 282a6f3..c5f119a 100644
--- a/plugins/machines/frontend/routes.js
+++ b/plugins/machines/frontend/routes.js
@@ -2,6 +2,12 @@
  * Machines plugin routes
  */
 export default [
+  {
+    path: 'settings/machinetypes',
+    name: 'machinetypes',
+    component: () => import('./views/MachineTypesList.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'machines' }
+  },
   {
     path: 'machines',
     name: 'machines',
diff --git a/frontend/src/views/settings/MachineTypesList.vue b/plugins/machines/frontend/views/MachineTypesList.vue
similarity index 97%
rename from frontend/src/views/settings/MachineTypesList.vue
rename to plugins/machines/frontend/views/MachineTypesList.vue
index 3339aa9..30588b5 100644
--- a/frontend/src/views/settings/MachineTypesList.vue
+++ b/plugins/machines/frontend/views/MachineTypesList.vue
@@ -73,11 +73,11 @@
 
 <script setup>
 import { ref, computed, onMounted } from 'vue'
-import { machinesApi } from '../../api'
+import { machinesApi } from '@/api'
 import ColorSwatchPicker from '@/components/ColorSwatchPicker.vue'
 import { colorStyle } from '@/utils/colorStyle'
-import { useToast } from '../../composables/toast'
-import { apiError } from '../../utils/apiError'
+import { useToast } from '@/composables/toast'
+import { apiError } from '@/utils/apiError'
 const toast = useToast()
 
 const items = ref([])
diff --git a/plugins/network/frontend/routes.js b/plugins/network/frontend/routes.js
index d69d0f6..15da90b 100644
--- a/plugins/network/frontend/routes.js
+++ b/plugins/network/frontend/routes.js
@@ -2,6 +2,12 @@
  * Network plugin routes
  */
 export default [
+  {
+    path: 'settings/networktypes',
+    name: 'network-types',
+    component: () => import('./views/NetworkTypesList.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'network' }
+  },
   {
     path: 'network',
     name: 'network',
diff --git a/frontend/src/views/settings/NetworkTypesList.vue b/plugins/network/frontend/views/NetworkTypesList.vue
similarity index 97%
rename from frontend/src/views/settings/NetworkTypesList.vue
rename to plugins/network/frontend/views/NetworkTypesList.vue
index ef9ce57..c779d74 100644
--- a/frontend/src/views/settings/NetworkTypesList.vue
+++ b/plugins/network/frontend/views/NetworkTypesList.vue
@@ -73,11 +73,11 @@
 
 <script setup>
 import { ref, computed, onMounted } from 'vue'
-import { networkApi } from '../../api'
+import { networkApi } from '@/api'
 import ColorSwatchPicker from '@/components/ColorSwatchPicker.vue'
 import { colorStyle } from '@/utils/colorStyle'
-import { useToast } from '../../composables/toast'
-import { apiError } from '../../utils/apiError'
+import { useToast } from '@/composables/toast'
+import { apiError } from '@/utils/apiError'
 const toast = useToast()
 
 const items = ref([])
diff --git a/plugins/printers/frontend/routes.js b/plugins/printers/frontend/routes.js
index d96380a..5a8796c 100644
--- a/plugins/printers/frontend/routes.js
+++ b/plugins/printers/frontend/routes.js
@@ -2,6 +2,24 @@
  * Printers plugin routes
  */
 export default [
+  {
+    path: 'reports/toner',
+    name: 'toner-report',
+    component: () => import('./views/TonerReport.vue'),
+    meta: { plugin: 'printers' }
+  },
+  {
+    path: 'settings/printertypes',
+    name: 'printer-types',
+    component: () => import('./views/PrinterTypesList.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'printers' }
+  },
+  {
+    path: 'settings/zabbix',
+    name: 'zabbix-settings',
+    component: () => import('./views/ZabbixSettings.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'printers' }
+  },
   {
     path: 'printers',
     name: 'printers',
diff --git a/frontend/src/views/settings/PrinterTypesList.vue b/plugins/printers/frontend/views/PrinterTypesList.vue
similarity index 97%
rename from frontend/src/views/settings/PrinterTypesList.vue
rename to plugins/printers/frontend/views/PrinterTypesList.vue
index 7510cd0..5789891 100644
--- a/frontend/src/views/settings/PrinterTypesList.vue
+++ b/plugins/printers/frontend/views/PrinterTypesList.vue
@@ -73,11 +73,11 @@
 
 <script setup>
 import { ref, computed, onMounted } from 'vue'
-import { printersApi } from '../../api'
+import { printersApi } from '@/api'
 import ColorSwatchPicker from '@/components/ColorSwatchPicker.vue'
 import { colorStyle } from '@/utils/colorStyle'
-import { useToast } from '../../composables/toast'
-import { apiError } from '../../utils/apiError'
+import { useToast } from '@/composables/toast'
+import { apiError } from '@/utils/apiError'
 const toast = useToast()
 
 const items = ref([])
diff --git a/frontend/src/views/reports/TonerReport.vue b/plugins/printers/frontend/views/TonerReport.vue
similarity index 95%
rename from frontend/src/views/reports/TonerReport.vue
rename to plugins/printers/frontend/views/TonerReport.vue
index 9517427..b0c3500 100644
--- a/frontend/src/views/reports/TonerReport.vue
+++ b/plugins/printers/frontend/views/TonerReport.vue
@@ -101,7 +101,7 @@
 <script setup>
 import { ref, computed, onMounted } from 'vue'
 import { printersApi } from '@/api'
-import EmailReportButton from '../../components/EmailReportButton.vue'
+import EmailReportButton from '@/components/EmailReportButton.vue'
 
 const emailColumns = [
   { key: 'printer', label: 'Printer' },
diff --git a/frontend/src/views/settings/ZabbixSettings.vue b/plugins/printers/frontend/views/ZabbixSettings.vue
similarity index 97%
rename from frontend/src/views/settings/ZabbixSettings.vue
rename to plugins/printers/frontend/views/ZabbixSettings.vue
index 4289e44..fd1a5ca 100644
--- a/frontend/src/views/settings/ZabbixSettings.vue
+++ b/plugins/printers/frontend/views/ZabbixSettings.vue
@@ -65,7 +65,7 @@
 
 <script setup>
 import { onMounted, computed } from 'vue'
-import { useSystemSettings } from '../../composables/systemSettings'
+import { useSystemSettings } from '@/composables/systemSettings'
 
 const {
   settings, saving, error, success,
diff --git a/plugins/slides/frontend/routes.js b/plugins/slides/frontend/routes.js
index 772992b..aac2eb9 100644
--- a/plugins/slides/frontend/routes.js
+++ b/plugins/slides/frontend/routes.js
@@ -1,4 +1,13 @@
 
+export default [
+  {
+    path: 'settings/slides',
+    name: 'slide-manager',
+    component: () => import('./views/SlideManager.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'slides' }
+  }
+]
+
 export const toplevel = [
   {
     path: '/tv',
diff --git a/frontend/src/views/settings/SlideManager.vue b/plugins/slides/frontend/views/SlideManager.vue
similarity index 100%
rename from frontend/src/views/settings/SlideManager.vue
rename to plugins/slides/frontend/views/SlideManager.vue
diff --git a/plugins/warranty/frontend/routes.js b/plugins/warranty/frontend/routes.js
index c9a4ff9..b5c2c29 100644
--- a/plugins/warranty/frontend/routes.js
+++ b/plugins/warranty/frontend/routes.js
@@ -2,6 +2,12 @@
  * Warranty plugin routes
  */
 export default [
+  {
+    path: 'settings/dellwarranty',
+    name: 'dell-warranty-settings',
+    component: () => import('./views/DellWarrantySettings.vue'),
+    meta: { requiresAuth: true, requiresAdmin: true, plugin: 'warranty' }
+  },
   {
     path: 'warranties',
     name: 'warranties',
diff --git a/frontend/src/views/settings/DellWarrantySettings.vue b/plugins/warranty/frontend/views/DellWarrantySettings.vue
similarity index 98%
rename from frontend/src/views/settings/DellWarrantySettings.vue
rename to plugins/warranty/frontend/views/DellWarrantySettings.vue
index 8c3a0da..55ca0cb 100644
--- a/frontend/src/views/settings/DellWarrantySettings.vue
+++ b/plugins/warranty/frontend/views/DellWarrantySettings.vue
@@ -92,7 +92,7 @@
 
 <script setup>
 import { onMounted, computed } from 'vue'
-import { useSystemSettings } from '../../composables/systemSettings'
+import { useSystemSettings } from '@/composables/systemSettings'
 
 const {
   settings, saving, error, success,