Apply skill-driven review fixes: security, hook isolation, tests, docs
Addresses findings from a 6-lens review against the project skills (defining-asset-contract, enforcing-plugin-contract, hardening-flask-config, integrating-plugin-hooks, pinning-flask-behavior, simplifying-python). Security (hardening-flask-config): - Load per-plugin COLLECTOR_API_KEY_<PLUGIN> from env in create_app. from_object only copies class attributes, so per-plugin keys (ADR-006) were dead in real deploys and silently fell back to the shared key. - EMPLOYEE_DB_USER/PASSWORD no longer default to root/rootpassword (no safe default for a secret; unset fails loud). Documented in .env.example + DEPLOY.md. - COLLECTOR_API_KEY + per-plugin + EMPLOYEE_DB_* added to .env.example/DEPLOY.md. Hook isolation (integrating-plugin-hooks): - collector _collector_plugins and dashboard get_navigation now re-raise in dev/test and log+isolate in prod, instead of silently swallowing a broken plugin hook. Plugin loader (enforcing-plugin-contract): - enable_plugin/install_plugin read dependencies+version from the manifest instead of instantiating the plugin class. - _register_plugin_components rejects a second plugin claiming an already-used api_prefix (reset per app in init_app). Tests (pinning-flask-behavior): - test_identifiers.py: gauge/maintenance round-trip on computer/printer/network create+update; per-type seed yields the 12 identifier keys. - contract tests for apply_collector_payload presence + schema-declarers-implement. - security tests for per-plugin key env loading + no employee-db password default. Docs/contract sync (defining-asset-contract): - PLUGIN-HOOKS.md documents apply_collector_payload; stale 0.2.0 -> 0.3.0. - ADR-006 documents apply_collector_payload + single-dispatch rationale. - ADR-001 enumerates the expanded shopdb.api import surface. Simplify (simplifying-python): - De-duplicate the 21-entry settings defaults: shared build_default_settings() used by both the /settings/seed route and the CLI (were drifting copies). - Remove dead AssetStatus import + redundant AssetType local import in computers plugin; comment the statusid=1 collector default. 153 tests pass (was 145), naming/style green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -146,6 +146,23 @@ def test_baseplugin_has_collector_schema_hook():
|
||||
assert hasattr(BasePlugin, 'get_collector_schema')
|
||||
|
||||
|
||||
def test_baseplugin_has_apply_collector_payload_hook():
|
||||
"""The collector upsert hook is on the contract surface (ADR-006)."""
|
||||
assert hasattr(BasePlugin, 'apply_collector_payload')
|
||||
|
||||
|
||||
def test_schema_declaring_plugins_implement_apply(plugin_instances):
|
||||
"""Any plugin returning a collector schema must implement the upsert hook."""
|
||||
for name, plugin in plugin_instances.items():
|
||||
if plugin.get_collector_schema() is not None:
|
||||
overridden = type(plugin).apply_collector_payload \
|
||||
is not BasePlugin.apply_collector_payload
|
||||
assert overridden, (
|
||||
f'Plugin {name} declares a collector schema but does not '
|
||||
f'override apply_collector_payload'
|
||||
)
|
||||
|
||||
|
||||
# Imports a plugin may make from the core. shopdb.api is the contract surface;
|
||||
# shopdb.plugins.base is the plugin ABC. Anything else (shopdb.core.*,
|
||||
# shopdb.extensions, shopdb.utils.*) is a contract violation per ADR-001.
|
||||
|
||||
Reference in New Issue
Block a user