Register the endpoints list without a trailing slash, and stop hiding its errors

plugins/endpoints/api/routes.py

@@ -55,11 +55,25 @@ def _format_uptime(seconds):
 # Endpoint state
 # =============================================================================
 
-@endpoints_bp.route('/', methods=['GET'])
+@endpoints_bp.route('', methods=['GET'])
 @require_permission('endpoints.view')
 def list_endpoints():
     """List reported endpoint states.
 
+    Registered as '' so the rule is '/api/endpoints', with no trailing slash.
+    CONTRIBUTING.md's API section spells endpoints that way ('/api/machines'),
+    and every other plugin's list route follows it - this was the only route in
+    331 paths that did not.
+
+    It was not cosmetic. A rule ending in a slash makes Flask answer the
+    unslashed URL with a 308 to an ABSOLUTE url. On dev that resolves and
+    nobody notices. Behind the IIS subpath it does not: with no ProxyFix,
+    Werkzeug builds that Location from the scheme and host it believes it has,
+    so it emitted http:// and dropped the /shopdb prefix. The browser refuses
+    to follow an https page to http, the list request failed, and the page
+    rendered "No endpoints found" - indistinguishable from a fleet with nothing
+    in it. The agent had been reporting correctly the whole time.
+
     Joins through Computer so each row carries computerid and can deep-link
     into the existing PC detail page (/pcs/{computerid}). Endpoint state only
     exists for hostnames resolved to a Computer, so the join is not lossy.

plugins/endpoints/frontend/views/EndpointsList.vue

@@ -18,6 +18,10 @@
     <div class="card">
       <div v-if="loading" class="loading">Loading...</div>
 
+      <div v-else-if="loadError" class="load-error">
+        {{ loadError }}
+      </div>
+
       <template v-else>
         <div class="table-container">
           <table>
@@ -78,6 +82,12 @@ import { useListQuery } from '@/composables/listQuery'
 const router = useRouter()
 const endpoints = ref([])
 const loading = ref(true)
+// A failed request used to leave endpoints as [] and render "No endpoints
+// found", which is the same thing a healthy empty fleet shows. A trailing-slash
+// redirect broke this list in production while the agent reported correctly all
+// along, and the page said only that there was nothing to see. An error must
+// look like an error.
+const loadError = ref('')
 const { page, search, setPage, setSearch } = useListQuery({ onChange: loadEndpoints })
 const totalPages = ref(1)
 const perPage = ref(20)
@@ -97,11 +107,20 @@ async function loadEndpoints() {
     }
     if (search.value) params.search = search.value
 
+    loadError.value = ''
     const response = await endpointsApi.list(params)
     endpoints.value = response.data.data || []
     totalPages.value = response.data.meta?.pagination?.totalpages || response.data.meta?.pagination?.total_pages || 1
   } catch (error) {
     console.error('Error loading endpoints:', error)
+    endpoints.value = []
+    // Name the status. 403 and 404 are the two that get misread as "no
+    // endpoints": the first means the role lacks endpoints.view, the second
+    // that the request never reached the route at all.
+    const status = error.response?.status
+    loadError.value = status
+      ? `Could not load endpoints (HTTP ${status}). This is a failed request, not an empty fleet.`
+      : 'Could not reach the server to load endpoints.'
   } finally {
     loading.value = false
   }
@@ -150,4 +169,10 @@ function changePerPage(newPerPage) {
   cursor: default;
   opacity: 0.6;
 }
+
+.load-error {
+  padding: 1.5rem;
+  text-align: center;
+  color: var(--danger);
+}
 </style>