Admit serviceprocess server-side and give Operator Reports its own tab
asset_panels() rewrites any group missing from ASSET_PANEL_GROUPS to 'details' before the client sees it, and Phase 3 never added 'serviceprocess' there. Both panels were relabelled on the wire, so the tab could not appear no matter how consistent the frontend was. That is why the tab was still missing after the schema fix - a second, unrelated cause wearing the same symptom. Operator Reports moves out of System Monitors into a tab of its own: that tab is machine-collected health, this is a person reporting something, and the thumbnail grid dwarfed the fact cards it sat between. Full width, since it is alone in the tab. panelGroups.spec.js claimed to cover four files and checked two; it now reads the server tuple as well. The plugin test's hand-copied set was a fifth copy and now derives from the server tuple instead.
This commit is contained in:
@@ -349,6 +349,12 @@
|
||||
<div v-show="activegroup === 'serviceprocess'" class="content-grid">
|
||||
<PluginAssetPanels :assetid="computer.assetid" group="serviceprocess" />
|
||||
</div>
|
||||
<!-- Full width, unlike the two above: the thumbnail grid wants the room,
|
||||
and it is the only card in this tab so there is nothing to flow
|
||||
beside it. -->
|
||||
<div v-show="activegroup === 'reports'" class="detail-full">
|
||||
<PluginAssetPanels :assetid="computer.assetid" group="reports" />
|
||||
</div>
|
||||
<div v-show="activegroup === 'activity'" class="detail-full">
|
||||
<PluginAssetPanels :assetid="computer.assetid" group="activity" />
|
||||
</div>
|
||||
@@ -456,6 +462,10 @@ const detailtabs = computed(() => {
|
||||
if (has('serviceprocess')) {
|
||||
tabs.push({ key: 'serviceprocess', label: 'Service/Process Monitors' })
|
||||
}
|
||||
// Operator Reports earns a tab rather than a card in System Monitors: it is
|
||||
// what a person reported, not what the agent measured, and the thumbnail
|
||||
// grid is much bulkier than the fact cards around it.
|
||||
if (has('reports')) tabs.push({ key: 'reports', label: 'Operator Reports' })
|
||||
if (has('software') || installedApps.value.length > 0) {
|
||||
tabs.push({ key: 'software', label: 'Software', count: installedApps.value.length || null })
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user