Let a typed employee name find the employee
Reported from the floor: somebody types the employee's whole name into the notification or recognition picker and presses Enter instead of clicking the suggestion, and the entry does not pull from the employee database. Two causes, one symptom. The search matched the WHOLE query against first name or last name, so "Dana Reyes" found nobody - no single column holds that string. Typing a full name is what a person does before pressing Enter, and it was the one thing guaranteed to return an empty list. A multi-word query is now treated as a full name: every word must appear somewhere in the name, in either column, so "Reyes Dana" works too, and "Dana Reyes" does not also return Sam Reyes. A single word still searches broadly, and an SSO still resolves. Both directory backends changed, the self-hosted tables and the external HR database. With no suggestion to click, the form then turned the typed text into `NAME:<text>` - a label linked to nothing. On screen that chip is identical to a real selection; the difference only shows up later as no photo, no directory link, and a recognition the person it is about cannot be found by. Both pickers (the notifications form and the shared EmployeeSearch component) now look a typed name up before deciding it is free text, through one helper. An exact full-name match wins over a longer partial one, because somebody typing "Dana Reyes" means that person and not "Dana Reyes-Smith". A genuinely ambiguous name is NOT guessed at - the candidates are shown and the operator picks, which is exactly when picking wrong matters most. A directory that cannot be reached reports failure rather than silently producing a label. Eleven tests. The search rules verified by planting the single-term query back. One note for whoever reads the spec: the failure-branch test uses a thenable that rejects rather than a mock returning a rejected promise. The runner collects such a promise as an unhandled error even when the code under test catches it, and fails the very test that proves the catch works. Scope: product
This commit is contained in:
@@ -244,6 +244,7 @@
|
||||
import { ref, onMounted, computed, watch } from 'vue'
|
||||
import { useRoute, useRouter } from 'vue-router'
|
||||
import { notificationsApi, applicationsApi, businessUnitsApi, employeesApi, settingsApi } from '@/api'
|
||||
import { resolveEmployeeName, fullname } from '@/composables/employeeResolve'
|
||||
import { apiError } from '@/utils/apiError'
|
||||
import { zonedInputFromUtc, utcFromZonedInput, DEFAULT_TZ } from '@/utils/datetime'
|
||||
|
||||
@@ -459,6 +460,30 @@ async function addCustomEmployee() {
|
||||
}
|
||||
selectedEmployees.value.push({ sso: token, name })
|
||||
} else {
|
||||
// Look the name up before treating it as free text. Typing a name in
|
||||
// full and pressing Enter used to produce `NAME:<text>`, linked to
|
||||
// nothing - no photo, no directory record - while picking the same
|
||||
// person off the suggestion list produced a real SSO. The chip looked
|
||||
// identical either way, which is why it went unnoticed.
|
||||
const { match, matches, failed } = await resolveEmployeeName(token)
|
||||
if (match) {
|
||||
const sso = String(match.SSO)
|
||||
if (selectedEmployees.value.some(e => e.sso === sso)) continue
|
||||
selectedEmployees.value.push({ sso, name: fullname(match) || token })
|
||||
continue
|
||||
}
|
||||
if (matches && matches.length) {
|
||||
// Several people match. Guessing is exactly wrong here, so show the
|
||||
// list and let the operator pick.
|
||||
employeeResults.value = matches
|
||||
error.value = `More than one employee matches "${token}" - pick one.`
|
||||
return
|
||||
}
|
||||
if (failed) {
|
||||
error.value = 'Could not reach the employee directory. Try again, or '
|
||||
+ 'pick from the list.'
|
||||
return
|
||||
}
|
||||
const key = `NAME:${token}`
|
||||
if (selectedEmployees.value.some(e => e.sso === key)) continue
|
||||
selectedEmployees.value.push({ sso: key, name: token })
|
||||
|
||||
Reference in New Issue
Block a user