Endpoint telemetry, PC Detail rework and a checked backup/restore path

plugins/endpoints/api/agentupload.py

@@ -26,10 +26,18 @@ from shopdb.api import (success_response, error_response, ErrorCodes, AuditLog,
 from .routes import endpoints_bp
 from . import agentstore
 
-# Hard cap on an uploaded agent binary. The real agent is a few MB; this is a
-# generous ceiling that still refuses an operator who points at a giant wrong
-# file before it is buffered fully into memory-staged storage.
-_MAX_UPLOAD_BYTES = 64 * 1024 * 1024
+# Hard cap on an uploaded agent binary. This is a generous ceiling that still
+# refuses an operator who points at a giant wrong file before it is buffered
+# fully into memory-staged storage.
+#
+# 128 MB, not 64: the self-contained single-file tray publishes at ~69 MB
+# (it carries the whole .NET runtime plus WinForms), which the old 64 MB cap
+# rejected outright. The upload failed on SIZE, but the operator saw only a
+# version-detection failure, because the size check returns before the PE is
+# ever parsed. Config.MAX_CONTENT_LENGTH must stay above this - it bounds the
+# whole multipart envelope, so a cap equal to it would reject a legal file on
+# the boundary bytes alone.
+_MAX_UPLOAD_BYTES = 128 * 1024 * 1024
 
 
 @endpoints_bp.route('/siteagent/binaries/<binkey>', methods=['GET'])
@@ -69,11 +77,6 @@ def upload_agent_binary(binkey):
             ErrorCodes.VALIDATION_ERROR,
             'binkey must be one of: agent, tray',
             http_code=400)
-    if not agentstore.is_valid_version(version):
-        return error_response(
-            ErrorCodes.VALIDATION_ERROR,
-            'version must be a dotted-numeric string such as 1.6.3',
-            http_code=400)
 
     upload = request.files.get('file')
     if upload is None or not upload.filename:
@@ -94,6 +97,22 @@ def upload_agent_binary(binkey):
             'uploaded file is not a Windows executable',
             http_code=400)
 
+    # Gate the version at the PE, not at the raw input. Product versions carry
+    # semver build metadata (1.5.0+abcdef...) that is not a legal directory
+    # name, so the operator's typed string is only a hint. The dotted-numeric
+    # FILE version stamped in the binary's PE resource is the authority; fall
+    # back to it whenever the typed value is missing or not dotted-numeric, and
+    # only reject when neither yields a usable version.
+    if not agentstore.is_valid_version(version):
+        detected = agentstore.read_pe_file_version(data)
+        if agentstore.is_valid_version(detected):
+            version = detected
+        else:
+            return error_response(
+                ErrorCodes.VALIDATION_ERROR,
+                'version must be a dotted-numeric string such as 1.6.3',
+                http_code=400)
+
     result = agentstore.store_version(binkey, version, data,
                                       make_current=makecurrent)