ge-aerospace/shopdb-flask
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(employees): resolve User through the contract surface

Browse Source 
test_plugins_only_import_contract_surface has been failing on main since
9a2d0cc: the employee name resolver imported shopdb.core.models directly.
shopdb.api already exports User (contract 0.13.0), so this is the same object
reached the way ADR-001 requires.
This commit is contained in:
cproudlock
2026-08-03 11:17:28 -04:00
parent 6ebc79a2de
commit 9c2c21c2cc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/employees/api/routes.py
View File

@@ -153,7 +153,7 @@ def resolve_employee_display_name(sso):
# location not carried in the directory). Their name lives on the User # location not carried in the directory). Their name lives on the User
# record; GE usernames are the SSO. Photo still falls back to the GE mark. # record; GE usernames are the SSO. Photo still falls back to the GE mark.
try: try:
from shopdb.core.models import User from shopdb.api import User
user = User.query.filter_by(username=str(sso)).first() user = User.query.filter_by(username=str(sso)).first()
if user: if user:
name = f'{(user.firstname or "").strip()} {(user.lastname or "").strip()}'.strip() name = f'{(user.firstname or "").strip()} {(user.lastname or "").strip()}'.strip()