From ae7b30a056fc863ccb92b342ee1692757976222c Mon Sep 17 00:00:00 2001
From: cproudlock <cproudlock@localhost>
Date: Mon, 31 Aug 2026 13:03:32 -0400
Subject: [PATCH] Stop naming remote-access schemes as if they were constants

A link is built by formatting that protocol's own linktemplate, and the
templates are rows in accessprotocols that a site can edit. So no scheme
is a fixed fact about the product, and writing one down as though it were
misleads whoever reads it next.

Two places did. The guest-grant docstring said the detail route resolves
"working rdp:// and vnc:// links", which is wrong for the row we actually
ship: VNC is com.realvnc.vncviewer.connect://{host}:{port}, the RealVNC
handler, not vnc://. And the protocol admin form offered vnc://{host}:{port}
as its placeholder, in the one screen where somebody authors a new template,
so the example contradicted the seeded data it sits next to.

Neither changes behaviour. _computer_access_links already reads the
template from the database and the frontend only ever renders the resolved
link, so nothing in the code assumed a scheme - only the prose did.

Scope: product
---
 .../computers/frontend/views/AccessProtocolsList.vue |  2 +-
 plugins/computers/plugin.py                          | 12 +++++++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/plugins/computers/frontend/views/AccessProtocolsList.vue b/plugins/computers/frontend/views/AccessProtocolsList.vue
index 016b9675..13711685 100644
--- a/plugins/computers/frontend/views/AccessProtocolsList.vue
+++ b/plugins/computers/frontend/views/AccessProtocolsList.vue
@@ -69,7 +69,7 @@
           </label>
           <label class="field">
             <span>Link template</span>
-            <input v-model="form.linktemplate" type="text" maxlength="255" placeholder="vnc://{host}:{port}" />
+            <input v-model="form.linktemplate" type="text" maxlength="255" placeholder="scheme://{host}:{port}" />
             <small class="muted">Placeholders: <code>{host}</code>, <code>{port}</code>, <code>{scheme}</code></small>
           </label>
           <label class="field checkbox">
diff --git a/plugins/computers/plugin.py b/plugins/computers/plugin.py
index 3e6ed2ab..30863bff 100644
--- a/plugins/computers/plugin.py
+++ b/plugins/computers/plugin.py
@@ -2020,9 +2020,15 @@ class ComputersPlugin(BasePlugin):
         KNOWN GAP, tracked separately. The computer serializer is
         BaseModel.to_dict(), so it publishes every column - serialnumber, the
         Azure device and object ids - and the detail route resolves
-        accessmethods into working rdp:// and vnc:// links plus the full
-        Communication row. A guest granted this gets all of it, on the LIST
-        route as well, so it is one request rather than one per asset.
+        accessmethods into launch links, each built from that protocol's own
+        linktemplate, plus the full Communication row. A guest granted this
+        gets all of it, on the LIST route as well, so it is one request rather
+        than one per asset.
+
+        Do not name schemes here. The templates are site-editable rows in
+        accessprotocols, so what a link looks like is data, not a constant -
+        the shipped VNC row is com.realvnc.vncviewer.connect://, not vnc://,
+        and an earlier version of this docstring said otherwise for months.
 
         The fix is a field allowlist on Computer.to_dict() plus suppressing the
         resolved links unless the caller holds a remote-access permission. Do