Extract slideshow into a plugin (blueprint-only display plugin)

Second core feature pulled into a plugin. Slides is the minimal plugin shape:
a blueprint only - no model, no AssetType, no nav (it is purely an API surface
consumed by the TV dashboard).

- plugins/slides/: manifest (api_prefix /api/slides, no deps), api/ (moved
  blueprint, contract-pure imports via shopdb.api, same /api/slides route so the
  TV dashboard is unchanged), plugin.py (get_blueprint, get_models -> []).
- Fixed a latent bug in the move: error path used ErrorCodes.SERVER_ERROR which
  does not exist -> ErrorCodes.INTERNAL_ERROR.
- De-cored: deleted shopdb/core/api/slides.py, removed from CORE_BLUEPRINT_NAMES
  + core/api/__init__ import/__all__. Registered in instance/plugins.json.

Pinned with a characterization test first; passes unchanged against the plugin
blueprint. 174 tests pass, naming green, app boots 8 bundled plugins, /api/slides
verified live.

Note: the shopfloor dashboard is NOT extractable - it is a frontend-only Vue view
aggregating the businessunits + notifications APIs, with no backend to move and no
frontend plugin system.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
cproudlock
2026-06-26 20:50:32 -04:00
parent 8ddf771b72
commit b6ec4cb577
10 changed files with 171 additions and 78 deletions

View File

@@ -0,0 +1,14 @@
"""Characterization test for the slides (TV slideshow) endpoint.
Written before extracting slides into a plugin: /api/slides must behave
identically as a plugin blueprint (same prefix, same response shape).
"""
def test_slides_endpoint_shape(client, db):
"""GET /api/slides returns a slides list and a basepath (no auth required)."""
resp = client.get('/api/slides')
assert resp.status_code == 200
data = resp.get_json()['data']
assert isinstance(data['slides'], list)
assert 'basepath' in data

View File

@@ -17,7 +17,7 @@ from shopdb.plugins import plugin_manager
from shopdb.plugins.base import BasePlugin, PluginMeta
BUNDLED_PLUGINS = ('computers', 'equipment', 'knowledgebase', 'network', 'notifications', 'printers', 'usb')
BUNDLED_PLUGINS = ('computers', 'equipment', 'knowledgebase', 'network', 'notifications', 'printers', 'slides', 'usb')
@pytest.fixture

View File

@@ -99,6 +99,7 @@ def test_plugin_loader_discovers_bundled_plugins(app):
'network',
'notifications',
'printers',
'slides',
'usb',
}