Multi-site distribution readiness: settings-driven site config, security closeout, release engineering, v0.5.0

Make the app distributable to other GE Aerospace sites (one self-hosted
instance per site, ADR-004). GE values remain the shipped defaults; every
site-specific behavior is now a Setting an admin can change in the UI.

Settings-driven site config:
- Branding: site/QR/badge logos, favicon, primary color (upload endpoints
  mirror the map-blueprint pattern; new Settings > Branding section).
- ServiceNow: search/incident/change URL templates ({ticket}), ticket
  prefixes, enable toggle. Defaults point at the current
  geaerospaceqa.service-now.com global search. Disabled = plain-text tickets.
- Employee-id regex (employeeid_pattern), printer hostname template,
  QR label targets (qr_target_printer / qr_target_usb, blank = asset page,
  else URL template with placeholders), usb_label_style (barcode|qr).
- West Jefferson floor-plan PNGs removed from the tree; generic placeholder
  ships as the map default and sites upload their own blueprint.

Security closeout:
- dashboarddefaults writes now require admin.
- Collector: generic error messages (no str(exc) leak); API key accepted
  via X-API-Key header only (BREAKING: querystring api_key removed).
- IP-based login rate limiting (AUTH_RATELIMIT_* knobs) atop account lockout.
- Setting.set() creation race fixed (IntegrityError retry).

Release engineering and docs:
- __version__ 0.5.0 (distinct from __contract_version__, ADR-007),
  CHANGELOG.md, Gitea Actions CI config, frontend version aligned.
- One wizard-first install story across README/DEPLOY; new CONFIG.md,
  UPGRADE.md, BACKUP-RESTORE.md; CLAUDE.md and ROADMAP de-staled.
- Dockerfile multi-stage build now bundles the frontend; compose binds
  MySQL to 127.0.0.1; stale database/schema.sql and one-off SQL removed.

Debt and fixes:
- .query.get() -> db.session.get() sweep; datetime.utcnow() removed
  (naive-UTC via timezone-aware now); users.py on authz decorators.
- Fixed 4 stale tests (slides feed shape, shopfloor splitperemployee,
  plugin contract purity) and the USB label page field mapping (both usb
  modes emit the cmmc shape: device_id/device_desc).
- Health endpoint reports the real version.

248 tests pass; naming/style check green; frontend builds; fresh-DB
flask db upgrade + seeds verified; QR targets verified by decoding
rendered codes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

shopdb/core/api/users.py

@@ -7,17 +7,16 @@ from werkzeug.security import generate_password_hash
 from shopdb.extensions import db
 from shopdb.core.models import User, Role, Permission, AuditLog
 from shopdb.utils.responses import success_response, error_response, ErrorCodes
+from shopdb.utils.authz import require_role
 
 users_bp = Blueprint('users', __name__)
 
 
 @users_bp.route('', methods=['GET'])
 @jwt_required()
+@require_role('admin')
 def list_users():
     """List all users."""
-    if not current_user.hasrole('admin'):
-        return error_response(ErrorCodes.FORBIDDEN, 'Admin access required', http_code=403)
-
     users = User.query.order_by(User.username).all()
     return success_response([user_to_dict(u) for u in users])
 
@@ -26,10 +25,11 @@ def list_users():
 @jwt_required()
 def get_user(userid: int):
     """Get a single user."""
+    # inline: decorators cannot express admin-or-self
     if not current_user.hasrole('admin') and current_user.userid != userid:
         return error_response(ErrorCodes.FORBIDDEN, 'Access denied', http_code=403)
 
-    user = User.query.get(userid)
+    user = db.session.get(User, userid)
     if not user:
         return error_response(ErrorCodes.NOT_FOUND, 'User not found', http_code=404)
 
@@ -38,11 +38,9 @@ def get_user(userid: int):
 
 @users_bp.route('', methods=['POST'])
 @jwt_required()
+@require_role('admin')
 def create_user():
     """Create a new user."""
-    if not current_user.hasrole('admin'):
-        return error_response(ErrorCodes.FORBIDDEN, 'Admin access required', http_code=403)
-
     data = request.get_json()
     if not data:
         return error_response(ErrorCodes.VALIDATION_ERROR, 'Request body required')
@@ -90,10 +88,11 @@ def create_user():
 @jwt_required()
 def update_user(userid: int):
     """Update a user."""
+    # inline: decorators cannot express admin-or-self
     if not current_user.hasrole('admin') and current_user.userid != userid:
         return error_response(ErrorCodes.FORBIDDEN, 'Access denied', http_code=403)
 
-    user = User.query.get(userid)
+    user = db.session.get(User, userid)
     if not user:
         return error_response(ErrorCodes.NOT_FOUND, 'User not found', http_code=404)
 
@@ -120,7 +119,7 @@ def update_user(userid: int):
             changes['lastname'] = {'old': user.lastname, 'new': data['lastname']}
         user.lastname = data['lastname']
 
-    # Admin-only fields
+    # Admin-only fields (inline: gates a subset of fields on a shared route)
     if current_user.hasrole('admin'):
         if 'isactive' in data:
             if data['isactive'] != user.isactive:
@@ -156,15 +155,13 @@ def update_user(userid: int):
 
 @users_bp.route('/<int:userid>', methods=['DELETE'])
 @jwt_required()
+@require_role('admin')
 def delete_user(userid: int):
     """Delete a user."""
-    if not current_user.hasrole('admin'):
-        return error_response(ErrorCodes.FORBIDDEN, 'Admin access required', http_code=403)
-
     if current_user.userid == userid:
         return error_response(ErrorCodes.VALIDATION_ERROR, 'Cannot delete your own account')
 
-    user = User.query.get(userid)
+    user = db.session.get(User, userid)
     if not user:
         return error_response(ErrorCodes.NOT_FOUND, 'User not found', http_code=404)
 
@@ -225,11 +222,9 @@ def list_roles():
 
 @users_bp.route('/roles', methods=['POST'])
 @jwt_required()
+@require_role('admin')
 def create_role():
     """Create a new role."""
-    if not current_user.hasrole('admin'):
-        return error_response(ErrorCodes.FORBIDDEN, 'Admin access required', http_code=403)
-
     data = request.get_json()
     if not data or not data.get('rolename'):
         return error_response(ErrorCodes.VALIDATION_ERROR, 'Role name is required')
@@ -263,12 +258,10 @@ def create_role():
 
 @users_bp.route('/roles/<int:roleid>', methods=['PUT'])
 @jwt_required()
+@require_role('admin')
 def update_role(roleid: int):
     """Update a role."""
-    if not current_user.hasrole('admin'):
-        return error_response(ErrorCodes.FORBIDDEN, 'Admin access required', http_code=403)
-
-    role = Role.query.get(roleid)
+    role = db.session.get(Role, roleid)
     if not role:
         return error_response(ErrorCodes.NOT_FOUND, 'Role not found', http_code=404)
 
@@ -308,12 +301,10 @@ def update_role(roleid: int):
 
 @users_bp.route('/roles/<int:roleid>', methods=['DELETE'])
 @jwt_required()
+@require_role('admin')
 def delete_role(roleid: int):
     """Delete a role."""
-    if not current_user.hasrole('admin'):
-        return error_response(ErrorCodes.FORBIDDEN, 'Admin access required', http_code=403)
-
-    role = Role.query.get(roleid)
+    role = db.session.get(Role, roleid)
     if not role:
         return error_response(ErrorCodes.NOT_FOUND, 'Role not found', http_code=404)