Search results open the record they found; plugin scaffolder emits a prunable frontend

shopdb/plugins/scaffolder.py

@@ -81,18 +81,28 @@ def _scaffold_frontend(
     name: str,
     substitutions: dict,
     plugin_target: Path,
-    frontend_dir: Path,
     template_root: Path,
     overwrite: bool,
 ) -> None:
     """Render the frontend starting points for a scaffolded plugin.
 
-    Writes the paste-in api-client snippet into the plugin directory, then the
-    Vue views and the router route file into the real frontend tree. The
-    snippet is emitted regardless of whether the frontend tree exists, because
-    it is a plugin-directory artifact useful even for external-repo plugins.
-    Views and the route file are skipped when frontend_dir is missing, which is
-    the normal case for a plugin developed in its own repository.
+    Everything lands INSIDE the plugin, under `plugins/<name>/frontend/`:
+    `routes.js` plus `views/<Name>{List,Detail,Form}.vue`, and the paste-in
+    api-client snippet at the plugin root.
+
+    The plugin owns its frontend because that is what makes it prunable.
+    scripts/stage-frontend.mjs copies each plugin's `frontend/` into
+    `frontend/src/.plugins-staged/<name>/` and aggregates the route modules
+    into `routes.gen.js`; a plugin left out of SITE_PLUGINS is simply not
+    copied, so its frontend leaves the build with it (ADR-013). A route file
+    written into the CORE tree instead is still picked up - the router globs
+    `./routes/*.js` during the Phase 4 dual-location transition - but it is
+    invisible to that pruning, and deleting the plugin strands its views.
+
+    This is also why nothing here depends on the core frontend tree existing.
+    A plugin developed in its own repo gets exactly the same layout, and its
+    frontend starts working the moment the plugin directory is dropped into
+    `plugins/`.
 
     Ordering matters: every view is written before the route file. A route file
     that lazy-imports a view that is not on disk crashes the Vite dev server,
@@ -104,7 +114,7 @@ def _scaffold_frontend(
 
     plugin_name = substitutions['Name']
 
-    # snippet lands in the plugin dir; author pastes it into api/index.js
+    # snippet lands at the plugin root; author pastes it into api/index.js
     snippet_template = fe_templates / 'frontend-api-snippet.js.tmpl'
     if snippet_template.exists():
         _render_template(
@@ -114,11 +124,8 @@ def _scaffold_frontend(
             overwrite,
         )
 
-    # views and route need the real frontend tree; external repos skip these
-    if not frontend_dir.exists():
-        return
-
-    views_dir = frontend_dir / 'views' / name
+    frontend_dir = plugin_target / 'frontend'
+    views_dir = frontend_dir / 'views'
 
     # views first: route file lazy-imports them, missing views 500 vite
     view_templates = {
@@ -141,7 +148,7 @@ def _scaffold_frontend(
     if route_template.exists():
         _render_template(
             route_template,
-            frontend_dir / 'router' / 'routes' / f'{name}.js',
+            frontend_dir / 'routes.js',
             substitutions,
             overwrite,
         )
@@ -154,7 +161,6 @@ def scaffold_plugin(
     template_root: Optional[Path] = None,
     overwrite: bool = False,
     frontend: bool = True,
-    frontend_dir: Optional[Path] = None,
 ) -> Path:
     """Generate a new plugin from templates.
 
@@ -166,11 +172,10 @@ def scaffold_plugin(
         overwrite: If True, overwrite an existing plugin directory and any
             existing generated frontend files
         frontend: If True, also render the Vue frontend starting points (list,
-            detail, form views, a route file, and a paste-in api-client snippet)
-        frontend_dir: Frontend src directory to render views/routes into
-            (default: <plugins_dir>/../frontend/src). Views and the route file
-            are skipped when this directory does not exist, which is the normal
-            case for a plugin developed in its own repository.
+            detail, form views, a route file, and a paste-in api-client
+            snippet) into `plugins/<name>/frontend/`. There is no separate
+            output directory: the plugin owns its frontend so that
+            stage-frontend.mjs can stage it and a lean build can prune it.
 
     Returns:
         Path to the generated plugin directory.
@@ -205,7 +210,9 @@ def scaffold_plugin(
     for template_path in template_root.rglob('*.tmpl'):
         rel = template_path.relative_to(template_root)
 
-        # frontend templates render into the frontend tree, not the plugin dir
+        # frontend templates are handled by _scaffold_frontend: they are
+        # renamed on the way out (List.vue.tmpl -> <Name>List.vue) and are
+        # skipped entirely when frontend=False
         if rel.parts and rel.parts[0] == 'frontend':
             continue
 
@@ -222,13 +229,10 @@ def scaffold_plugin(
         out_path.write_text(rendered)
 
     if frontend:
-        if frontend_dir is None:
-            frontend_dir = plugins_dir.parent / 'frontend' / 'src'
         _scaffold_frontend(
             name=name,
             substitutions=substitutions,
             plugin_target=target,
-            frontend_dir=Path(frontend_dir),
             template_root=template_root,
             overwrite=overwrite,
         )