Remediate the 2026-09-03 feature-test findings

plugins/warranty/api/routes.py

@@ -19,6 +19,7 @@ from shopdb.api import (
     db, Asset,
     success_response, error_response, ErrorCodes,
     require_permission,
+    DateValueError, parse_date, parse_date_fields,
 )
 
 from ..models import Warranty, WarrantyAsset
@@ -42,13 +43,16 @@ def _proof_dir():
     return os.path.join(current_app.instance_path, 'warrantyproofs')
 
 
-def _parse_date(value):
-    """Accept 'YYYY-MM-DD' (or None/empty) -> date or None."""
-    if not value:
-        return None
+def _vendor_date(value):
+    """A date off a VENDOR response, which this code does not control.
+
+    Kept lenient on purpose, unlike a date a person typed: a provider that
+    starts returning a shape we do not parse must not fail the refresh of an
+    otherwise good record. The field is simply left as it was.
+    """
     try:
-        return datetime.strptime(value[:10], '%Y-%m-%d').date()
-    except (ValueError, TypeError):
+        return parse_date(value)
+    except DateValueError:
         return None
 
 
@@ -203,13 +207,20 @@ def create_warranty():
     vendor = (data.get('vendor') or '').strip()
     if not vendor:
         return error_response(ErrorCodes.VALIDATION_ERROR, 'vendor is required')
+    # Refused, not nulled. A mistyped end date used to store NULL and answer
+    # 200, which dropped the warranty out of every expiry surface on the
+    # strength of a typo.
+    try:
+        dates = parse_date_fields(data, ('startdate', 'enddate'))
+    except DateValueError as bad:
+        return error_response(ErrorCodes.VALIDATION_ERROR, str(bad))
     warranty = Warranty(
         vendor=vendor,
         servicetag=(data.get('servicetag') or '').strip() or None,
         provider=(data.get('provider') or 'manual').strip().lower(),
         servicelevel=(data.get('servicelevel') or '').strip() or None,
-        startdate=_parse_date(data.get('startdate')),
-        enddate=_parse_date(data.get('enddate')),
+        startdate=dates.get('startdate'),
+        enddate=dates.get('enddate'),
         notes=(data.get('notes') or '').strip() or None,
     )
     _apply_links(warranty, data.get('assetids'))
@@ -225,6 +236,10 @@ def update_warranty(warrantyid):
     if not warranty:
         return error_response(ErrorCodes.NOT_FOUND, 'Warranty not found', http_code=404)
     data = request.get_json() or {}
+    try:
+        dates = parse_date_fields(data, ('startdate', 'enddate'))
+    except DateValueError as bad:
+        return error_response(ErrorCodes.VALIDATION_ERROR, str(bad))
     if 'vendor' in data:
         warranty.vendor = (data['vendor'] or '').strip() or warranty.vendor
     if 'servicetag' in data:
@@ -233,10 +248,8 @@ def update_warranty(warrantyid):
         warranty.provider = (data['provider'] or 'manual').strip().lower()
     if 'servicelevel' in data:
         warranty.servicelevel = (data['servicelevel'] or '').strip() or None
-    if 'startdate' in data:
-        warranty.startdate = _parse_date(data['startdate'])
-    if 'enddate' in data:
-        warranty.enddate = _parse_date(data['enddate'])
+    for field, parsed in dates.items():
+        setattr(warranty, field, parsed)
     if 'notes' in data:
         warranty.notes = (data['notes'] or '').strip() or None
     if 'isactive' in data:
@@ -279,9 +292,9 @@ def refresh_warranty(warrantyid):
     if result.get('servicelevel'):
         warranty.servicelevel = result['servicelevel']
     if result.get('startdate'):
-        warranty.startdate = _parse_date(result['startdate'])
+        warranty.startdate = _vendor_date(result['startdate'])
     if result.get('enddate'):
-        warranty.enddate = _parse_date(result['enddate'])
+        warranty.enddate = _vendor_date(result['enddate'])
     warranty.lastcheckeddate = datetime.now(timezone.utc).replace(tzinfo=None)
     db.session.commit()
     return success_response(_warranty_payload(warranty), message='Warranty refreshed')
@@ -363,8 +376,8 @@ def sync_dell():
                 existing.provider = 'dell'
                 existing.vendor = existing.vendor or 'Dell'
                 existing.servicelevel = found.get('servicelevel')
-                existing.startdate = _parse_date(found.get('startdate'))
-                existing.enddate = _parse_date(found.get('enddate'))
+                existing.startdate = _vendor_date(found.get('startdate'))
+                existing.enddate = _vendor_date(found.get('enddate'))
                 existing.servicetag = tag
                 existing.lastcheckeddate = now
                 updated += 1
@@ -372,8 +385,8 @@ def sync_dell():
                 warranty = Warranty(
                     vendor='Dell', provider='dell', servicetag=tag,
                     servicelevel=found.get('servicelevel'),
-                    startdate=_parse_date(found.get('startdate')),
-                    enddate=_parse_date(found.get('enddate')),
+                    startdate=_vendor_date(found.get('startdate')),
+                    enddate=_vendor_date(found.get('enddate')),
                     lastcheckeddate=now,
                 )
                 warranty.links.append(WarrantyAsset(assetid=assetid))