CI: drop rsync dep in build-site.sh; move MySQL migration job to internal CI (ARC has no service containers)

.github/workflows/ci.yml

@@ -97,72 +97,10 @@ jobs:
           test ! -d /tmp/leansite/plugins/printedparts
           echo "lean build verified: only chosen plugins present"
 
-  migrations-mysql:
-    runs-on: arc-runner-set
-    services:
-      mysql:
-        image: mysql:8.0
-        env:
-          MYSQL_ROOT_PASSWORD: root
-          MYSQL_DATABASE: shopdb_ci
-        ports:
-          - 3306:3306
-        options: >-
-          --health-cmd="mysqladmin ping -h localhost -uroot -proot"
-          --health-interval=5s --health-timeout=5s --health-retries=20
-    env:
-      FLASK_APP: shopdb
-      DATABASE_URL: mysql+pymysql://root:root@127.0.0.1:3306/shopdb_ci?charset=utf8mb4
-      SECRET_KEY: ci-secret
-      JWT_SECRET_KEY: ci-jwt-secret
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
-        with:
-          python-version: '3.13'
-          cache: pip
-      - run: pip install -r requirements.txt
-      - name: Force utf8mb4 on the CI database
-        # pymysql speaks MySQL 8's caching_sha2_password via the cryptography
-        # package (a requirements.txt dependency), so no auth-plugin change
-        # is needed here.
-        run: |
-          mysql -h 127.0.0.1 -uroot -proot -e \
-            "ALTER DATABASE shopdb_ci CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci;"
-      - name: Fresh core upgrade from empty
-        run: flask db upgrade
-      - name: Install every bundled plugin (runs its chain)
-        run: |
-          for p in computers employees geenforce knowledgebase machines \
-                   measuringtools network notifications printedparts printers \
-                   slides usb warranty; do
-            flask plugin install "$p"
-          done
-          flask plugin upgrade-all
-      - name: Seed platform data (catches strict-mode data violations)
-        # Runs the real seeders on strict MySQL 8. A seeded row that exceeds a
-        # column width is a hard error 1406 here (not the silent truncation
-        # older/relaxed MySQL gives), so this is what catches over-length
-        # setting descriptions and similar before they reach a fresh box.
-        run: |
-          flask seed permissions
-          flask seed settings
-          flask seed reference-data
-      - name: Assert schema built + utf8mb4
-        run: |
-          python - <<'PY'
-          from shopdb import create_app
-          from shopdb.extensions import db
-          from sqlalchemy import text
-          app = create_app()
-          with app.app_context():
-              tables = db.inspect(db.engine).get_table_names()
-              assert len(tables) >= 70, f'only {len(tables)} tables built'
-              row = db.session.execute(text(
-                  "SELECT default_character_set_name FROM information_schema.schemata "
-                  "WHERE schema_name = 'shopdb_ci'")).first()
-              assert row[0] == 'utf8mb4', f'charset is {row[0]}, not utf8mb4'
-              print(f'OK: {len(tables)} tables, charset {row[0]}')
-          PY
-      - name: Second core upgrade must be a clean no-op
-        run: flask db upgrade
+  # NOTE: the MySQL-8 migration/seed job (fresh `flask db upgrade` + every
+  # plugin chain + strict-mode seeders on a real MySQL 8) runs on the internal
+  # CI server, which supports service containers. The org's arc-runner-set is
+  # Kubernetes/ARC without docker-in-docker, so GitHub Actions service
+  # containers ("services: mysql") are unavailable here ("Job Container is
+  # required"). That coverage stays on the internal CI rather than being
+  # duplicated on GitHub.