2 Commits

Author	SHA1	Message	Date
cproudlock	83190422c9	Act on the review of the wilm import ... Six findings from a four-agent review of the imported work, plus the contract bump the import owed. Nothing here changes what the imported features do. The contract version was not bumped for a change that widens what a plugin may declare. The asset-panel vocabulary gained two tab groups (serviceprocess, reports), a datetime column format, a map.body key and a tabs section that renders as a table. 0.29.0 bumped for exactly this class of change when the optional group was added, so this is 0.31.0 with a ledger row. All four are optional and resolve server-side when absent, so a plugin declaring none of them is unaffected. Site Backups now answers honestly where it has nothing behind it. The overlay is a compose profile: a separate container writes sets onto a shared volume and the api container only reads them. A Windows/IIS install runs no such container and the default root resolves to a drive-letter path nothing creates, so Back Up Now either failed on PermissionError or reported a run queued that would never happen, under a banner reading "No verified backup yet" - which describes a backup that failed, not a feature that was never installed. The three write routes refuse with the same 404 shape the configuration-policy routes use for a disabled feature, the list and status routes report whether a store exists, and the page says so instead of offering buttons. Two listAll callers still read a response that is not there. listAll resolves to a plain array through fetchAllPages, so response.data.data throws: PC Types settings rendered empty, and in Configuration Policies the throw happened inside the shared try, so PC types, applications, the action catalog and monitors were all left unassigned by one bad read. The agent package upload cannot succeed on IIS as shipped. MAX_CONTENT_LENGTH went to 256 MB to admit the ~69 MB tray binary, but IIS request filtering caps a body at 30,000,000 bytes and answers 413 before waitress sees the request, so web.config needs the matching requestLimits. The backup image could not be built by anyone outside a TLS-intercepting network. Dockerfile.backup did a plain COPY of a gitignored corporate root CA, and a COPY of a missing file fails the build. The trailing glob makes it a no-op when the cert is absent. endpointstates.domain was the one new string column written without a clamp. Under STRICT_TRANS_TABLES an over-long value raises Data too long and aborts the whole check-in, so a single malformed report would stop a machine reporting telemetry and events entirely. Not fixed here, and left with upstream: the restore path finalizes its schema upgrade only from a browser poll loop, so closing the tab mid-restore leaves the data behind the code; it restores instance files from the newest snapshot rather than the set that was asked for; and it takes no safety dump before the destructive load. All three are in the Docker-only overlay, which this site does not run, and none can be validated here. Scope: product	2026-09-06 16:47:47 -04:00
cproudlock	6e36df841e	Import the wilm endpoint telemetry, PC Detail rework and backup overlay ... Ports 37 of Benjamin Baker's commits from the wilm branch, mirrored from the corporate GitHub at 7905917c. wilm rides the publication lineage and shares no ancestor with wj, so this is a filtered tree patch rather than a merge: 94 files, and every path the publication export strips (docs/, tools/, mcp/, CLAUDE.md, start-*.sh, .gitea/, the three excluded tests) is held back, because a raw diff would delete each of them from this tree. What comes across: * Endpoint telemetry, phase 2. Physical disk health from two sources, NIC link state, boot type, Defender health, processor/memory/chassis inventory, the listening TCP set, mapped network drives and Windows Update history. Five additive migrations, 0012 through 0016, off the 0011 head. * Mapped drives are collected by a probe running in the interactive user's session, because they do not exist in the agent's session 0. Two Windows sources can disagree about one drive and the worse status wins, so a half-broken share is never rendered as healthy. * Windows events are reported once each, keyed on the channel's own record id, instead of being re-sent whenever a report overlapped the last one. * PC Detail rework: Details cards flow, the hand-written Network card gives way to a full address history, Storage and disk health merge into one card with two sections, Operator Reports and Corporate Tools get their own tabs. * An opt-in restic backup overlay with a third container, restore gated on the dump's own data revision rather than the code head, and backup/restore history. * The agent's version is read from the binary's PE version rather than trusted from the csproj, and the Fleet view gains an Agent Version column. * The enqueue route now asks caller_holds instead of the owner's permissions, which closes the scoped-token elevation on run_script, update_app and system_restart. Held back deliberately: * agent/installer/install-shopdbagent.ps1 stays deleted, as upstream deleted it. The installer that reaches a bay is generated by _install_script() in plugins/endpoints/api/siteagent.py; the standalone script had stopped being shipped and was collecting fixes no endpoint ever ran. * The .gitignore hunk adding docs/*.md. Correct on the publication lineage, where docs/ becomes the wiki and its absence is how the gates detect a published checkout. Here it would silently ignore every new doc. * Their deletions of docs/DEV-BUILD-TEST.md and docs/PLUGIN-HOOKS.md. Upstream those were stubs; here PLUGIN-HOOKS.md is the 31KB document CLAUDE.md points readers at. * Five zero-byte files committed by an accidental `git add -A`, a run log from the author's own machine, and docs/notes/, which is working scratch that says so in its own header and belongs in devnotes/ on this side. Carried with the import so it lands green: the 17 new routes are described in docs/api-inventory.json with the spec and project map regenerated, and two new frontend specs read fixtures through fileURLToPath(URL) which node rejects under jsdom's own URL global. Suite 2591 passed / 9 skipped; frontend 391 passed; naming, style and doc gates clean. Scope: product	2026-09-06 16:47:24 -04:00