2 Commits

Author	SHA1	Message	Date
cproudlock	9b7da9f2d2	Make a plugin toggle take effect without a manual restart ... Enabling a plugin could not make its routes live. Flask refuses register_blueprint once the app has served a request, and each gunicorn worker holds its own app object, so registering in the worker that served the toggle would leave the others answering 404 for the same URL. Worse, the window before the restart was a window in which workers disagreed about reality. Four defects, all of which answered 200 while going wrong: - Enabling a not-yet-installed plugin ALWAYS 500'd on a running app: install_plugin ran the migrations, updated the registry, and only then called register_blueprint and hit Flask's assertion. The toggle half-applied and reported failure. - Enabling one plugin could hang the entire site. @jwt_required does SELECT users, so the request's transaction sits open holding a shared metadata lock; the plugin's migration runs on its own Alembic connection and needs an EXCLUSIVE lock on users for a foreign key. Each waits on the other, and MySQL grants metadata locks in request order, so every later login queued behind the pending exclusive. Observed twice as a total outage from one plugin toggle. - Each worker rewrote the WHOLE registry file from a snapshot taken at boot, so concurrent enables erased each other: seven enables persisted three, with HTTP 200 for all seven. - Dependency checks read that same stale snapshot, refusing a plugin whose dependency another worker had just enabled. Routes still require the process to restart; what changes is who initiates it. Each worker fingerprints instance/plugins.json at boot and exits gracefully when it changes, and the supervisor replaces it. That is the primitive gunicorn's own --reload uses. Recycles are staggered per worker so the pool rolls rather than dropping at once, and the exit is scoped to gunicorn: on Windows sys.exit() in a daemon thread ends the thread rather than the process, so IIS keeps the manual restart until that path is proven on the Windows VM. The registry now merges under an exclusive lock and replaces atomically, saves only the entry being changed, and re-reads before any decision is made from it. ADR-020 records the decision; ADR-013 is amended where it said the UI must tell the operator to restart. The restart requirement and the honesty requirement both stand - only the manual step is removed, and only where it is proven. (cherry picked from commit 9d6342b3ab)	2026-09-20 09:07:54 -04:00
cproudlock	f9d6b57f0f	Move the documentation to the line that ships, and correct it against the code ... The docs lived on one lineage and the fleet code on another. That is why six pages described a shared fleet key as how an agent authenticates, why COLLECTOR-AUTH had to warn that the per-PC credential code was not in the repository it sat in, and why ADR-019 recorded a decision whose implementation was somewhere else. Documentation that cannot see the code it documents goes stale by construction, and no amount of editing fixes that. So the corpus moves here: 84 files, 56 pages, 20 ADRs, the proposals, INDEX.md, llms.txt and both gates. Filenames are unchanged, because a wiki page name is derived from the filename and a rename breaks every link anybody saved. THE POINT OF THE MOVE IS THE CORRECTION IT ENABLES. Every caveat that said "not in this tree" was false the moment the files landed beside the code, so each was rewritten from what is actually here: - COLLECTOR-AUTH gained the real enroll request body, the two bounds on the unauthenticated route (per-IP rate limit, pending cap with stale rows dropped before a real PC is refused), and the rejected pending reason that binds to the endpoint identity rather than the nonce. - ADR-019 now describes an implementation that is present, including its tests, and says plainly that what remains is the FLEET migration, not the code. - proposals/device-identity claimed phase 1 was unbuilt. plugins/computers declares deviceid on the collector schema and prefers it over the older fallbacks. Corrected in the page, its summary and the index. WINDOWS/IIS IS NOW DOCUMENTED AS THE LEGACY PATH, per the product decision, and carefully: it is what production runs today. Every Windows page opens by saying it is supported, not for a new site, and where a new site should go instead. No procedure was cut - an operator on an IIS box at 2am needs these pages to work exactly as well tomorrow. MIGRATE-TOPOLOGY stops being a footnote and becomes the off-ramp, which is why it nearly doubled: what was there did not match how the Docker stack really works here. The Docker material that already lived on this line was kept and given ownership rather than buried under the ported Windows-centric prose: DEPLOY now describes the four services, the migrate service that runs the upgrade chain before api starts, TLS terminated by nginx, and the plugin count corrected from thirteen to seventeen - a number both lineages had wrong. ROADMAP is rewritten from evidence rather than memory: what has shipped, read out of the changelog, the ADRs and the manifests, and ahead of it exactly two items - finalize a distributed release and polish the setup wizard. PROJECT-MAP is generated and was stale; the GENERATOR was what was wrong. --check passes now. API-REFERENCE is retired to a pointer. /api/docs serves 573 operations with derived auth, query parameters and harvested examples, and a hand-written page competing with that is a liability. The file stays so its wiki page and its inbound links survive. AND THE MOVE TURNED ON A SCRUB THAT HAD NEVER RUN HERE. test_docs_publishable keys on docs/*.md, which this line did not have, so it skipped - its own comment predicted what would surface. Porting the corpus activated it and it found 48 lines that must not reach a published wiki: branch names abbreviating the site, assistant-tooling paths, the site name in two deployment pages, and an employee ID in a Windows path that the scrub does not even look for.	2026-09-19 09:10:15 -04:00