6e36df841e
Ports 37 of Benjamin Baker's commits from the wilm branch, mirrored from the
corporate GitHub at 7905917c. wilm rides the publication lineage and shares no
ancestor with wj, so this is a filtered tree patch rather than a merge:
94 files, and every path the publication export strips (docs/, tools/, mcp/,
CLAUDE.md, start-*.sh, .gitea/, the three excluded tests) is held back, because
a raw diff would delete each of them from this tree.
What comes across:
* Endpoint telemetry, phase 2. Physical disk health from two sources, NIC link
state, boot type, Defender health, processor/memory/chassis inventory, the
listening TCP set, mapped network drives and Windows Update history. Five
additive migrations, 0012 through 0016, off the 0011 head.
* Mapped drives are collected by a probe running in the interactive user's
session, because they do not exist in the agent's session 0. Two Windows
sources can disagree about one drive and the worse status wins, so a
half-broken share is never rendered as healthy.
* Windows events are reported once each, keyed on the channel's own record id,
instead of being re-sent whenever a report overlapped the last one.
* PC Detail rework: Details cards flow, the hand-written Network card gives way
to a full address history, Storage and disk health merge into one card with
two sections, Operator Reports and Corporate Tools get their own tabs.
* An opt-in restic backup overlay with a third container, restore gated on the
dump's own data revision rather than the code head, and backup/restore history.
* The agent's version is read from the binary's PE version rather than trusted
from the csproj, and the Fleet view gains an Agent Version column.
* The enqueue route now asks caller_holds instead of the owner's permissions,
which closes the scoped-token elevation on run_script, update_app and
system_restart.
Held back deliberately:
* agent/installer/install-shopdbagent.ps1 stays deleted, as upstream deleted it.
The installer that reaches a bay is generated by _install_script() in
plugins/endpoints/api/siteagent.py; the standalone script had stopped being
shipped and was collecting fixes no endpoint ever ran.
* The .gitignore hunk adding docs/*.md. Correct on the publication lineage,
where docs/ becomes the wiki and its absence is how the gates detect a
published checkout. Here it would silently ignore every new doc.
* Their deletions of docs/DEV-BUILD-TEST.md and docs/PLUGIN-HOOKS.md. Upstream
those were stubs; here PLUGIN-HOOKS.md is the 31KB document CLAUDE.md points
readers at.
* Five zero-byte files committed by an accidental `git add -A`, a run log from
the author's own machine, and docs/notes/, which is working scratch that says
so in its own header and belongs in devnotes/ on this side.
Carried with the import so it lands green: the 17 new routes are described in
docs/api-inventory.json with the spec and project map regenerated, and two new
frontend specs read fixtures through fileURLToPath(URL) which node rejects under
jsdom's own URL global.
Suite 2591 passed / 9 skipped; frontend 391 passed; naming, style and doc gates
clean.
Scope: product
75 lines
2.9 KiB
Python
75 lines
2.9 KiB
Python
"""The Monitors tab split: a panel in a group no tab renders disappears.
|
|
|
|
This has silently eaten cards twice - once when tracked services moved out of
|
|
'actions', once on the 'metrics' to 'monitors' rename. Both times the backend
|
|
named a group the frontend did not render, and the panel was not shown, not
|
|
logged, and not missed until someone went looking for it.
|
|
|
|
The split is only correct if four places agree, and only two of them are Python:
|
|
1. the panels' group here
|
|
2. RENDERED_GROUPS in PluginAssetPanels.vue
|
|
3. the tab label map in PCDetail.vue
|
|
4. the v-show block that gives the tab a layout
|
|
|
|
These tests pin the Python half so a later edit cannot quietly move a panel into
|
|
a group nothing renders. The frontend half is pinned by its own spec.
|
|
"""
|
|
|
|
from plugins.endpoints.plugin import EndpointsPlugin
|
|
from shopdb.core.api.pluginui import ASSET_PANEL_GROUPS
|
|
|
|
|
|
# Derived from the server tuple rather than hand-copied. This used to be a
|
|
# literal set duplicating RENDERED_GROUPS, which made it a FIFTH copy of the
|
|
# vocabulary and one more thing to forget: it passed for a group the server
|
|
# would rewrite to 'details' anyway. ASSET_PANEL_GROUPS is the value that
|
|
# actually decides what reaches the client, and panelGroups.spec.js pins it
|
|
# against the frontend copy.
|
|
RENDERED_GROUPS = set(ASSET_PANEL_GROUPS)
|
|
|
|
|
|
def _panels():
|
|
return {panel['id']: panel for panel in EndpointsPlugin().get_asset_panels()}
|
|
|
|
|
|
def test_no_panel_lands_in_a_group_the_frontend_does_not_render():
|
|
"""The failure mode that ate cards twice: a group with no tab."""
|
|
for panel in EndpointsPlugin().get_asset_panels():
|
|
group = panel.get('group', 'details')
|
|
assert group in RENDERED_GROUPS, (
|
|
f"panel {panel['id']} is in group {group!r}, which no tab renders"
|
|
)
|
|
|
|
|
|
def test_tracked_services_and_processes_moved_to_their_own_group():
|
|
panels = _panels()
|
|
|
|
assert panels['endpoints-tracked-services']['group'] == 'serviceprocess'
|
|
assert panels['endpoints-tracked-processes']['group'] == 'serviceprocess'
|
|
|
|
|
|
def test_the_service_process_tab_is_not_left_empty():
|
|
"""A tab whose panels all moved away reads as broken, not as absent."""
|
|
groups = [panel.get('group', 'details')
|
|
for panel in EndpointsPlugin().get_asset_panels()]
|
|
|
|
assert 'serviceprocess' in groups
|
|
|
|
|
|
def test_system_monitors_keeps_panels_of_its_own():
|
|
"""The rename is only safe if Monitors still has content after the move."""
|
|
groups = [panel.get('group', 'details')
|
|
for panel in EndpointsPlugin().get_asset_panels()]
|
|
|
|
assert 'monitors' in groups
|
|
|
|
|
|
def test_disk_health_stayed_with_the_system_health_panels():
|
|
"""Disk health is the box's own health, not something running on it.
|
|
|
|
It is now a section of the Storage card rather than a panel of its own,
|
|
so the group assertion follows it there.
|
|
"""
|
|
assert 'endpoints-diskhealth' not in _panels()
|
|
assert _panels()['endpoints-storage']['group'] == 'monitors'
|