534f179ee6
main was 16 days and 259 commits behind the line the product is actually built on, at contract 0.30.0 against 0.35.0, with no per-PC credential code at all. It was neither current nor curated - just stale. This brings it forward and, at the same time, makes it mean something: main is what a receiving site installs, and nothing else. WHAT IT CARRIES. Twelve plugins - backups, computers, endpoints, guides, knowledgebase, machines, network, notifications, printers, slides, tools, warranty - plus applications, which is manifest-less core and always ships. The only manifest dependency inside that set is endpoints on computers, and both are in it, so the closure is self-contained. WHAT IT DOES NOT. employees, geenforce, measuringtools, printedparts and usb stay on the site line. So do the Windows installer tree, the VM rehearsal helpers, the agent tooling config, one site's data loader, the internal audit and findings records, and the planner spreadsheet. 1,135 tracked files against 1,438. A REMOVAL THAT BREAKS THE APP IS NOT A REMOVAL, and two nearly shipped: deploy/site-profile-universal.json still named all seventeen plugins. It is the file docs/DEPLOY.md tells a site to provision from, so a fresh install would have failed at `flask plugin apply-profile` with PluginError - the first thing a receiving site does, broken by the branch meant to serve them. It now names the twelve that exist, and its comment says the two must agree. agent/ was never refreshed. Whoever populated this branch copied shopdb/, plugins/, frontend/ and tests/ from the site line and left the agent tree at its September state: 22 C# and PowerShell sources missing, including AgentCredentials, EnrollmentService, AgentHttpFactory and the fleet-alert client, plus one file the site line had deleted still present. The old tree is internally consistent, so it compiles, and nothing in CI builds it - every gate was green over a server that speaks enrollment and per-PC credentials to a bundled agent source that cannot. Resynced whole. DECISIONS THIS ENCODES, rather than defers: - The plugin-authoring lab builds printedparts, whose manifest depends on employees, so it could not stay. The lab remains on the site line and main ships no build-along tutorial. That is a real loss for an adopting developer and is recorded here rather than discovered later. - Recognition, Training and Recertification notifications are no longer seeded. Each splits one notification into a card per employee and renders a photo, which needs a plugin this branch does not bundle. Seeding them would offer an author a type that cannot resolve anybody. A site that installs employees gets them from that plugin's own seed. - Windows/IIS is documented as the legacy path throughout, and the README leads with Docker, because that is what a receiving site gets. The API description is regenerated for THIS branch - 347 paths and 483 operations, down from 415 and 573 - so the published contract describes what is here rather than what the site line serves. docs/CONFIG.md lost the two measuring-tool label keys the code no longer declares, which two lanes had decided opposite ways. Suite: 3124 passed, 6 skipped. Naming and style gates pass. The docs gates run rather than skip, and every index line count is derived from the file it names.
53 lines
2.1 KiB
Python
53 lines
2.1 KiB
Python
"""Fixed-window per-IP rate limiting for the agent-facing routes.
|
|
|
|
One implementation, several budgets. The bootstrap installer routes and the
|
|
enrollment route are both unauthenticated by design - a PC with no agent has
|
|
neither a credential nor a user session - so the only thing standing between
|
|
them and a loop is a limiter. Each caller gets its own budget name so the two
|
|
surfaces cannot spend each other's allowance.
|
|
|
|
Same shape and same cache extension as the login limiter in
|
|
shopdb.core.api.auth. Under the default SimpleCache the counter is per-process,
|
|
so with N gunicorn workers the effective budget is N times the configured
|
|
maximum; that is defence in depth rather than a hard quota, and a shared cache
|
|
backend (Redis/memcached) tightens it to a true global budget.
|
|
"""
|
|
|
|
import time
|
|
|
|
from flask import current_app, request
|
|
|
|
from shopdb.api import cache, client_ip, error_response
|
|
|
|
|
|
def caller_ip():
|
|
return client_ip(request) or 'unknown'
|
|
|
|
|
|
def ratelimited(budget, configprefix, defaultmax, defaultwindow):
|
|
"""True when this caller is over budget for the current window.
|
|
|
|
budget cache key namespace, e.g. 'endpointenrollratelimit'
|
|
configprefix config key stem, e.g. 'ENDPOINTS_ENROLL_RATELIMIT'; reads
|
|
<prefix>_ENABLED, <prefix>_MAX and <prefix>_WINDOW_SECONDS
|
|
"""
|
|
if not current_app.config.get(configprefix + '_ENABLED', True):
|
|
return False
|
|
window = current_app.config.get(configprefix + '_WINDOW_SECONDS',
|
|
defaultwindow)
|
|
maxhits = current_app.config.get(configprefix + '_MAX', defaultmax)
|
|
# Time bucket makes this a fixed window: the key rolls over at each window
|
|
# boundary, so a per-hit set() cannot turn it into a sliding window.
|
|
bucket = int(time.time() // window) if window > 0 else 0
|
|
key = '{0}:{1}:{2}'.format(budget, caller_ip(), bucket)
|
|
count = cache.get(key) or 0
|
|
if count >= maxhits:
|
|
return True
|
|
cache.set(key, count + 1, timeout=window)
|
|
return False
|
|
|
|
|
|
def rate_limit_response(message):
|
|
"""The standard 429 shape every limiter in the product answers with."""
|
|
return error_response('RATE_LIMITED', message, http_code=429)
|