534f179ee6
main was 16 days and 259 commits behind the line the product is actually built on, at contract 0.30.0 against 0.35.0, with no per-PC credential code at all. It was neither current nor curated - just stale. This brings it forward and, at the same time, makes it mean something: main is what a receiving site installs, and nothing else. WHAT IT CARRIES. Twelve plugins - backups, computers, endpoints, guides, knowledgebase, machines, network, notifications, printers, slides, tools, warranty - plus applications, which is manifest-less core and always ships. The only manifest dependency inside that set is endpoints on computers, and both are in it, so the closure is self-contained. WHAT IT DOES NOT. employees, geenforce, measuringtools, printedparts and usb stay on the site line. So do the Windows installer tree, the VM rehearsal helpers, the agent tooling config, one site's data loader, the internal audit and findings records, and the planner spreadsheet. 1,135 tracked files against 1,438. A REMOVAL THAT BREAKS THE APP IS NOT A REMOVAL, and two nearly shipped: deploy/site-profile-universal.json still named all seventeen plugins. It is the file docs/DEPLOY.md tells a site to provision from, so a fresh install would have failed at `flask plugin apply-profile` with PluginError - the first thing a receiving site does, broken by the branch meant to serve them. It now names the twelve that exist, and its comment says the two must agree. agent/ was never refreshed. Whoever populated this branch copied shopdb/, plugins/, frontend/ and tests/ from the site line and left the agent tree at its September state: 22 C# and PowerShell sources missing, including AgentCredentials, EnrollmentService, AgentHttpFactory and the fleet-alert client, plus one file the site line had deleted still present. The old tree is internally consistent, so it compiles, and nothing in CI builds it - every gate was green over a server that speaks enrollment and per-PC credentials to a bundled agent source that cannot. Resynced whole. DECISIONS THIS ENCODES, rather than defers: - The plugin-authoring lab builds printedparts, whose manifest depends on employees, so it could not stay. The lab remains on the site line and main ships no build-along tutorial. That is a real loss for an adopting developer and is recorded here rather than discovered later. - Recognition, Training and Recertification notifications are no longer seeded. Each splits one notification into a card per employee and renders a photo, which needs a plugin this branch does not bundle. Seeding them would offer an author a type that cannot resolve anybody. A site that installs employees gets them from that plugin's own seed. - Windows/IIS is documented as the legacy path throughout, and the README leads with Docker, because that is what a receiving site gets. The API description is regenerated for THIS branch - 347 paths and 483 operations, down from 415 and 573 - so the published contract describes what is here rather than what the site line serves. docs/CONFIG.md lost the two measuring-tool label keys the code no longer declares, which two lanes had decided opposite ways. Suite: 3124 passed, 6 skipped. Naming and style gates pass. The docs gates run rather than skip, and every index line count is derived from the file it names.
75 lines
2.9 KiB
Python
75 lines
2.9 KiB
Python
"""The Monitors tab split: a panel in a group no tab renders disappears.
|
|
|
|
This has silently eaten cards twice - once when tracked services moved out of
|
|
'actions', once on the 'metrics' to 'monitors' rename. Both times the backend
|
|
named a group the frontend did not render, and the panel was not shown, not
|
|
logged, and not missed until someone went looking for it.
|
|
|
|
The split is only correct if four places agree, and only two of them are Python:
|
|
1. the panels' group here
|
|
2. RENDERED_GROUPS in PluginAssetPanels.vue
|
|
3. the tab label map in PCDetail.vue
|
|
4. the v-show block that gives the tab a layout
|
|
|
|
These tests pin the Python half so a later edit cannot quietly move a panel into
|
|
a group nothing renders. The frontend half is pinned by its own spec.
|
|
"""
|
|
|
|
from plugins.endpoints.plugin import EndpointsPlugin
|
|
from shopdb.core.api.pluginui import ASSET_PANEL_GROUPS
|
|
|
|
|
|
# Derived from the server tuple rather than hand-copied. This used to be a
|
|
# literal set duplicating RENDERED_GROUPS, which made it a FIFTH copy of the
|
|
# vocabulary and one more thing to forget: it passed for a group the server
|
|
# would rewrite to 'details' anyway. ASSET_PANEL_GROUPS is the value that
|
|
# actually decides what reaches the client, and panelGroups.spec.js pins it
|
|
# against the frontend copy.
|
|
RENDERED_GROUPS = set(ASSET_PANEL_GROUPS)
|
|
|
|
|
|
def _panels():
|
|
return {panel['id']: panel for panel in EndpointsPlugin().get_asset_panels()}
|
|
|
|
|
|
def test_no_panel_lands_in_a_group_the_frontend_does_not_render():
|
|
"""The failure mode that ate cards twice: a group with no tab."""
|
|
for panel in EndpointsPlugin().get_asset_panels():
|
|
group = panel.get('group', 'details')
|
|
assert group in RENDERED_GROUPS, (
|
|
f"panel {panel['id']} is in group {group!r}, which no tab renders"
|
|
)
|
|
|
|
|
|
def test_tracked_services_and_processes_moved_to_their_own_group():
|
|
panels = _panels()
|
|
|
|
assert panels['endpoints-tracked-services']['group'] == 'serviceprocess'
|
|
assert panels['endpoints-tracked-processes']['group'] == 'serviceprocess'
|
|
|
|
|
|
def test_the_service_process_tab_is_not_left_empty():
|
|
"""A tab whose panels all moved away reads as broken, not as absent."""
|
|
groups = [panel.get('group', 'details')
|
|
for panel in EndpointsPlugin().get_asset_panels()]
|
|
|
|
assert 'serviceprocess' in groups
|
|
|
|
|
|
def test_system_monitors_keeps_panels_of_its_own():
|
|
"""The rename is only safe if Monitors still has content after the move."""
|
|
groups = [panel.get('group', 'details')
|
|
for panel in EndpointsPlugin().get_asset_panels()]
|
|
|
|
assert 'monitors' in groups
|
|
|
|
|
|
def test_disk_health_stayed_with_the_system_health_panels():
|
|
"""Disk health is the box's own health, not something running on it.
|
|
|
|
It is now a section of the Storage card rather than a panel of its own,
|
|
so the group assertion follows it there.
|
|
"""
|
|
assert 'endpoints-diskhealth' not in _panels()
|
|
assert _panels()['endpoints-storage']['group'] == 'monitors'
|