13be0ef90f
Eleven commits from the sister site: a reversible Maximo/WINC machine-adoption import, a versioned agent binary store with upload and rollback, remote-BuildKit CI, tray version reporting, and UI fixes. Applied as a patch again - the published mirror rewrites hashes, so the branches have unrelated histories and git refuses to merge them. Reviewed by three agents before merging. Four things fixed here. THE PUBLISH WORKFLOW WAS DEAD. The new remote-BuildKit step in publish-images.yml sits at column 0 instead of indented under steps:, so the whole file is invalid YAML and GitHub would refuse it. Their entire GHCR distribution channel - which Start-ShopDBDev.ps1 and the compose files consume - was broken at the source and clearly never run. Indented; all five workflows now parse. THE IMPORT'S APPROVAL CHECK COULD NOT FAIL. commit() built the plan and the approval packet from the same upload and then asked the writer whether they matched, so packet_matches_plan compared a hash against itself. The documented contract - "a human approves a specific, frozen plan, and the writer can prove nothing drifted" - did not exist in the web path: an admin could preview file A and commit file B, gated only by the needs-create group NAMES they ticked. The preview's planhash is now required at commit and checked against a freshly rebuilt plan. Their tests committed without previewing, which is what let this through; they go through the real flow now, and three new tests pin it - all confirmed to fail with the check stubbed out. endpoints.agentpackage QUIETLY GREW. It used to mean "wrap the staged exe in a ZIP"; with the upload routes it also means "choose the executable every future package installs and runs as SYSTEM". Before this, staging needed filesystem access to the server. The permission description still said only "generate and download a package", so an admin granting it could not see what they were granting. Reworded. NOTHING RECORDED WHAT WAS STAGED, OR BY WHOM. The manifest held version, size and timestamp; re-uploading a version replaces the bytes in place under the same label. A sha256 of the stored file is now recorded, and the upload is audit-logged with it - after an incident there was previously no answer to who put that binary on the fleet. Also documented the nine new routes in docs/api-inventory.json (that gate cannot run on the mirror, so it falls to us at promotion time again), regenerated the spec and the project map, and kept our own docs where they conflicted: docs/ is scrubbed from the mirror, so their DEV-BUILD-TEST.md still had the dev-be channel mapping we corrected, and their PLUGIN-HOOKS.md was a new 45-line file rather than our 737-line canonical one. Their journal section is appended to ours. Contract version comes across as 0.30.0 for a genuinely additive surface. Suite 2369, frontend 324, gate green. Scope: product
58 lines
2.2 KiB
Python
58 lines
2.2 KiB
Python
"""Unit tests for the versioned agent binary store helpers.
|
|
|
|
Covers the pure, context-free helpers: version validation, PE magic and PE
|
|
file-version parsing. The staging/retention paths that touch the Flask instance
|
|
directory are exercised through the API tests; here we keep to the logic that
|
|
needs no app context.
|
|
|
|
The PE version parser walks the resource directory to the outer image's
|
|
RT_VERSION resource (not the first VS_FIXEDFILEINFO signature in the bytes),
|
|
because a self-contained single-file .NET exe bundles many framework assemblies
|
|
that each carry their own version block. Building a full PE with a resource
|
|
directory inline is impractical here, so the parser's correctness is verified
|
|
against real agent binaries in the API/integration layer; these unit tests pin
|
|
the surrounding validators and the malformed-input contract (never raises,
|
|
returns None).
|
|
"""
|
|
|
|
from plugins.endpoints.api import agentstore
|
|
|
|
|
|
def test_is_valid_version_accepts_dotted_numeric():
|
|
assert agentstore.is_valid_version('1')
|
|
assert agentstore.is_valid_version('1.6.3')
|
|
assert agentstore.is_valid_version('1.6.3.0')
|
|
|
|
|
|
def test_is_valid_version_rejects_bad_input():
|
|
assert not agentstore.is_valid_version('')
|
|
assert not agentstore.is_valid_version('v1.6')
|
|
assert not agentstore.is_valid_version('1.6.3.0.1')
|
|
assert not agentstore.is_valid_version('../etc')
|
|
assert not agentstore.is_valid_version('latest')
|
|
|
|
|
|
def test_is_valid_binary_key():
|
|
assert agentstore.is_valid_binary_key('agent')
|
|
assert agentstore.is_valid_binary_key('tray')
|
|
assert not agentstore.is_valid_binary_key('other')
|
|
|
|
|
|
def test_looks_like_pe():
|
|
assert agentstore.looks_like_pe(b'MZ\x90\x00')
|
|
assert not agentstore.looks_like_pe(b'PK\x03\x04')
|
|
assert not agentstore.looks_like_pe(b'')
|
|
|
|
|
|
def test_read_pe_file_version_none_on_non_pe():
|
|
assert agentstore.read_pe_file_version(b'not a pe file') is None
|
|
|
|
|
|
def test_read_pe_file_version_none_on_truncated_pe():
|
|
# MZ header but nothing else valid: must return None, never raise.
|
|
assert agentstore.read_pe_file_version(b'MZ' + b'\x00' * 200) is None
|
|
|
|
|
|
def test_read_pe_file_version_none_on_empty():
|
|
assert agentstore.read_pe_file_version(b'') is None
|