561988ac8f
The explainer panel used var(--surface, #fff) and PCDetail's Run Scripts and Corporate Tools styles used --text-primary, --text-secondary and --bg-secondary. None of those four tokens exist in this app's theme, so var() fell through: the explainer rendered a solid white block over the dark background and the surrounding copy lost its intended contrast. The real tokens are --bg-card, --text and --text-light. A fallback colour is what made this hard to catch - it looks correct in light mode and only misrenders on the theme the shop floor actually runs, so it would not have shown up in authoring or in review. Both files now carry a test asserting their styles reference only defined tokens and contain no var(--x, #colour) fallbacks. That test immediately caught a further dead --warning fallback in the banner. The two long per-field explanations in the Add Script form are now collapsed behind "How this works". The modal already scrolled, and three paragraphs of standing prose between the inputs pushed Save off screen, so the copy was being skimmed past rather than read.
125 lines
5.5 KiB
JavaScript
125 lines
5.5 KiB
JavaScript
/**
|
|
* System Scripts settings page.
|
|
*
|
|
* Two things are worth pinning here and nothing else is:
|
|
*
|
|
* 1. The page must NOT offer a run context. Scripts run as SYSTEM because the
|
|
* agent is a service with no user session; exposing a picker would let
|
|
* someone author a script that reads as "run as the logged-on user" and
|
|
* silently does not.
|
|
* 2. The SYSTEM warning must be present on both the list and the add/edit
|
|
* form. Someone pasting a script into the modal may never have read the
|
|
* page copy above it.
|
|
*
|
|
* Asserted against the file text, matching configurationPolicyEditable.spec.js.
|
|
*/
|
|
import { describe, it, expect } from 'vitest'
|
|
import { readFileSync } from 'fs'
|
|
import { join, dirname } from 'path'
|
|
import { fileURLToPath } from 'url'
|
|
|
|
const here = dirname(fileURLToPath(import.meta.url))
|
|
const source = readFileSync(join(here, 'SystemScriptsSettings.vue'), 'utf8')
|
|
const routes = readFileSync(join(here, '..', 'routes.js'), 'utf8')
|
|
|
|
describe('SystemScriptsSettings', () => {
|
|
it('warns that scripts run as SYSTEM on the list page and in the form', () => {
|
|
const warnings = source.match(/runs? as SYSTEM/g) || []
|
|
expect(warnings.length).toBeGreaterThanOrEqual(2)
|
|
})
|
|
|
|
it('does not offer a run context picker', () => {
|
|
expect(source).not.toMatch(/runcontext/i)
|
|
})
|
|
|
|
it('does not send a runcontext in its save payload', () => {
|
|
const payload = source.slice(source.indexOf('const payload = {'))
|
|
expect(payload.slice(0, 200)).not.toMatch(/runcontext/i)
|
|
})
|
|
|
|
it('flags a script with no body as unrunnable', () => {
|
|
expect(source).toMatch(/hasbody/)
|
|
expect(source).toMatch(/cannot run/i)
|
|
})
|
|
|
|
it('is gated on the standalone script permission, not admin', () => {
|
|
const route = routes.slice(routes.indexOf("'settings/endpoints/scripts'"))
|
|
expect(route).toMatch(/requiresPermission: 'endpoints\.runscript'/)
|
|
expect(route.slice(0, 300)).not.toMatch(/requiresAdmin/)
|
|
})
|
|
|
|
it('offers an optional working directory and sends it on save', () => {
|
|
expect(source).toMatch(/form\.workingdirectory/)
|
|
const payload = source.slice(source.indexOf('const payload = {'))
|
|
expect(payload.slice(0, 300)).toMatch(/workingdirectory/)
|
|
})
|
|
|
|
it('shows the staging default rather than an empty cell', () => {
|
|
// A blank cell reads as "unknown". The folder is the difference between a
|
|
// corporate tool being found and the script failing further in, so the
|
|
// list has to state the default out loud.
|
|
expect(source).toMatch(/Agent staging folder/)
|
|
})
|
|
|
|
it('offers an error mode and sends it on save', () => {
|
|
expect(source).toMatch(/form\.errormode/)
|
|
const payload = source.slice(source.indexOf('const payload = {'))
|
|
expect(payload.slice(0, 300)).toMatch(/errormode/)
|
|
})
|
|
|
|
it('defaults a new script to the permissive mode', () => {
|
|
// Strict changes how a body behaves partway through. Defaulting to it
|
|
// would silently alter every script authored from here on, so a new
|
|
// script has to start where the old ones already are.
|
|
const empty = source.slice(source.indexOf('function emptyForm'))
|
|
expect(empty.slice(0, 300)).toMatch(/errormode: 'default'/)
|
|
})
|
|
|
|
it('names both error modes by their consequence, not by their flag', () => {
|
|
// "default" and "strict" mean nothing to the person choosing. What they
|
|
// need to know is which one can report success having done nothing.
|
|
expect(source).toMatch(/Continue - report success if the script reaches the end/)
|
|
expect(source).toMatch(/Stop on the first error and fail the command/)
|
|
})
|
|
|
|
it('explains the non-terminating error trap that justifies the choice', () => {
|
|
// The whole feature exists because PowerShell exits zero after an error.
|
|
// If the page never says so, the dropdown looks like pedantry and stays
|
|
// on the setting that produces false green.
|
|
expect(source).toMatch(/non-terminating/i)
|
|
expect(source).toMatch(/exits? zero/i)
|
|
})
|
|
|
|
it('offers the explainer collapsed so it does not bury the page', () => {
|
|
expect(source).toMatch(/<details class="explainer">/)
|
|
expect(source).toMatch(/How does this work\?/)
|
|
expect(source).not.toMatch(/<details class="explainer" open>/)
|
|
})
|
|
|
|
it('collapses the long per-field prose in the form', () => {
|
|
// The modal is already tall enough to scroll. Three paragraphs of standing
|
|
// explanation between the inputs pushes Save off screen and gets skimmed
|
|
// past, which is the opposite of what the copy is for.
|
|
const helps = source.match(/<details class="field-help">/g) || []
|
|
expect(helps.length).toBeGreaterThanOrEqual(2)
|
|
expect(source).toMatch(/<summary>How this works<\/summary>/)
|
|
})
|
|
|
|
it('styles itself from defined theme tokens only', () => {
|
|
// --surface and --text-primary are not defined by this app's theme, so a
|
|
// var() fallback silently rendered a white panel on the dark background.
|
|
// A fallback colour is the bug: it looks correct in light mode and only
|
|
// shows up as a bright block for dark-mode users.
|
|
const styles = source.slice(source.indexOf('<style scoped>'))
|
|
expect(styles).not.toMatch(/--surface|--text-primary|--text-secondary|--bg-secondary/)
|
|
expect(styles).not.toMatch(/var\(--[a-z-]+,\s*#/)
|
|
})
|
|
|
|
it('states that output is kept locally and only returned on failure', () => {
|
|
// Operators otherwise assume either that nothing was captured or that
|
|
// every run is shipped back to the server.
|
|
const explainer = source.slice(source.indexOf('Where the output goes'))
|
|
expect(explainer.slice(0, 400)).toMatch(/only when the run fails/i)
|
|
})
|
|
})
|