Whether somebody with no account may see something was being answered one feature at a time: a securesend_allow_guests setting, an enable flag per kiosk, and very nearly a third for guides - each with its own settings page, its own vocabulary and its own hand-written branch inside a route. Every one of them answered a permissions question, and this app already administers permissions per role. So a caller with no token is not nobody: they hold the seeded `guest` role. require_permission consults it when there is no identity, which is the entire mechanism. The role is seeded holding NOTHING, so an upgrade opens no door; a site opens one by ticking a box in the same grid it uses for every other role, and closes it the same way. Revocation is read on every request rather than cached, because taking guest access away is what somebody does the moment they realise what they opened, and it has to bite immediately. The redundant @jwt_required() above require_permission is gone from 184 routes. It was belt-and-braces before; now it is actively wrong, because it refuses a request with no token before the permission check can have an opinion, so a grant would appear to do nothing. What a guest may hold is bounded. Any .view or .read permission is grantable. A WRITE has to be blessed by whoever owns it, through the new get_guest_grantable_permissions hook (contract 0.21.0), and Secure Send is the only case that exists: sending a password to a vendor is the one write this product means to offer somebody who never signs in. Everything else is refused by the API and greyed out in the grid rather than warned about - a checkbox that quietly makes deleting an asset anonymous is not a warning anybody reads twice. A guest write records no creator: the trail says when and from where, never who, and that is the reason for the bar. GE-Enforce and Slides gained read permissions so they can be opened to guests without handing out the manage right. Their read routes accept either through require_any_permission, so nothing an existing manager could reach has moved. The navigation endpoint now returns only what the caller can actually reach. Without that a signed-out visitor gets a sidebar of the whole app where every link bounces off the login page, which reads as a broken site rather than as a closed door. A nav item may name several permissions; holding any one is enough, which is what GE-Enforce and Slides need now that a viewer and a manager hold different strings. Two things this found on the way: current_user is a LocalProxy, so `current_user is None` is False for a request with nobody behind it - harmless under a required JWT, an AttributeError the moment verification became optional. And an image pasted into a guide before its first save was never attached to it, so it was visible to editors and invisible to every reader; saving now attaches it, and `flask guides fix-images` repairs what is stored. The guides guest setting written earlier today is gone. Granting guides.view to the guest role replaces it, which is the point.
264 lines
8.8 KiB
Python
264 lines
8.8 KiB
Python
"""Audit log API routes."""
|
|
|
|
from flask import Blueprint, request
|
|
from flask_jwt_extended import jwt_required
|
|
|
|
from shopdb.core.models import AuditLog
|
|
from shopdb.extensions import db
|
|
from shopdb.utils.responses import success_response, error_response, ErrorCodes
|
|
from shopdb.utils.authz import require_permission
|
|
|
|
auditlogs_bp = Blueprint('auditlogs', __name__)
|
|
|
|
|
|
def _resolve_full_names(ssos):
|
|
"""Best-effort SSO -> full name map for audit rows. Mode-aware, guarded,
|
|
degrades to {} so the list still renders if the directory is unreachable."""
|
|
wanted = {s for s in ssos if s and str(s).isdigit()}
|
|
if not wanted:
|
|
return {}
|
|
names = {}
|
|
# Self-hosted directory first (no external dependency).
|
|
try:
|
|
from plugins.employees.models import DirectoryEmployee
|
|
rows = DirectoryEmployee.query.filter(
|
|
DirectoryEmployee.sso.in_(wanted)).all()
|
|
for emp in rows:
|
|
full = f'{(emp.firstname or "").strip()} {(emp.lastname or "").strip()}'.strip()
|
|
if full:
|
|
names[str(emp.sso)] = full
|
|
except Exception:
|
|
pass
|
|
missing = wanted - set(names)
|
|
if not missing:
|
|
return names
|
|
# External HR directory for anything still unresolved.
|
|
try:
|
|
from shopdb.utils.employee_db import employee_connection
|
|
conn = employee_connection()
|
|
placeholders = ','.join(['%s'] * len(missing))
|
|
with conn.cursor() as cur:
|
|
cur.execute(
|
|
'SELECT SSO, First_Name, Last_Name FROM employees '
|
|
f'WHERE SSO IN ({placeholders})', tuple(missing))
|
|
for emp in cur.fetchall():
|
|
full = f'{(emp["First_Name"] or "").strip()} {(emp["Last_Name"] or "").strip()}'.strip()
|
|
if full:
|
|
names[str(emp['SSO'])] = full
|
|
conn.close()
|
|
except Exception:
|
|
pass
|
|
return names
|
|
|
|
|
|
@auditlogs_bp.route('', methods=['GET'])
|
|
@require_permission('audit.view')
|
|
def list_auditlogs():
|
|
"""
|
|
List audit logs with filtering and pagination.
|
|
|
|
Query params:
|
|
page: Page number (default 1)
|
|
perpage: Items per page (default 50, max 200)
|
|
action: Filter by action (created, updated, deleted)
|
|
entitytype: Filter by entity type
|
|
userid: Filter by user ID
|
|
search: Search in entityname or username
|
|
from_date: Filter from date (ISO format)
|
|
to_date: Filter to date (ISO format)
|
|
"""
|
|
page = request.args.get('page', 1, type=int)
|
|
perpage = min(request.args.get('perpage', 50, type=int), 200)
|
|
|
|
query = AuditLog.query
|
|
|
|
# Filters
|
|
action = request.args.get('action')
|
|
if action:
|
|
query = query.filter(AuditLog.action == action)
|
|
|
|
entitytype = request.args.get('entitytype')
|
|
if entitytype:
|
|
query = query.filter(AuditLog.entitytype == entitytype)
|
|
|
|
userid = request.args.get('userid', type=int)
|
|
if userid:
|
|
query = query.filter(AuditLog.userid == userid)
|
|
|
|
search = request.args.get('search')
|
|
if search:
|
|
search_term = f'%{search}%'
|
|
query = query.filter(
|
|
(AuditLog.entityname.ilike(search_term)) |
|
|
(AuditLog.username.ilike(search_term))
|
|
)
|
|
|
|
from_date = request.args.get('from_date')
|
|
if from_date:
|
|
from datetime import datetime
|
|
try:
|
|
dt = datetime.fromisoformat(from_date.replace('Z', '+00:00'))
|
|
query = query.filter(AuditLog.timestamp >= dt)
|
|
except ValueError:
|
|
pass
|
|
|
|
to_date = request.args.get('to_date')
|
|
if to_date:
|
|
from datetime import datetime
|
|
try:
|
|
dt = datetime.fromisoformat(to_date.replace('Z', '+00:00'))
|
|
query = query.filter(AuditLog.timestamp <= dt)
|
|
except ValueError:
|
|
pass
|
|
|
|
# Order by most recent first
|
|
query = query.order_by(AuditLog.timestamp.desc())
|
|
|
|
# Paginate
|
|
pagination = query.paginate(page=page, per_page=perpage, error_out=False)
|
|
|
|
rows = [log.to_dict() for log in pagination.items]
|
|
# Attach full names (hover tooltip on the SSO); best-effort.
|
|
fullnames = _resolve_full_names({r.get('username') for r in rows})
|
|
for r in rows:
|
|
r['userfullname'] = fullnames.get(str(r.get('username')))
|
|
|
|
return success_response(
|
|
rows,
|
|
meta={
|
|
'page': page,
|
|
'perpage': perpage,
|
|
'total': pagination.total,
|
|
'pages': pagination.pages
|
|
}
|
|
)
|
|
|
|
|
|
@auditlogs_bp.route('/entity/<entitytype>/<int:entityid>', methods=['GET'])
|
|
@require_permission('audit.view')
|
|
def get_entity_history(entitytype: str, entityid: int):
|
|
"""Get audit history for a specific entity."""
|
|
logs = AuditLog.query.filter_by(
|
|
entitytype=entitytype,
|
|
entityid=entityid
|
|
).order_by(AuditLog.timestamp.desc()).all()
|
|
|
|
return success_response([log.to_dict() for log in logs])
|
|
|
|
|
|
@auditlogs_bp.route('/stats', methods=['GET'])
|
|
@require_permission('audit.view')
|
|
def get_stats():
|
|
"""Get audit log statistics."""
|
|
from sqlalchemy import func
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
# Actions by type
|
|
actions = db_func_count_by(AuditLog.action)
|
|
|
|
# Entity types
|
|
entities = db_func_count_by(AuditLog.entitytype)
|
|
|
|
# Recent activity (last 7 days)
|
|
week_ago = datetime.now(timezone.utc).replace(tzinfo=None) - timedelta(days=7)
|
|
recent_count = AuditLog.query.filter(AuditLog.timestamp >= week_ago).count()
|
|
|
|
# Most active users (last 7 days)
|
|
from shopdb.extensions import db
|
|
active_users = db.session.query(
|
|
AuditLog.username,
|
|
func.count(AuditLog.auditlogid).label('count')
|
|
).filter(
|
|
AuditLog.timestamp >= week_ago,
|
|
AuditLog.username.isnot(None)
|
|
).group_by(AuditLog.username).order_by(func.count(AuditLog.auditlogid).desc()).limit(5).all()
|
|
|
|
return success_response({
|
|
'actions': actions,
|
|
'entities': entities,
|
|
'recentCount': recent_count,
|
|
'activeUsers': [{'username': u[0], 'count': u[1]} for u in active_users]
|
|
})
|
|
|
|
|
|
def db_func_count_by(column):
|
|
"""Helper to count grouped by a column."""
|
|
from sqlalchemy import func
|
|
from shopdb.extensions import db
|
|
|
|
results = db.session.query(
|
|
column,
|
|
func.count().label('count')
|
|
).group_by(column).all()
|
|
|
|
return {r[0]: r[1] for r in results}
|
|
|
|
|
|
@auditlogs_bp.route('/retention', methods=['GET'])
|
|
@require_permission('audit.view')
|
|
def get_retention():
|
|
"""Size of the log and what the configured retention would remove.
|
|
|
|
Drives the Site & Facility card: an admin should see the number of entries a
|
|
purge deletes BEFORE pressing anything.
|
|
"""
|
|
from shopdb.core.services import auditretention
|
|
days = auditretention.configureddays()
|
|
return success_response(auditretention.stats(days or None))
|
|
|
|
|
|
@auditlogs_bp.route('/purge', methods=['POST'])
|
|
@require_permission('audit.purge')
|
|
def purge_auditlogs():
|
|
"""Delete entries older than the retention window.
|
|
|
|
Separate permission from audit.view: reading the log and destroying it are
|
|
not the same act, and plenty of people need the first.
|
|
|
|
Batch-capped, because this runs inside a request that a proxy will time out.
|
|
An incomplete purge returns complete=false and the number still to go rather
|
|
than reporting a finished job - the caller re-posts, or runs
|
|
`flask audit purge --apply` on the server, which has no cap.
|
|
"""
|
|
from flask import request as flask_request
|
|
from shopdb.core.services import auditretention
|
|
|
|
body = flask_request.get_json(silent=True) or {}
|
|
days = body.get('days')
|
|
if days is None:
|
|
days = auditretention.configureddays()
|
|
try:
|
|
days = int(days)
|
|
except (TypeError, ValueError):
|
|
days = 0
|
|
if days <= 0:
|
|
return error_response(
|
|
ErrorCodes.VALIDATION_ERROR,
|
|
'No retention period is configured. Set one in Site & Facility '
|
|
'settings before purging.')
|
|
|
|
dryrun = bool(body.get('dryrun'))
|
|
result = auditretention.purge(
|
|
days, dryrun=dryrun,
|
|
maxbatches=None if dryrun else auditretention.MAXBATCHES_REQUEST)
|
|
|
|
if dryrun:
|
|
message = '{:,} entry(s) would be deleted'.format(result['matched'])
|
|
elif result['complete']:
|
|
message = 'Deleted {:,} entry(s)'.format(result['deleted'])
|
|
else:
|
|
message = ('Deleted {:,} entry(s); {:,} still older than the cutoff. '
|
|
'Run it again to continue.').format(
|
|
result['deleted'], result['remaining'])
|
|
|
|
# The purge is itself an audited act, and this row postdates the cutoff so
|
|
# it survives the purge that created it.
|
|
if not dryrun and result['deleted']:
|
|
from shopdb.api import audit_log
|
|
audit_log(action='deleted', entitytype='AuditLog',
|
|
entityname='purge older than {} days'.format(days),
|
|
changes={'deleted': result['deleted'],
|
|
'cutoff': result['cutoff']})
|
|
|
|
return success_response(result, message=message)
|