534f179ee6
main was 16 days and 259 commits behind the line the product is actually built on, at contract 0.30.0 against 0.35.0, with no per-PC credential code at all. It was neither current nor curated - just stale. This brings it forward and, at the same time, makes it mean something: main is what a receiving site installs, and nothing else. WHAT IT CARRIES. Twelve plugins - backups, computers, endpoints, guides, knowledgebase, machines, network, notifications, printers, slides, tools, warranty - plus applications, which is manifest-less core and always ships. The only manifest dependency inside that set is endpoints on computers, and both are in it, so the closure is self-contained. WHAT IT DOES NOT. employees, geenforce, measuringtools, printedparts and usb stay on the site line. So do the Windows installer tree, the VM rehearsal helpers, the agent tooling config, one site's data loader, the internal audit and findings records, and the planner spreadsheet. 1,135 tracked files against 1,438. A REMOVAL THAT BREAKS THE APP IS NOT A REMOVAL, and two nearly shipped: deploy/site-profile-universal.json still named all seventeen plugins. It is the file docs/DEPLOY.md tells a site to provision from, so a fresh install would have failed at `flask plugin apply-profile` with PluginError - the first thing a receiving site does, broken by the branch meant to serve them. It now names the twelve that exist, and its comment says the two must agree. agent/ was never refreshed. Whoever populated this branch copied shopdb/, plugins/, frontend/ and tests/ from the site line and left the agent tree at its September state: 22 C# and PowerShell sources missing, including AgentCredentials, EnrollmentService, AgentHttpFactory and the fleet-alert client, plus one file the site line had deleted still present. The old tree is internally consistent, so it compiles, and nothing in CI builds it - every gate was green over a server that speaks enrollment and per-PC credentials to a bundled agent source that cannot. Resynced whole. DECISIONS THIS ENCODES, rather than defers: - The plugin-authoring lab builds printedparts, whose manifest depends on employees, so it could not stay. The lab remains on the site line and main ships no build-along tutorial. That is a real loss for an adopting developer and is recorded here rather than discovered later. - Recognition, Training and Recertification notifications are no longer seeded. Each splits one notification into a card per employee and renders a photo, which needs a plugin this branch does not bundle. Seeding them would offer an author a type that cannot resolve anybody. A site that installs employees gets them from that plugin's own seed. - Windows/IIS is documented as the legacy path throughout, and the README leads with Docker, because that is what a receiving site gets. The API description is regenerated for THIS branch - 347 paths and 483 operations, down from 415 and 573 - so the published contract describes what is here rather than what the site line serves. docs/CONFIG.md lost the two measuring-tool label keys the code no longer declares, which two lanes had decided opposite ways. Suite: 3124 passed, 6 skipped. Naming and style gates pass. The docs gates run rather than skip, and every index line count is derived from the file it names.
50 lines
1.9 KiB
Python
50 lines
1.9 KiB
Python
"""NIC link label: an unknown link must never read as a working one.
|
|
|
|
Link speed and duplex are paired onto the interface rows from a second WMI
|
|
class, so three states are possible: read successfully, unreadable, and
|
|
disconnected. Verified on a live box that a DISCONNECTED adapter returns empty
|
|
Speed and FullDuplex - two of four NICs on the test machine were in that state.
|
|
|
|
That is the trap these tests pin. Defaulting an absent speed to 0 or an absent
|
|
duplex to False would report every unplugged NIC as half duplex, which is the
|
|
exact signature of the cable/port fault this field exists to catch. A column
|
|
that cries fault on every disconnected NIC is a column nobody reads.
|
|
"""
|
|
|
|
from plugins.endpoints.api.routes import _link_label
|
|
|
|
|
|
def test_a_gigabit_full_duplex_link_is_not_annotated():
|
|
"""The normal case should be quiet so the abnormal case stands out."""
|
|
assert _link_label(1000000000, True) == '1 Gb'
|
|
|
|
|
|
def test_half_duplex_is_called_out_because_it_is_the_actionable_case():
|
|
assert _link_label(100000000, False) == '100 Mb half duplex'
|
|
|
|
|
|
def test_a_disconnected_adapter_reads_as_unknown_not_half_duplex():
|
|
"""The live-box case: disconnected NICs return empty speed and duplex.
|
|
|
|
Reading this as half duplex would flag every unplugged NIC as a fault.
|
|
"""
|
|
assert _link_label(None, None) == '-'
|
|
|
|
|
|
def test_an_unreadable_duplex_on_a_live_link_is_not_assumed_half():
|
|
"""Speed known, duplex not. Unknown duplex must not render as a fault."""
|
|
assert _link_label(10000000000, None) == '10 Gb'
|
|
|
|
|
|
def test_zero_speed_is_unknown_rather_than_a_zero_speed_link():
|
|
assert _link_label(0, True) == '-'
|
|
|
|
|
|
def test_sub_gigabit_speeds_stay_in_megabits():
|
|
assert _link_label(10000000, True) == '10 Mb'
|
|
|
|
|
|
def test_speeds_do_not_render_trailing_zeros():
|
|
"""2.5Gb NICs are common now; the label should not read '2.5000 Gb'."""
|
|
assert _link_label(2500000000, True) == '2.5 Gb'
|