b8c22244a1
Make the app distributable to other GE Aerospace sites (one self-hosted
instance per site, ADR-004). GE values remain the shipped defaults; every
site-specific behavior is now a Setting an admin can change in the UI.
Settings-driven site config:
- Branding: site/QR/badge logos, favicon, primary color (upload endpoints
mirror the map-blueprint pattern; new Settings > Branding section).
- ServiceNow: search/incident/change URL templates ({ticket}), ticket
prefixes, enable toggle. Defaults point at the current
geaerospaceqa.service-now.com global search. Disabled = plain-text tickets.
- Employee-id regex (employeeid_pattern), printer hostname template,
QR label targets (qr_target_printer / qr_target_usb, blank = asset page,
else URL template with placeholders), usb_label_style (barcode|qr).
- West Jefferson floor-plan PNGs removed from the tree; generic placeholder
ships as the map default and sites upload their own blueprint.
Security closeout:
- dashboarddefaults writes now require admin.
- Collector: generic error messages (no str(exc) leak); API key accepted
via X-API-Key header only (BREAKING: querystring api_key removed).
- IP-based login rate limiting (AUTH_RATELIMIT_* knobs) atop account lockout.
- Setting.set() creation race fixed (IntegrityError retry).
Release engineering and docs:
- __version__ 0.5.0 (distinct from __contract_version__, ADR-007),
CHANGELOG.md, Gitea Actions CI config, frontend version aligned.
- One wizard-first install story across README/DEPLOY; new CONFIG.md,
UPGRADE.md, BACKUP-RESTORE.md; CLAUDE.md and ROADMAP de-staled.
- Dockerfile multi-stage build now bundles the frontend; compose binds
MySQL to 127.0.0.1; stale database/schema.sql and one-off SQL removed.
Debt and fixes:
- .query.get() -> db.session.get() sweep; datetime.utcnow() removed
(naive-UTC via timezone-aware now); users.py on authz decorators.
- Fixed 4 stale tests (slides feed shape, shopfloor splitperemployee,
plugin contract purity) and the USB label page field mapping (both usb
modes emit the cmmc shape: device_id/device_desc).
- Health endpoint reports the real version.
248 tests pass; naming/style check green; frontend builds; fresh-DB
flask db upgrade + seeds verified; QR targets verified by decoding
rendered codes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
73 lines
2.6 KiB
Python
73 lines
2.6 KiB
Python
"""Tests for the shopfloor TV feed (/api/notifications/shopfloor).
|
|
|
|
Since the notification-type display rework, per-employee fan-out is driven by
|
|
the type's splitperemployee column (seeded true for Recognition/Training):
|
|
a note naming several comma-joined SSOs yields one card per employee; types
|
|
without the flag stay a single card.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from plugins.notifications.models import Notification, NotificationType
|
|
|
|
|
|
def _make_type(db, typename, typecolor, splitperemployee=False):
|
|
t = NotificationType(typename=typename, typecolor=typecolor,
|
|
splitperemployee=splitperemployee, isactive=True)
|
|
db.session.add(t)
|
|
db.session.commit()
|
|
return t
|
|
|
|
|
|
def _make_shopfloor_note(db, ntype, employeesso, employeename):
|
|
n = Notification(
|
|
notificationtypeid=ntype.notificationtypeid,
|
|
notification='msg',
|
|
businessunitid=None,
|
|
isactive=True,
|
|
isshopfloor=True,
|
|
employeesso=employeesso,
|
|
employeename=employeename,
|
|
)
|
|
db.session.add(n)
|
|
db.session.commit()
|
|
return n
|
|
|
|
|
|
@pytest.mark.parametrize('typecolor', ['recognition', 'training'])
|
|
def test_multi_employee_split_into_one_card_each(client, db, typecolor):
|
|
"""A split-flagged note with two SSOs yields two current cards."""
|
|
ntype = _make_type(db, typecolor.capitalize(), typecolor, splitperemployee=True)
|
|
_make_shopfloor_note(db, ntype, '111,222', 'Alice, Bob')
|
|
|
|
resp = client.get('/api/notifications/shopfloor')
|
|
assert resp.status_code == 200
|
|
current = resp.get_json()['data']['current']
|
|
assert len(current) == 2
|
|
assert {c['employeesso'] for c in current} == {'111', '222'}
|
|
assert {c['employeename'] for c in current} == {'Alice', 'Bob'}
|
|
|
|
|
|
def test_non_split_type_stays_single_card(client, db):
|
|
"""A type without splitperemployee is not fanned out, even with many SSOs."""
|
|
ntype = _make_type(db, 'Awareness', 'info')
|
|
_make_shopfloor_note(db, ntype, '111,222', 'Alice, Bob')
|
|
|
|
resp = client.get('/api/notifications/shopfloor')
|
|
assert resp.status_code == 200
|
|
current = resp.get_json()['data']['current']
|
|
assert len(current) == 1
|
|
assert current[0]['employeesso'] == '111,222'
|
|
|
|
|
|
def test_single_employee_recognition_stays_single_card(client, db):
|
|
"""One SSO produces one card (no spurious split on a lone employee)."""
|
|
ntype = _make_type(db, 'Recognition', 'recognition', splitperemployee=True)
|
|
_make_shopfloor_note(db, ntype, '111', 'Alice')
|
|
|
|
resp = client.get('/api/notifications/shopfloor')
|
|
assert resp.status_code == 200
|
|
current = resp.get_json()['data']['current']
|
|
assert len(current) == 1
|
|
assert current[0]['employeesso'] == '111'
|