Make the app distributable to other GE Aerospace sites (one self-hosted
instance per site, ADR-004). GE values remain the shipped defaults; every
site-specific behavior is now a Setting an admin can change in the UI.
Settings-driven site config:
- Branding: site/QR/badge logos, favicon, primary color (upload endpoints
mirror the map-blueprint pattern; new Settings > Branding section).
- ServiceNow: search/incident/change URL templates ({ticket}), ticket
prefixes, enable toggle. Defaults point at the current
geaerospaceqa.service-now.com global search. Disabled = plain-text tickets.
- Employee-id regex (employeeid_pattern), printer hostname template,
QR label targets (qr_target_printer / qr_target_usb, blank = asset page,
else URL template with placeholders), usb_label_style (barcode|qr).
- West Jefferson floor-plan PNGs removed from the tree; generic placeholder
ships as the map default and sites upload their own blueprint.
Security closeout:
- dashboarddefaults writes now require admin.
- Collector: generic error messages (no str(exc) leak); API key accepted
via X-API-Key header only (BREAKING: querystring api_key removed).
- IP-based login rate limiting (AUTH_RATELIMIT_* knobs) atop account lockout.
- Setting.set() creation race fixed (IntegrityError retry).
Release engineering and docs:
- __version__ 0.5.0 (distinct from __contract_version__, ADR-007),
CHANGELOG.md, Gitea Actions CI config, frontend version aligned.
- One wizard-first install story across README/DEPLOY; new CONFIG.md,
UPGRADE.md, BACKUP-RESTORE.md; CLAUDE.md and ROADMAP de-staled.
- Dockerfile multi-stage build now bundles the frontend; compose binds
MySQL to 127.0.0.1; stale database/schema.sql and one-off SQL removed.
Debt and fixes:
- .query.get() -> db.session.get() sweep; datetime.utcnow() removed
(naive-UTC via timezone-aware now); users.py on authz decorators.
- Fixed 4 stale tests (slides feed shape, shopfloor splitperemployee,
plugin contract purity) and the USB label page field mapping (both usb
modes emit the cmmc shape: device_id/device_desc).
- Health endpoint reports the real version.
248 tests pass; naming/style check green; frontend builds; fresh-DB
flask db upgrade + seeds verified; QR targets verified by decoding
rendered codes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
150 lines
4.3 KiB
Python
150 lines
4.3 KiB
Python
"""Business Units API endpoints - Full CRUD."""
|
|
|
|
from flask import Blueprint, request
|
|
from flask_jwt_extended import jwt_required
|
|
|
|
from shopdb.extensions import db
|
|
from shopdb.core.models import BusinessUnit
|
|
from shopdb.utils.responses import (
|
|
success_response,
|
|
error_response,
|
|
paginated_response,
|
|
ErrorCodes
|
|
)
|
|
from shopdb.utils.pagination import get_pagination_params, paginate_query
|
|
|
|
from shopdb.utils.authz import require_permission, require_role
|
|
|
|
businessunits_bp = Blueprint('businessunits', __name__)
|
|
|
|
|
|
@businessunits_bp.route('', methods=['GET'])
|
|
@jwt_required(optional=True)
|
|
def list_businessunits():
|
|
"""List all business units."""
|
|
page, per_page = get_pagination_params(request)
|
|
|
|
query = BusinessUnit.query
|
|
|
|
if request.args.get('active', 'true').lower() != 'false':
|
|
query = query.filter(BusinessUnit.isactive == True)
|
|
|
|
if search := request.args.get('search'):
|
|
query = query.filter(
|
|
db.or_(
|
|
BusinessUnit.businessunit.ilike(f'%{search}%'),
|
|
BusinessUnit.code.ilike(f'%{search}%')
|
|
)
|
|
)
|
|
|
|
query = query.order_by(BusinessUnit.businessunit)
|
|
|
|
items, total = paginate_query(query, page, per_page)
|
|
data = [bu.to_dict() for bu in items]
|
|
|
|
return paginated_response(data, page, per_page, total)
|
|
|
|
|
|
@businessunits_bp.route('/<int:bu_id>', methods=['GET'])
|
|
@jwt_required(optional=True)
|
|
def get_businessunit(bu_id: int):
|
|
"""Get a single business unit."""
|
|
bu = db.session.get(BusinessUnit, bu_id)
|
|
|
|
if not bu:
|
|
return error_response(
|
|
ErrorCodes.NOT_FOUND,
|
|
f'Business unit with ID {bu_id} not found',
|
|
http_code=404
|
|
)
|
|
|
|
data = bu.to_dict()
|
|
data['parent'] = bu.parent.to_dict() if bu.parent else None
|
|
data['children'] = [c.to_dict() for c in bu.children]
|
|
|
|
return success_response(data)
|
|
|
|
|
|
@businessunits_bp.route('', methods=['POST'])
|
|
@jwt_required()
|
|
@require_role('admin')
|
|
def create_businessunit():
|
|
"""Create a new business unit."""
|
|
data = request.get_json()
|
|
|
|
if not data or not data.get('businessunit'):
|
|
return error_response(ErrorCodes.VALIDATION_ERROR, 'businessunit is required')
|
|
|
|
if BusinessUnit.query.filter_by(businessunit=data['businessunit']).first():
|
|
return error_response(
|
|
ErrorCodes.CONFLICT,
|
|
f"Business unit '{data['businessunit']}' already exists",
|
|
http_code=409
|
|
)
|
|
|
|
bu = BusinessUnit(
|
|
businessunit=data['businessunit'],
|
|
code=data.get('code'),
|
|
description=data.get('description'),
|
|
parentid=data.get('parentid')
|
|
)
|
|
|
|
db.session.add(bu)
|
|
db.session.commit()
|
|
|
|
return success_response(bu.to_dict(), message='Business unit created', http_code=201)
|
|
|
|
|
|
@businessunits_bp.route('/<int:bu_id>', methods=['PUT'])
|
|
@jwt_required()
|
|
@require_role('admin')
|
|
def update_businessunit(bu_id: int):
|
|
"""Update a business unit."""
|
|
bu = db.session.get(BusinessUnit, bu_id)
|
|
|
|
if not bu:
|
|
return error_response(
|
|
ErrorCodes.NOT_FOUND,
|
|
f'Business unit with ID {bu_id} not found',
|
|
http_code=404
|
|
)
|
|
|
|
data = request.get_json()
|
|
if not data:
|
|
return error_response(ErrorCodes.VALIDATION_ERROR, 'No data provided')
|
|
|
|
if 'businessunit' in data and data['businessunit'] != bu.businessunit:
|
|
if BusinessUnit.query.filter_by(businessunit=data['businessunit']).first():
|
|
return error_response(
|
|
ErrorCodes.CONFLICT,
|
|
f"Business unit '{data['businessunit']}' already exists",
|
|
http_code=409
|
|
)
|
|
|
|
for key in ['businessunit', 'code', 'description', 'parentid', 'isactive']:
|
|
if key in data:
|
|
setattr(bu, key, data[key])
|
|
|
|
db.session.commit()
|
|
return success_response(bu.to_dict(), message='Business unit updated')
|
|
|
|
|
|
@businessunits_bp.route('/<int:bu_id>', methods=['DELETE'])
|
|
@jwt_required()
|
|
@require_role('admin')
|
|
def delete_businessunit(bu_id: int):
|
|
"""Delete (deactivate) a business unit."""
|
|
bu = db.session.get(BusinessUnit, bu_id)
|
|
|
|
if not bu:
|
|
return error_response(
|
|
ErrorCodes.NOT_FOUND,
|
|
f'Business unit with ID {bu_id} not found',
|
|
http_code=404
|
|
)
|
|
|
|
bu.isactive = False
|
|
db.session.commit()
|
|
|
|
return success_response(message='Business unit deleted')
|