b96637e1a1
Reported: `flask plugin upgrade-all` failed the tools plugin with "table securesendsecrets already exists". Every post-cutover baseline emitted a plain op.create_table. That is correct only while a table's existence and its plugin's Alembic stamp can never disagree, and they can. Anything that builds tables from the models - db.create_all(), which `flask db-utils create-all` calls - creates them and stamps nothing. A run that creates a table and then fails before its stamp commits leaves the same split, and re-running is the obvious thing to try. In both cases upgrade-all meets existing tables with an unstamped chain and the create is fatal. Nothing caught it because the migration test DROPS the post-cutover tables db.create_all() built before running upgrade-all. That arranges the one state where an unguarded create works, and never the state the report came from. The new test is the same sequence with the drop removed for the plugin under test. create_table_if_missing and create_index_if_missing are in alembic_template.py next to create_plugin_tables, which had the idempotency rule right and turns out to be called by nobody - its docstring claimed every 0001 used it. Fixed the docstring rather than rewiring the baselines onto it, because the reason they hand-write their DDL still stands: the helper's per-plugin MetaData cannot resolve a foreign key to a core table at CreateTable-compile time. INDEXES ARE MATCHED ON COLUMNS, NOT NAME, and that distinction matters. The two creators disagree about names - db.create_all() takes SQLAlchemy's default convention (ix_securesendsecrets_token) and a baseline spells it the way this repo's naming rules require (ixsecuresendsecretstoken). A name-keyed guard would have called the index missing and added a second one over the same column, which MySQL permits with a warning, so every affected site would have quietly grown duplicates. The test asserts no table ends up with two indexes over the same columns. Applied to all nine table-creating plugin migrations, not just the tools baseline that was reported: the four later migrations that create tables have the same exposure, and geenforce, measuringtools, printedparts and backups are the same defect waiting for a different site. WHAT THIS DOES NOT FIX. It makes a baseline idempotent, not a whole chain. A longer chain can still meet an ALTER whose column is already present - printedparts adding gagelabtag to a table create_all built at head is the case that showed up while testing. Guarding every op one at a time is the wrong answer to that; a database built from the models is already AT head and its chains want stamping rather than replaying, and there is no `flask plugin stamp` today. Left alone deliberately rather than half-built, and the new test is scoped to single-baseline plugins so it does not pretend otherwise.
67 lines
3.0 KiB
Python
67 lines
3.0 KiB
Python
"""backups plugin baseline (real create).
|
|
|
|
Built after the ADR-008 ownership cutover, so unlike the ten cutover plugins
|
|
whose 0001 is a stamp-only anchor, this baseline genuinely CREATES the table.
|
|
The core chain never knew about backuprevisions, so this per-plugin chain is its
|
|
sole authoritative creator.
|
|
|
|
Emits explicit Alembic ops rather than using the create_plugin_tables helper:
|
|
the helper builds a per-plugin MetaData filtered to the plugin's own tables, so
|
|
the foreign key to the core assets table cannot resolve at CreateTable-compile
|
|
time (NoReferencedTableError). Same shape autogenerate produces. Tables inherit
|
|
the connection's default charset, matching how the core chain creates its own.
|
|
"""
|
|
from alembic import op
|
|
|
|
from shopdb.plugins.alembic_template import (
|
|
create_index_if_missing,
|
|
create_table_if_missing,
|
|
)
|
|
import sqlalchemy as sa
|
|
|
|
|
|
# revision identifiers, used by Alembic.
|
|
revision = 'backups0001baseline'
|
|
down_revision = None
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade():
|
|
create_table_if_missing(
|
|
'backuprevisions',
|
|
sa.Column('backuprevisionid', sa.Integer(), nullable=False),
|
|
sa.Column('assetid', sa.Integer(), nullable=False),
|
|
sa.Column('backupkind', sa.String(length=50), nullable=False),
|
|
sa.Column('storagebackend', sa.String(length=20), nullable=False,
|
|
server_default='shopdb'),
|
|
sa.Column('contenthash', sa.String(length=64), nullable=False),
|
|
sa.Column('payloadjson', sa.Text(length=16777215), nullable=True),
|
|
sa.Column('sharepath', sa.String(length=500), nullable=True),
|
|
sa.Column('sourcefilename', sa.String(length=255), nullable=True),
|
|
sa.Column('bytesize', sa.Integer(), nullable=True),
|
|
sa.Column('sourcehostname', sa.String(length=255), nullable=True),
|
|
sa.Column('collectedat', sa.DateTime(), nullable=True),
|
|
sa.Column('createdat', sa.DateTime(), nullable=False),
|
|
sa.ForeignKeyConstraint(['assetid'], ['assets.assetid'],
|
|
ondelete='CASCADE'),
|
|
sa.PrimaryKeyConstraint('backuprevisionid'),
|
|
)
|
|
create_index_if_missing('ixbackuprevisionsassetid', 'backuprevisions', ['assetid'])
|
|
create_index_if_missing('ixbackuprevisionsbackupkind', 'backuprevisions',
|
|
['backupkind'])
|
|
create_index_if_missing('ixbackuprevisionscontenthash', 'backuprevisions',
|
|
['contenthash'])
|
|
# The dedup read path is "latest revision for this asset+kind", so the
|
|
# composite index is the one that actually gets used on every collector post.
|
|
create_index_if_missing('ixbackuprevisionsassetkind', 'backuprevisions',
|
|
['assetid', 'backupkind'])
|
|
|
|
|
|
def downgrade():
|
|
op.drop_index('ixbackuprevisionsassetkind', table_name='backuprevisions')
|
|
op.drop_index('ixbackuprevisionscontenthash', table_name='backuprevisions')
|
|
op.drop_index('ixbackuprevisionsbackupkind', table_name='backuprevisions')
|
|
op.drop_index('ixbackuprevisionsassetid', table_name='backuprevisions')
|
|
op.drop_table('backuprevisions')
|