shopdb-flask/.github/workflows/ci.yml

# CI for shopdb-flask on GitHub Actions.
#
# Mirrors the internal CI pipeline. Jobs on push + pull_request:
#   backend          - pytest (SQLite via TestingConfig, no DB service needed)
#   naming           - the CONTRIBUTING.md naming/style gate
#   gates            - proves those checks actually RAN rather than skipping
#   frontend         - vitest + Vue build
#   lean-build       - ADR-013: a per-site build carries only its plugins
#   api-contract     - the published spec matches the code that serves it
#
# The MySQL-8 migration job is NOT here; it runs on the internal CI server. See
# the note at the bottom of this file. It was listed here for a while after it
# moved, which reads as coverage this workflow does not have - do not re-add it
# to this list without re-adding the job to a runner that can host it.

name: CI

# Action versions are the Node 24 native releases (checkout@v5, setup-node@v5,
# setup-python@v6). The v4/v5 generation targets Node 20, which the runners now
# force onto Node 24 with a deprecation warning on every job - working today,
# a hard failure whenever GitHub drops the shim.
#
# Jobs run on the org's self-hosted "arc-runner-set" (enterprise
# ge-aerospace-runner-group, Linux). GitHub-hosted runners are blocked by the
# org IP allow list (hosted Azure runner IPs are not allow-listed -> checkout
# 403), so ubuntu-latest cannot be used here. arc-runner-set checks out from an
# internal allow-listed IP and, being Linux, still supports service containers.

on:
  push:
  pull_request:

# A second push supersedes the first: the older run answers a question nobody is
# asking any more, and it holds a self-hosted runner while doing it.
concurrency:
  group: ci-${{ github.ref }}
  cancel-in-progress: true

jobs:
  backend:
    runs-on: arc-runner-set
    steps:
      - uses: actions/checkout@v5
      - uses: actions/setup-python@v6
        with:
          python-version: '3.14'
          cache: pip
      - run: pip install -r requirements-dev.txt
      - run: python -m pytest -q

  naming:
    runs-on: arc-runner-set
    steps:
      - uses: actions/checkout@v5
      - run: bash scripts/check-naming-and-style.sh

  api-contract:
    # The published API contract has to match the code that serves it. These
    # gates catch a route that exists and is undocumented, a query parameter the
    # handler reads that the spec omits, and a public route nobody declared
    # public. They already work; until now nothing ran them except by hand, and
    # the spec had silently drifted by three operations.
    runs-on: arc-runner-set
    steps:
      - uses: actions/checkout@v5
      - uses: actions/setup-python@v6
        with:
          python-version: '3.14'
          cache: pip
      - run: pip install -r requirements-dev.txt
      - run: |
          python -m pytest -q \
            tests/test_api_inventory_parity.py \
            tests/test_openapi_spec.py \
            tests/test_openapi_examples.py \
            tests/test_core/test_public_read_surface.py
      - name: Seed the plugin registry the generator needs
        # gen_openapi.py refuses to run while a bundled plugin is disabled, and
        # instance/plugins.json is gitignored, so a clean checkout has none.
        # The step used to pass only because the pytest step above writes that
        # file at import time and never removes it - green by accident of step
        # order, and red the moment the steps are reordered, with an error
        # about disabled plugins that has nothing to do with the spec.
        run: |
          python - <<'PY'
          import datetime, json, pathlib
          names = sorted(d.name for d in pathlib.Path('plugins').iterdir()
                         if (d / 'manifest.json').is_file())
          now = datetime.datetime.now().isoformat()
          out = pathlib.Path('instance'); out.mkdir(exist_ok=True)
          (out / 'plugins.json').write_text(json.dumps({'plugins': {
              n: {'name': n, 'version': '1.0.0', 'installed_at': now,
                  'enabled': True, 'migrations_applied': [], 'config': {}}
              for n in names}}, indent=2))
          print('registry seeded with', len(names), 'plugins')
          PY

      - name: The spec must be regenerated, not just passing
        # --refresh is derived from the code, so if it changes anything the
        # committed spec was stale. Fail here rather than let a generated client
        # be built from a file that no longer describes the API.
        run: |
          python scripts/gen_openapi.py --refresh
          if ! git diff --quiet docs/openapi.json docs/api-inventory.json; then
            echo "docs/openapi.json is stale. Run:"
            echo "  python scripts/gen_openapi.py --refresh"
            git --no-pager diff --stat docs/openapi.json docs/api-inventory.json
            exit 1
          fi

  gates:
    # Prove the gates RAN. Several skip themselves when the file they read is
    # absent, which is correct in this checkout (docs/ becomes the wiki) and was
    # silently wrong here for months: the modules skipped, CI went green, and an
    # outside branch added nine routes documented nowhere and passed.
    #
    # A gate that stops running is worse than no gate, because nobody looks at
    # it again.
    runs-on: arc-runner-set
    steps:
      - uses: actions/checkout@v5
      - uses: actions/setup-python@v6
        with:
          python-version: '3.14'
          cache: pip
      - run: pip install -r requirements-dev.txt
      - run: bash scripts/check-gates-ran.sh

  frontend:
    runs-on: arc-runner-set
    defaults:
      run:
        working-directory: frontend
    steps:
      - uses: actions/checkout@v5
      - uses: actions/setup-node@v5
        with:
          node-version: '20'
          cache: npm
          cache-dependency-path: frontend/package-lock.json
      - run: npm ci
      - run: npx vitest run
      - run: npm run build

  lean-build:
    # ADR-013 Phase 5: prove a per-site build carries only its chosen plugins.
    # The profile is the WJ plugin set, so this job proves the build this branch
    # actually ships, not a two-plugin toy. The omission guarantee is what is
    # under test, so the assertions below name a component from EVERY omitted
    # plugin: a set that grows without its check growing is how a leak ships.
    #
    # Chosen (12): backups computers endpoints guides knowledgebase machines
    #              network notifications printers slides tools warranty
    # Omitted (5): employees geenforce measuringtools printedparts usb
    # 'applications' is manifest-less core and ships in every build (ADR-013).
    # endpoints hard-depends on computers, which is already chosen, so the
    # closure adds nothing - if that changes, resolve_plugin_closure.py pulls
    # the dependency in and the absence assertions below start failing, which is
    # the signal to update this list rather than to loosen the check.
    runs-on: arc-runner-set
    steps:
      - uses: actions/checkout@v5
      - uses: actions/setup-node@v5
        with:
          node-version: '20'
          cache: npm
          cache-dependency-path: frontend/package-lock.json
      - run: cd frontend && npm ci
      - name: Build lean site (WJ plugin set)
        run: |
          printf '%s' '{ "site": "ci-lean", "plugins": ["backups", "computers", "endpoints", "guides", "knowledgebase", "machines", "network", "notifications", "printers", "slides", "tools", "warranty"] }' \
            > /tmp/lean-profile.json
          bash scripts/build-site.sh /tmp/lean-profile.json /tmp/leansite
      - name: Assert omitted plugin code is absent, chosen present
        run: |
          assets=/tmp/leansite/frontend-dist/assets
          # One component per OMITTED plugin: employees, geenforce,
          # measuringtools, printedparts, usb.
          for code in EmployeeDirectory ManifestEditor MeasuringToolsList PartsKiosk USBLabelBatch; do
            if grep -rqoh "$code" "$assets"/*.js; then
              echo "FAIL: omitted-plugin code '$code' leaked into the lean bundle"
              exit 1
            fi
          done
          # One component per CHOSEN plugin, so a plugin silently dropped from
          # the bundle fails here instead of on the floor.
          for code in BackupHistory PCsList EndpointsList GuidesList \
                      KnowledgeBaseDetail MachineDetail NetworkDevicesList \
                      NotificationsList PrinterDetail SlideManager ToolsIndex \
                      WarrantiesList; do
            grep -rqoh "$code" "$assets"/*.js || {
              echo "FAIL: chosen-plugin code '$code' missing from the lean bundle"
              exit 1; }
          done
          # Core frontends (no manifest, e.g. applications) must ship in EVERY
          # build regardless of SITE_PLUGINS, or a lean site loses a core page.
          grep -rqoh "ApplicationsList" "$assets"/*.js || {
            echo "FAIL: core page 'ApplicationsList' missing from the lean bundle"
            exit 1; }
          for plugin in backups computers endpoints guides knowledgebase \
                        machines network notifications printers slides tools \
                        warranty; do
            test -d "/tmp/leansite/plugins/$plugin" || {
              echo "FAIL: chosen plugin '$plugin' missing from the backend tree"
              exit 1; }
          done
          for plugin in employees geenforce measuringtools printedparts usb; do
            test ! -d "/tmp/leansite/plugins/$plugin" || {
              echo "FAIL: omitted plugin '$plugin' staged into the backend tree"
              exit 1; }
          done
          echo "lean build verified: only chosen plugins present"

  # NOTE: the MySQL-8 migration/seed job (fresh `flask db upgrade` + every
  # plugin chain + strict-mode seeders on a real MySQL 8) runs on the internal
  # CI server, which supports service containers. The org's arc-runner-set is
  # Kubernetes/ARC without docker-in-docker, so GitHub Actions service
  # containers ("services: mysql") are unavailable here ("Job Container is
  # required"). That coverage stays on the internal CI rather than being
  # duplicated on GitHub.