Whether somebody with no account may see something was being answered one feature at a time: a securesend_allow_guests setting, an enable flag per kiosk, and very nearly a third for guides - each with its own settings page, its own vocabulary and its own hand-written branch inside a route. Every one of them answered a permissions question, and this app already administers permissions per role. So a caller with no token is not nobody: they hold the seeded `guest` role. require_permission consults it when there is no identity, which is the entire mechanism. The role is seeded holding NOTHING, so an upgrade opens no door; a site opens one by ticking a box in the same grid it uses for every other role, and closes it the same way. Revocation is read on every request rather than cached, because taking guest access away is what somebody does the moment they realise what they opened, and it has to bite immediately. The redundant @jwt_required() above require_permission is gone from 184 routes. It was belt-and-braces before; now it is actively wrong, because it refuses a request with no token before the permission check can have an opinion, so a grant would appear to do nothing. What a guest may hold is bounded. Any .view or .read permission is grantable. A WRITE has to be blessed by whoever owns it, through the new get_guest_grantable_permissions hook (contract 0.21.0), and Secure Send is the only case that exists: sending a password to a vendor is the one write this product means to offer somebody who never signs in. Everything else is refused by the API and greyed out in the grid rather than warned about - a checkbox that quietly makes deleting an asset anonymous is not a warning anybody reads twice. A guest write records no creator: the trail says when and from where, never who, and that is the reason for the bar. GE-Enforce and Slides gained read permissions so they can be opened to guests without handing out the manage right. Their read routes accept either through require_any_permission, so nothing an existing manager could reach has moved. The navigation endpoint now returns only what the caller can actually reach. Without that a signed-out visitor gets a sidebar of the whole app where every link bounces off the login page, which reads as a broken site rather than as a closed door. A nav item may name several permissions; holding any one is enough, which is what GE-Enforce and Slides need now that a viewer and a manager hold different strings. Two things this found on the way: current_user is a LocalProxy, so `current_user is None` is False for a request with nobody behind it - harmless under a required JWT, an AttributeError the moment verification became optional. And an image pasted into a guide before its first save was never attached to it, so it was visible to editors and invisible to every reader; saving now attaches it, and `flask guides fix-images` repairs what is stored. The guides guest setting written earlier today is gone. Granting guides.view to the guest role replaces it, which is the point.
323 lines
11 KiB
Python
323 lines
11 KiB
Python
"""Public API namespace exposed to plugins.
|
|
|
|
Plugin authors at sister sites import from this module. The contract is
|
|
locked in ADR-001 and versioned per ADR-002. Helpers added here become
|
|
part of the platform contract; bumps follow ADR-002 rules.
|
|
|
|
Currently exposed:
|
|
- audit_log: record an audit log entry with consistent schema
|
|
- resolve_asset_position: compute an asset's resolved map position
|
|
|
|
Setting helpers are exposed via BasePlugin instance methods
|
|
(plugin.get_setting, plugin.set_setting), not from this namespace.
|
|
"""
|
|
|
|
from typing import Any, Dict, Optional
|
|
|
|
# -- Plugin contract surface (ADR-001, versioned per ADR-002) ----------------
|
|
# Everything a plugin is allowed to import from the core lives here. Plugins
|
|
# import these from `shopdb.api`, never from internal paths like
|
|
# `shopdb.core.models.*` or `shopdb.extensions`. The contract test
|
|
# (tests/test_plugin_contract.py) enforces this. Adding a name here is an
|
|
# additive (minor) contract change; removing one is breaking (major).
|
|
|
|
# Infrastructure
|
|
from shopdb.extensions import db, cache
|
|
|
|
# Model base classes for declaring plugin tables
|
|
from shopdb.core.models.base import BaseModel, AuditMixin
|
|
|
|
# Core domain models plugins legitimately reference (the asset contract)
|
|
from shopdb.core.models import (
|
|
Asset,
|
|
AssetType,
|
|
AssetStatus,
|
|
Vendor,
|
|
Model,
|
|
Communication,
|
|
CommunicationType,
|
|
Location,
|
|
Setting,
|
|
AuditLog,
|
|
Application,
|
|
AppVersion,
|
|
OperatingSystem,
|
|
AssetRelationship,
|
|
RelationshipType,
|
|
User,
|
|
Role,
|
|
SupportTeam,
|
|
)
|
|
# Display-role mapping (which kiosk shows which surface). On the surface
|
|
# because a plugin reporting on displays has no other way to name what a
|
|
# display IS - the role lives in core, not in any plugin.
|
|
from shopdb.core.models.dashboarddefault import (
|
|
DashboardDefault,
|
|
DISPLAY_ROLES,
|
|
DISPLAY_ROLE_PATHS,
|
|
normalize_display_role,
|
|
)
|
|
|
|
# Response + pagination helpers for plugin API blueprints
|
|
from shopdb.utils.responses import (
|
|
success_response,
|
|
error_response,
|
|
paginated_response,
|
|
ErrorCodes,
|
|
)
|
|
from shopdb.utils.pagination import get_pagination_params, paginate_query
|
|
|
|
# Authorization decorators for gating plugin write routes
|
|
from shopdb.utils.authz import require_permission, require_any_permission, require_role
|
|
|
|
# Service-token authorization for unattended plugin endpoints (collector,
|
|
# GE-Enforce fetch, ...): checks a scoped managed token without exposing token
|
|
# internals.
|
|
from shopdb.utils.apitoken_auth import (
|
|
service_token_authorized, authorized_service_token,
|
|
)
|
|
|
|
# Serving an uploaded file safely. A plugin that serves user-supplied bytes must
|
|
# not have to remember the headers that keep an SVG or an HTML file from running
|
|
# as script in this origin - see shopdb/utils/uploads.py.
|
|
from shopdb.utils.uploads import send_upload, harden_upload_response
|
|
|
|
# Import-mode helpers: preserve legacy timestamps during a bulk data import
|
|
from shopdb.utils.import_mode import (
|
|
apply_import_timestamps,
|
|
import_mode_active,
|
|
parse_import_datetime,
|
|
)
|
|
|
|
# Dualpath single-machine collapse (a dual-bay pair is one physical machine)
|
|
from shopdb.core.services.dualpath import (
|
|
resolve_dualpath_pairs,
|
|
dualpath_single_machine_enabled,
|
|
)
|
|
|
|
# Legacy employee directory lookup (read-only) used by notifications
|
|
from shopdb.utils.employee_db import employee_connection
|
|
from shopdb.utils.mailer import send_email, send_alert, send_webhook
|
|
|
|
# CMMC USB check-in/out database (read-write) used by the usb plugin
|
|
from shopdb.utils.cmmc_usb_db import cmmc_usb_connection
|
|
|
|
|
|
def audit_log(
|
|
action: str,
|
|
entitytype: str,
|
|
entityid: int = None,
|
|
entityname: str = None,
|
|
changes: Dict = None,
|
|
details: Dict = None,
|
|
) -> AuditLog:
|
|
"""Record an audit log entry with the framework's standard schema.
|
|
|
|
Plugins call this to record state changes on their own assets in a
|
|
way that is consistent with core auditing. The function delegates to
|
|
AuditLog.log() which already captures the current user, IP address,
|
|
and user agent from the Flask request context.
|
|
|
|
Args:
|
|
action: Action verb in past tense ('created', 'updated', 'deleted')
|
|
entitytype: Class name of the entity affected ('Computer', 'Printer')
|
|
entityid: Primary key of the entity
|
|
entityname: Human-readable identifier (hostname, asset number)
|
|
changes: Dict with 'before' and 'after' snapshots for updates
|
|
details: Arbitrary additional context
|
|
|
|
Returns:
|
|
The created AuditLog instance, already committed to the DB.
|
|
"""
|
|
return AuditLog.log(
|
|
action=action,
|
|
entitytype=entitytype,
|
|
entityid=entityid,
|
|
entityname=entityname,
|
|
changes=changes,
|
|
details=details,
|
|
)
|
|
|
|
|
|
# Cap how deep the relationship-walk traverses before giving up. ADR-001
|
|
# specifies a max walk depth of 3 to bound the work per request, with a
|
|
# visited-set guarding against cycles. Past this depth the walk treats the
|
|
# next hop as if it had no position to contribute.
|
|
_POSITION_WALK_MAX_DEPTH = 3
|
|
|
|
# Relationship type names whose edges are eligible for the inheritance walk
|
|
# when inheritsposition is true on the edge. Ordered by priority per
|
|
# ADR-001 ("partof first, then controls"). Edges of other types are never
|
|
# followed even if inheritsposition is true.
|
|
_INHERITABLE_TYPES = ('partof', 'controls')
|
|
|
|
|
|
def _walk_related_for_position(asset, visited, depth):
|
|
"""Recursive helper for resolve_asset_position relationship walk. Returns
|
|
a (mapx, mapy) tuple from the first related asset whose position
|
|
resolves, or None. Visited tracks assetids already explored to break
|
|
cycles."""
|
|
if depth >= _POSITION_WALK_MAX_DEPTH:
|
|
return None
|
|
aid = getattr(asset, 'assetid', None)
|
|
if aid is None or aid in visited:
|
|
return None
|
|
visited.add(aid)
|
|
|
|
edges = []
|
|
for rel in list(getattr(asset, 'outgoing_relationships', []) or []):
|
|
edges.append((rel, getattr(rel, 'targetasset', None)))
|
|
for rel in list(getattr(asset, 'incoming_relationships', []) or []):
|
|
edges.append((rel, getattr(rel, 'sourceasset', None)))
|
|
|
|
def _priority(edge):
|
|
rel = edge[0]
|
|
rtype = getattr(rel, 'relationshiptype', None)
|
|
type_name = getattr(rtype, 'relationshiptype', '') if rtype else ''
|
|
try:
|
|
return _INHERITABLE_TYPES.index(type_name)
|
|
except ValueError:
|
|
return len(_INHERITABLE_TYPES)
|
|
|
|
edges.sort(key=_priority)
|
|
|
|
for rel, neighbor in edges:
|
|
if neighbor is None:
|
|
continue
|
|
if not getattr(rel, 'inheritsposition', False):
|
|
continue
|
|
if not getattr(rel, 'isactive', True):
|
|
continue
|
|
rtype = getattr(rel, 'relationshiptype', None)
|
|
type_name = getattr(rtype, 'relationshiptype', '') if rtype else ''
|
|
if type_name not in _INHERITABLE_TYPES:
|
|
continue
|
|
|
|
n_mapx = getattr(neighbor, 'mapx', None)
|
|
n_mapy = getattr(neighbor, 'mapy', None)
|
|
if n_mapx is not None and n_mapy is not None:
|
|
# The neighbour's LEVEL travels with its coordinates. Returning the
|
|
# pair alone would leave the caller drawing a machine's position on
|
|
# whatever level the PC that borrowed it happens to claim.
|
|
return (n_mapx, n_mapy, getattr(neighbor, 'levelid', None))
|
|
|
|
recursed = _walk_related_for_position(neighbor, visited, depth + 1)
|
|
if recursed is not None:
|
|
return recursed
|
|
return None
|
|
|
|
|
|
def resolve_asset_position(asset) -> Optional[Dict[str, Any]]:
|
|
"""Compute the resolved map position for an asset.
|
|
|
|
Per ADR-001, position resolution follows this priority chain:
|
|
1. Asset-specific override (asset.mapx, asset.mapy)
|
|
2. Walk relationships where inheritsposition is true on edges of type
|
|
partof or controls (partof first), depth-limited and cycle-safe
|
|
3. Asset's location coords (asset.location.mapx, .mapy)
|
|
4. None (asset is unplaced, rendered in a tray)
|
|
|
|
Returns a dict {'mapx', 'mapy', 'levelid', 'positionsource'} where
|
|
positionsource is one of 'self', 'related', 'location'. Returns None when no
|
|
priority yields coordinates.
|
|
|
|
LEVELID COMES FROM WHICHEVER SOURCE SUPPLIED THE COORDINATES, not from the
|
|
asset (ADR-017). A PC with no position of its own that inherits from the
|
|
machine it controls is at the MACHINE's coordinates on the MACHINE's level;
|
|
using the PC's own level - which may be null, or may be a different building
|
|
entirely - would draw those coordinates on the wrong drawing, and the result
|
|
looks entirely reasonable.
|
|
"""
|
|
mapx = getattr(asset, 'mapx', None)
|
|
mapy = getattr(asset, 'mapy', None)
|
|
if mapx is not None and mapy is not None:
|
|
return {'mapx': mapx, 'mapy': mapy,
|
|
'levelid': getattr(asset, 'levelid', None),
|
|
'positionsource': 'self'}
|
|
|
|
related = _walk_related_for_position(asset, set(), 0)
|
|
if related is not None:
|
|
return {'mapx': related[0], 'mapy': related[1], 'levelid': related[2],
|
|
'positionsource': 'related'}
|
|
|
|
location = getattr(asset, 'location', None)
|
|
if location is not None:
|
|
loc_mapx = getattr(location, 'mapx', None)
|
|
loc_mapy = getattr(location, 'mapy', None)
|
|
if loc_mapx is not None and loc_mapy is not None:
|
|
return {
|
|
'mapx': loc_mapx,
|
|
'mapy': loc_mapy,
|
|
'levelid': getattr(location, 'levelid', None),
|
|
'positionsource': 'location',
|
|
}
|
|
|
|
return None
|
|
|
|
|
|
__all__ = [
|
|
# Helpers
|
|
'audit_log',
|
|
'resolve_asset_position',
|
|
'resolve_dualpath_pairs',
|
|
'dualpath_single_machine_enabled',
|
|
# Infrastructure
|
|
'db',
|
|
'cache',
|
|
# Model bases
|
|
'BaseModel',
|
|
'AuditMixin',
|
|
# Core models
|
|
'Asset',
|
|
'AssetType',
|
|
'AssetStatus',
|
|
'Vendor',
|
|
'Model',
|
|
'Communication',
|
|
'CommunicationType',
|
|
'Location',
|
|
'Setting',
|
|
'AuditLog',
|
|
'Application',
|
|
'AppVersion',
|
|
'OperatingSystem',
|
|
'AssetRelationship',
|
|
'RelationshipType',
|
|
# Display roles. The role vocabulary is the kiosk's own, so a plugin that
|
|
# reads a reported display type resolves it the same way core does.
|
|
'DashboardDefault',
|
|
'DISPLAY_ROLES',
|
|
'DISPLAY_ROLE_PATHS',
|
|
'normalize_display_role',
|
|
# Response + pagination helpers
|
|
'success_response',
|
|
'error_response',
|
|
'paginated_response',
|
|
'ErrorCodes',
|
|
'get_pagination_params',
|
|
'paginate_query',
|
|
# Authorization decorators
|
|
'require_permission',
|
|
'require_any_permission',
|
|
'require_role',
|
|
'service_token_authorized',
|
|
'authorized_service_token',
|
|
'SupportTeam',
|
|
# Serving uploads
|
|
'send_upload',
|
|
'harden_upload_response',
|
|
# Import-mode helpers
|
|
'apply_import_timestamps',
|
|
'import_mode_active',
|
|
'parse_import_datetime',
|
|
# Legacy employee directory
|
|
'employee_connection',
|
|
'send_email',
|
|
'send_alert',
|
|
'send_webhook',
|
|
'User',
|
|
'Role',
|
|
# CMMC USB check-in/out database
|
|
'cmmc_usb_connection',
|
|
]
|