6e36df841e
Ports 37 of Benjamin Baker's commits from the wilm branch, mirrored from the
corporate GitHub at 7905917c. wilm rides the publication lineage and shares no
ancestor with wj, so this is a filtered tree patch rather than a merge:
94 files, and every path the publication export strips (docs/, tools/, mcp/,
CLAUDE.md, start-*.sh, .gitea/, the three excluded tests) is held back, because
a raw diff would delete each of them from this tree.
What comes across:
* Endpoint telemetry, phase 2. Physical disk health from two sources, NIC link
state, boot type, Defender health, processor/memory/chassis inventory, the
listening TCP set, mapped network drives and Windows Update history. Five
additive migrations, 0012 through 0016, off the 0011 head.
* Mapped drives are collected by a probe running in the interactive user's
session, because they do not exist in the agent's session 0. Two Windows
sources can disagree about one drive and the worse status wins, so a
half-broken share is never rendered as healthy.
* Windows events are reported once each, keyed on the channel's own record id,
instead of being re-sent whenever a report overlapped the last one.
* PC Detail rework: Details cards flow, the hand-written Network card gives way
to a full address history, Storage and disk health merge into one card with
two sections, Operator Reports and Corporate Tools get their own tabs.
* An opt-in restic backup overlay with a third container, restore gated on the
dump's own data revision rather than the code head, and backup/restore history.
* The agent's version is read from the binary's PE version rather than trusted
from the csproj, and the Fleet view gains an Agent Version column.
* The enqueue route now asks caller_holds instead of the owner's permissions,
which closes the scoped-token elevation on run_script, update_app and
system_restart.
Held back deliberately:
* agent/installer/install-shopdbagent.ps1 stays deleted, as upstream deleted it.
The installer that reaches a bay is generated by _install_script() in
plugins/endpoints/api/siteagent.py; the standalone script had stopped being
shipped and was collecting fixes no endpoint ever ran.
* The .gitignore hunk adding docs/*.md. Correct on the publication lineage,
where docs/ becomes the wiki and its absence is how the gates detect a
published checkout. Here it would silently ignore every new doc.
* Their deletions of docs/DEV-BUILD-TEST.md and docs/PLUGIN-HOOKS.md. Upstream
those were stubs; here PLUGIN-HOOKS.md is the 31KB document CLAUDE.md points
readers at.
* Five zero-byte files committed by an accidental `git add -A`, a run log from
the author's own machine, and docs/notes/, which is working scratch that says
so in its own header and belongs in devnotes/ on this side.
Carried with the import so it lands green: the 17 new routes are described in
docs/api-inventory.json with the spec and project map regenerated, and two new
frontend specs read fixtures through fileURLToPath(URL) which node rejects under
jsdom's own URL global.
Suite 2591 passed / 9 skipped; frontend 391 passed; naming, style and doc gates
clean.
Scope: product
50 lines
1.9 KiB
Python
50 lines
1.9 KiB
Python
"""NIC link label: an unknown link must never read as a working one.
|
|
|
|
Link speed and duplex are paired onto the interface rows from a second WMI
|
|
class, so three states are possible: read successfully, unreadable, and
|
|
disconnected. Verified on a live box that a DISCONNECTED adapter returns empty
|
|
Speed and FullDuplex - two of four NICs on the test machine were in that state.
|
|
|
|
That is the trap these tests pin. Defaulting an absent speed to 0 or an absent
|
|
duplex to False would report every unplugged NIC as half duplex, which is the
|
|
exact signature of the cable/port fault this field exists to catch. A column
|
|
that cries fault on every disconnected NIC is a column nobody reads.
|
|
"""
|
|
|
|
from plugins.endpoints.api.routes import _link_label
|
|
|
|
|
|
def test_a_gigabit_full_duplex_link_is_not_annotated():
|
|
"""The normal case should be quiet so the abnormal case stands out."""
|
|
assert _link_label(1000000000, True) == '1 Gb'
|
|
|
|
|
|
def test_half_duplex_is_called_out_because_it_is_the_actionable_case():
|
|
assert _link_label(100000000, False) == '100 Mb half duplex'
|
|
|
|
|
|
def test_a_disconnected_adapter_reads_as_unknown_not_half_duplex():
|
|
"""The live-box case: disconnected NICs return empty speed and duplex.
|
|
|
|
Reading this as half duplex would flag every unplugged NIC as a fault.
|
|
"""
|
|
assert _link_label(None, None) == '-'
|
|
|
|
|
|
def test_an_unreadable_duplex_on_a_live_link_is_not_assumed_half():
|
|
"""Speed known, duplex not. Unknown duplex must not render as a fault."""
|
|
assert _link_label(10000000000, None) == '10 Gb'
|
|
|
|
|
|
def test_zero_speed_is_unknown_rather_than_a_zero_speed_link():
|
|
assert _link_label(0, True) == '-'
|
|
|
|
|
|
def test_sub_gigabit_speeds_stay_in_megabits():
|
|
assert _link_label(10000000, True) == '10 Mb'
|
|
|
|
|
|
def test_speeds_do_not_render_trailing_zeros():
|
|
"""2.5Gb NICs are common now; the label should not read '2.5000 Gb'."""
|
|
assert _link_label(2500000000, True) == '2.5 Gb'
|