Plugins were reaching into internal core paths (shopdb.core.models.*, shopdb.extensions, shopdb.utils.*), coupling them to core's file layout and violating the ADR-001 contract. Consolidate onto one versioned surface. - shopdb.api: expand from 2 helpers to the full plugin import surface - db, cache; BaseModel, AuditMixin; core models (Asset, AssetType, AssetStatus, Vendor, Model, Communication, CommunicationType, Location, Setting, AuditLog, Application, AppVersion, OperatingSystem); response + pagination helpers; employee_connection. Documented in PLUGIN-HOOKS.md. - Migrate all 22 plugin source files to import only from shopdb.api (plus shopdb.plugins.base for the ABC). - Drop the printers plugin's legacy MachineType dependency: remove _ensure_legacy_machine_types and the seed_supplies machinetypeid lookup (Model.machinetypeid is nullable; printers carry type via PrinterType). - Guard test test_plugins_only_import_contract_surface scans plugin source and fails on any core import outside shopdb.api / shopdb.plugins.base. - Scaffold templates updated so generated plugins are contract-pure. - Bump __contract_version__ 0.2.0 -> 0.3.0 (additive surface expansion; manifests pin <1.0.0 so they still satisfy). 145 tests pass, naming/style green, app factory boots all 6 plugins. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
121 lines
3.2 KiB
Python
121 lines
3.2 KiB
Python
"""Network device plugin models."""
|
|
|
|
from shopdb.api import db, BaseModel
|
|
|
|
|
|
class NetworkDeviceType(BaseModel):
|
|
"""
|
|
Network device type classification.
|
|
|
|
Examples: Switch, Router, Access Point, Camera, IDF, Firewall, etc.
|
|
"""
|
|
__tablename__ = 'networkdevicetypes'
|
|
|
|
networkdevicetypeid = db.Column(db.Integer, primary_key=True)
|
|
networkdevicetype = db.Column(db.String(100), unique=True, nullable=False)
|
|
description = db.Column(db.Text)
|
|
icon = db.Column(db.String(50), comment='Icon name for UI')
|
|
|
|
def __repr__(self):
|
|
return f"<NetworkDeviceType {self.networkdevicetype}>"
|
|
|
|
|
|
class NetworkDevice(BaseModel):
|
|
"""
|
|
Network device-specific extension data.
|
|
|
|
Links to core Asset table via assetid.
|
|
Stores network device-specific fields like hostname, firmware, ports, etc.
|
|
"""
|
|
__tablename__ = 'networkdevices'
|
|
|
|
networkdeviceid = db.Column(db.Integer, primary_key=True)
|
|
|
|
# Link to core asset
|
|
assetid = db.Column(
|
|
db.Integer,
|
|
db.ForeignKey('assets.assetid', ondelete='CASCADE'),
|
|
unique=True,
|
|
nullable=False,
|
|
index=True
|
|
)
|
|
|
|
# Network device classification
|
|
networkdevicetypeid = db.Column(
|
|
db.Integer,
|
|
db.ForeignKey('networkdevicetypes.networkdevicetypeid'),
|
|
nullable=True
|
|
)
|
|
|
|
# Vendor
|
|
vendorid = db.Column(
|
|
db.Integer,
|
|
db.ForeignKey('vendors.vendorid'),
|
|
nullable=True
|
|
)
|
|
|
|
# Network identity
|
|
hostname = db.Column(
|
|
db.String(100),
|
|
index=True,
|
|
comment='Network hostname'
|
|
)
|
|
|
|
# Firmware/software version
|
|
firmwareversion = db.Column(db.String(100), nullable=True)
|
|
|
|
# Physical characteristics
|
|
portcount = db.Column(
|
|
db.Integer,
|
|
nullable=True,
|
|
comment='Number of ports (for switches)'
|
|
)
|
|
|
|
# Features
|
|
ispoe = db.Column(
|
|
db.Boolean,
|
|
default=False,
|
|
comment='Power over Ethernet capable'
|
|
)
|
|
ismanaged = db.Column(
|
|
db.Boolean,
|
|
default=False,
|
|
comment='Managed device (SNMP, web interface, etc.)'
|
|
)
|
|
|
|
# For IDF/closet locations
|
|
rackunit = db.Column(
|
|
db.String(20),
|
|
nullable=True,
|
|
comment='Rack unit position (e.g., U1, U5)'
|
|
)
|
|
|
|
# Relationships
|
|
asset = db.relationship(
|
|
'Asset',
|
|
backref=db.backref('network_device', uselist=False, lazy='joined')
|
|
)
|
|
networkdevicetype = db.relationship('NetworkDeviceType', backref='networkdevices')
|
|
vendor = db.relationship('Vendor', backref='network_devices')
|
|
|
|
__table_args__ = (
|
|
db.Index('idx_netdev_type', 'networkdevicetypeid'),
|
|
db.Index('idx_netdev_hostname', 'hostname'),
|
|
db.Index('idx_netdev_vendor', 'vendorid'),
|
|
)
|
|
|
|
def __repr__(self):
|
|
return f"<NetworkDevice {self.hostname or self.assetid}>"
|
|
|
|
def to_dict(self):
|
|
"""Convert to dictionary with related names."""
|
|
result = super().to_dict()
|
|
|
|
# Add related object names
|
|
if self.networkdevicetype:
|
|
result['networkdevicetypename'] = self.networkdevicetype.networkdevicetype
|
|
if self.vendor:
|
|
result['vendorname'] = self.vendor.vendor
|
|
|
|
return result
|