534f179ee6
main was 16 days and 259 commits behind the line the product is actually built on, at contract 0.30.0 against 0.35.0, with no per-PC credential code at all. It was neither current nor curated - just stale. This brings it forward and, at the same time, makes it mean something: main is what a receiving site installs, and nothing else. WHAT IT CARRIES. Twelve plugins - backups, computers, endpoints, guides, knowledgebase, machines, network, notifications, printers, slides, tools, warranty - plus applications, which is manifest-less core and always ships. The only manifest dependency inside that set is endpoints on computers, and both are in it, so the closure is self-contained. WHAT IT DOES NOT. employees, geenforce, measuringtools, printedparts and usb stay on the site line. So do the Windows installer tree, the VM rehearsal helpers, the agent tooling config, one site's data loader, the internal audit and findings records, and the planner spreadsheet. 1,135 tracked files against 1,438. A REMOVAL THAT BREAKS THE APP IS NOT A REMOVAL, and two nearly shipped: deploy/site-profile-universal.json still named all seventeen plugins. It is the file docs/DEPLOY.md tells a site to provision from, so a fresh install would have failed at `flask plugin apply-profile` with PluginError - the first thing a receiving site does, broken by the branch meant to serve them. It now names the twelve that exist, and its comment says the two must agree. agent/ was never refreshed. Whoever populated this branch copied shopdb/, plugins/, frontend/ and tests/ from the site line and left the agent tree at its September state: 22 C# and PowerShell sources missing, including AgentCredentials, EnrollmentService, AgentHttpFactory and the fleet-alert client, plus one file the site line had deleted still present. The old tree is internally consistent, so it compiles, and nothing in CI builds it - every gate was green over a server that speaks enrollment and per-PC credentials to a bundled agent source that cannot. Resynced whole. DECISIONS THIS ENCODES, rather than defers: - The plugin-authoring lab builds printedparts, whose manifest depends on employees, so it could not stay. The lab remains on the site line and main ships no build-along tutorial. That is a real loss for an adopting developer and is recorded here rather than discovered later. - Recognition, Training and Recertification notifications are no longer seeded. Each splits one notification into a card per employee and renders a photo, which needs a plugin this branch does not bundle. Seeding them would offer an author a type that cannot resolve anybody. A site that installs employees gets them from that plugin's own seed. - Windows/IIS is documented as the legacy path throughout, and the README leads with Docker, because that is what a receiving site gets. The API description is regenerated for THIS branch - 347 paths and 483 operations, down from 415 and 573 - so the published contract describes what is here rather than what the site line serves. docs/CONFIG.md lost the two measuring-tool label keys the code no longer declares, which two lanes had decided opposite ways. Suite: 3124 passed, 6 skipped. Naming and style gates pass. The docs gates run rather than skip, and every index line count is derived from the file it names.
51 lines
2.1 KiB
Python
51 lines
2.1 KiB
Python
"""No test file may sit where pytest will not collect it.
|
|
|
|
pytest.ini sets `testpaths = tests`, so a test file anywhere else is never run
|
|
by `pytest` and never run in CI. It still passes review, still gets maintained,
|
|
and still reports nothing.
|
|
|
|
That is not hypothetical. plugins/endpoints/tests/test_plugin.py arrived with a
|
|
merge carrying 55 lines of delivery assertions and was collected ZERO times; run
|
|
directly, five of its tests failed. A second plugin had one sitting uncollected
|
|
for longer. Both are now under tests/.
|
|
|
|
The failure mode is the worst kind: the suite is green, the coverage is imaginary,
|
|
and the authorisation on a route can be deleted without anything going red.
|
|
"""
|
|
from pathlib import Path
|
|
|
|
REPO = Path(__file__).resolve().parents[1]
|
|
|
|
# Where pytest actually looks (pytest.ini: testpaths = tests).
|
|
COLLECTED = REPO / 'tests'
|
|
|
|
# Trees that legitimately hold test-shaped files pytest must not collect:
|
|
# vendored dependencies, build output, and the frontend's own vitest specs.
|
|
IGNORED = ('node_modules', 'venv', '.git', 'dist', '__pycache__',
|
|
'site-packages', '.plugins-staged', 'frontend')
|
|
|
|
# Whole-tree copies a build stages somewhere under the repo root. Build output,
|
|
# not source, so a test file inside one is not a stray. Empty today; add a path
|
|
# here rather than loosening IGNORED above, which matches on any path part.
|
|
IGNORED_TREES = ()
|
|
|
|
|
|
def test_every_test_file_lives_where_pytest_looks():
|
|
stray = []
|
|
for path in REPO.rglob('test_*.py'):
|
|
if any(part in IGNORED for part in path.parts):
|
|
continue
|
|
relative = path.relative_to(REPO).as_posix()
|
|
if any(relative.startswith(tree) for tree in IGNORED_TREES):
|
|
continue
|
|
if COLLECTED in path.parents:
|
|
continue
|
|
stray.append(path.relative_to(REPO))
|
|
|
|
assert not stray, (
|
|
'These test files are never collected, because pytest.ini limits\n'
|
|
'collection to tests/. They pass review and report nothing:\n '
|
|
+ '\n '.join(str(p) for p in sorted(stray))
|
|
+ '\n\nMove them under tests/ (tests/test_plugins/ for plugin tests).'
|
|
)
|