534f179ee6
main was 16 days and 259 commits behind the line the product is actually built on, at contract 0.30.0 against 0.35.0, with no per-PC credential code at all. It was neither current nor curated - just stale. This brings it forward and, at the same time, makes it mean something: main is what a receiving site installs, and nothing else. WHAT IT CARRIES. Twelve plugins - backups, computers, endpoints, guides, knowledgebase, machines, network, notifications, printers, slides, tools, warranty - plus applications, which is manifest-less core and always ships. The only manifest dependency inside that set is endpoints on computers, and both are in it, so the closure is self-contained. WHAT IT DOES NOT. employees, geenforce, measuringtools, printedparts and usb stay on the site line. So do the Windows installer tree, the VM rehearsal helpers, the agent tooling config, one site's data loader, the internal audit and findings records, and the planner spreadsheet. 1,135 tracked files against 1,438. A REMOVAL THAT BREAKS THE APP IS NOT A REMOVAL, and two nearly shipped: deploy/site-profile-universal.json still named all seventeen plugins. It is the file docs/DEPLOY.md tells a site to provision from, so a fresh install would have failed at `flask plugin apply-profile` with PluginError - the first thing a receiving site does, broken by the branch meant to serve them. It now names the twelve that exist, and its comment says the two must agree. agent/ was never refreshed. Whoever populated this branch copied shopdb/, plugins/, frontend/ and tests/ from the site line and left the agent tree at its September state: 22 C# and PowerShell sources missing, including AgentCredentials, EnrollmentService, AgentHttpFactory and the fleet-alert client, plus one file the site line had deleted still present. The old tree is internally consistent, so it compiles, and nothing in CI builds it - every gate was green over a server that speaks enrollment and per-PC credentials to a bundled agent source that cannot. Resynced whole. DECISIONS THIS ENCODES, rather than defers: - The plugin-authoring lab builds printedparts, whose manifest depends on employees, so it could not stay. The lab remains on the site line and main ships no build-along tutorial. That is a real loss for an adopting developer and is recorded here rather than discovered later. - Recognition, Training and Recertification notifications are no longer seeded. Each splits one notification into a card per employee and renders a photo, which needs a plugin this branch does not bundle. Seeding them would offer an author a type that cannot resolve anybody. A site that installs employees gets them from that plugin's own seed. - Windows/IIS is documented as the legacy path throughout, and the README leads with Docker, because that is what a receiving site gets. The API description is regenerated for THIS branch - 347 paths and 483 operations, down from 415 and 573 - so the published contract describes what is here rather than what the site line serves. docs/CONFIG.md lost the two measuring-tool label keys the code no longer declares, which two lanes had decided opposite ways. Suite: 3124 passed, 6 skipped. Naming and style gates pass. The docs gates run rather than skip, and every index line count is derived from the file it names.
88 lines
2.9 KiB
Python
88 lines
2.9 KiB
Python
"""Scope evaluation for the All PCs policy target.
|
|
|
|
These are pure unit tests: policyscope has no db or Flask dependency, so the
|
|
whole grammar can be exercised with plain dicts. build_endpoint_context needs
|
|
only duck-typed stand-ins for a Computer row.
|
|
"""
|
|
import pytest
|
|
|
|
from plugins.computers.services.policyresolver import build_endpoint_context
|
|
from plugins.computers.services.policyscope import (
|
|
ScopeError,
|
|
evaluate_scope,
|
|
validate_scope,
|
|
)
|
|
|
|
|
|
class FakeComputerType:
|
|
def __init__(self, icon):
|
|
self.icon = icon
|
|
|
|
|
|
class FakeComputer:
|
|
"""Minimal stand-in for a Computer row, no db required."""
|
|
|
|
def __init__(self, computertypeid=None, icon=None, installedapps=()):
|
|
self.computertypeid = computertypeid
|
|
self.computertype = FakeComputerType(icon) if icon is not None else None
|
|
self.installedapps = installedapps
|
|
|
|
|
|
def test_allpcs_is_a_valid_scope_node():
|
|
validate_scope({'type': 'allpcs'})
|
|
|
|
|
|
def test_allpcs_matches_an_ordinary_pc():
|
|
context = {'computertypeid': 1, 'appids': set(), 'isserver': False}
|
|
assert evaluate_scope({'type': 'allpcs'}, context) is True
|
|
|
|
|
|
def test_allpcs_does_not_match_a_server():
|
|
"""The whole point of the option: servers are excluded."""
|
|
context = {'computertypeid': 4, 'appids': set(), 'isserver': True}
|
|
assert evaluate_scope({'type': 'allpcs'}, context) is False
|
|
|
|
|
|
def test_allpcs_matches_an_endpoint_with_no_type_designation():
|
|
"""An untyped endpoint is an ordinary PC until something says otherwise."""
|
|
context = {'computertypeid': None, 'appids': set()}
|
|
assert evaluate_scope({'type': 'allpcs'}, context) is True
|
|
|
|
|
|
def test_true_still_matches_a_server():
|
|
"""'true' keeps its old meaning so existing policies do not silently shift."""
|
|
context = {'computertypeid': 4, 'appids': set(), 'isserver': True}
|
|
assert evaluate_scope({'type': 'true'}, context) is True
|
|
|
|
|
|
def test_allpcs_composes_with_other_nodes():
|
|
"""AND of allpcs and an app still excludes a server running that app."""
|
|
scope = {
|
|
'type': 'and',
|
|
'nodes': [{'type': 'allpcs'}, {'type': 'app', 'id': 7}],
|
|
}
|
|
pc = {'computertypeid': 1, 'appids': {7}, 'isserver': False}
|
|
server = {'computertypeid': 4, 'appids': {7}, 'isserver': True}
|
|
assert evaluate_scope(scope, pc) is True
|
|
assert evaluate_scope(scope, server) is False
|
|
|
|
|
|
def test_context_marks_a_server_icon_type_as_a_server():
|
|
computer = FakeComputer(computertypeid=4, icon='server')
|
|
assert build_endpoint_context(computer)['isserver'] is True
|
|
|
|
|
|
def test_context_does_not_mark_a_desktop_type_as_a_server():
|
|
computer = FakeComputer(computertypeid=1, icon='desktop')
|
|
assert build_endpoint_context(computer)['isserver'] is False
|
|
|
|
|
|
def test_context_handles_a_computer_with_no_type():
|
|
computer = FakeComputer()
|
|
assert build_endpoint_context(computer)['isserver'] is False
|
|
|
|
|
|
def test_an_unknown_node_type_is_still_rejected():
|
|
with pytest.raises(ScopeError):
|
|
validate_scope({'type': 'allpc'})
|