2c415a1712
CLIENT IP / SPOOFABILITY. docs/geenforce-api-cutover.md claimed that removing the IIS rewrite rule made the allowlist fail closed and that it does NOT become spoofable. The opposite is true. IIS never sets X-Forwarded-For on its own; the rule is the only thing that does. Remove it and IIS still forwards whatever X-Forwarded-For the CALLER sent, waitress trusts it because it arrives from 127.0.0.1, and remote_addr becomes attacker-controlled - so a token-less caller can fetch manifests from anywhere on the network. The document and the _trusted_client_ip docstring now say so, waitress runs with --trusted-proxy-count=1, and stage 5 checks the rule is actually live rather than assuming it. The wizard question is rephrased to something an operator can verify with their network team instead of guessing at. NON-ASCII. The style gate only ever checked .py/.vue/.js/.ts, so documentation accumulated em-dashes, arrows and box-drawing characters against this repo's own convention - including in files added this week. Cleaned, and the gate now uses INCLUDES_ALL so Markdown, JSON and YAML are covered. PLUGIN DEFAULTS. The wizard pre-ticked measuringtools and printedparts, both of which ship default_enabled=false, so every site taking the defaults installed and enabled them against their manifests. Inno has no JSON parser so the list must be hardcoded, but tests/test_installer_defaults.py now fails when it drifts. UPGRADES. The payload copy merges, so a plugin dropped from a site's profile kept its code forever - which defeats a lean build and leaves core's optional-import guards succeeding for a plugin the site no longer has. Stale plugin directories are now deregistered and removed before the copy. add-plugin used 'plugin install', which for the five default_enabled=false plugins left them installed but DISABLED - and printed a green success line anyway. It now goes through apply-profile, and the success line is gated on the exit code. Invoke-Flask records its own exit status, because $LASTEXITCODE keeps a stale value when flask.exe is missing and no native command runs. CHARSET. The utf8mb4 compiler hook lived inline in migrations/env.py, so it covered the CORE chain only: plugin baselines inherited the server default, which on a latin1 server means two charsets in one database. It is now shopdb/utils/mysql_charset.py, imported by both, and preflight reports the database's default charset. BACKUP HONESTY. The dump was described as 'all of your asset data'. Uploaded branding and floor-map images live in instance\ on disk, not in the database, so a restore from the .sql alone comes back with no map. backup now archives instance\ alongside it and says both are needed. VERSIONING. AppVersion was hardcoded at 0.9.0 while the product, the frontend and the newest tag said 0.7.0 - and 0.9.0 collides with a retired contract version. Both builders now generate version.iss from shopdb/__init__.py. Smaller: rollback overwrites .env before deleting it, as uninstall already did; appcmd unlocks are scoped to this site's location rather than server-wide, with the wide unlock as a fallback; DEVELOPMENT-SETUP says Python 3.14; the README plugin list gains printedparts; prune-schema --force is documented as first-provisioning-only; HTTPS is documented as not-the-default with the steps to add it; the DBA SQL is on the wizard's database page; the features page says unticking does not remove an installed feature; and the installer README states that bundle-lock cannot vouch for the exe itself - that needs signing or an out-of-band hash, neither of which is wired up.
41 lines
1.7 KiB
Python
41 lines
1.7 KiB
Python
"""Force every table created on MySQL to utf8mb4 + DYNAMIC row format.
|
|
|
|
Importing this module installs a SQLAlchemy compiler hook. It is a side effect on
|
|
purpose: the hook has to be registered before any CreateTable is compiled, and
|
|
every place that creates tables needs it.
|
|
|
|
WHY. Without it a CREATE TABLE inherits the SERVER's default charset. A MySQL box
|
|
defaulting to latin1 - common on older installs, and the West Jefferson 5.6
|
|
server is one - silently builds a latin1 schema that drifts from the utf8mb4
|
|
production target. Nothing fails at create time; it surfaces later as mangled
|
|
characters, or as a join between a utf8mb4 and a latin1 column that cannot use an
|
|
index.
|
|
|
|
DYNAMIC row format is the other half: it keeps utf8mb4 indexes under the 767-byte
|
|
prefix limit on pre-5.7 InnoDB, which is what error 1071 ("key too long") is.
|
|
|
|
This lived inline in migrations/env.py, so it covered the CORE chain only. Plugin
|
|
chains (ADR-008) run through shopdb/plugins/alembic_template.py, which never
|
|
imported it - so a plugin's baseline tables were created at the server default
|
|
while core's were utf8mb4, on the same database. Both import this now.
|
|
|
|
Scoped to the mysql dialect, so the SQLite test database is untouched.
|
|
"""
|
|
from sqlalchemy.ext.compiler import compiles
|
|
from sqlalchemy.schema import CreateTable
|
|
|
|
TABLE_SUFFIX = (
|
|
" ENGINE=InnoDB DEFAULT CHARSET=utf8mb4"
|
|
" COLLATE=utf8mb4_unicode_ci ROW_FORMAT=DYNAMIC"
|
|
)
|
|
|
|
|
|
@compiles(CreateTable, "mysql")
|
|
def _mysql_create_table_utf8mb4(element, compiler, **kw):
|
|
sql = compiler.visit_create_table(element, **kw)
|
|
# An explicit CHARSET in the model's __table_args__ wins - this is a default,
|
|
# not an override.
|
|
if "CHARSET" not in sql.upper():
|
|
sql = sql.rstrip().rstrip(";") + TABLE_SUFFIX
|
|
return sql
|