534f179ee6
main was 16 days and 259 commits behind the line the product is actually built on, at contract 0.30.0 against 0.35.0, with no per-PC credential code at all. It was neither current nor curated - just stale. This brings it forward and, at the same time, makes it mean something: main is what a receiving site installs, and nothing else. WHAT IT CARRIES. Twelve plugins - backups, computers, endpoints, guides, knowledgebase, machines, network, notifications, printers, slides, tools, warranty - plus applications, which is manifest-less core and always ships. The only manifest dependency inside that set is endpoints on computers, and both are in it, so the closure is self-contained. WHAT IT DOES NOT. employees, geenforce, measuringtools, printedparts and usb stay on the site line. So do the Windows installer tree, the VM rehearsal helpers, the agent tooling config, one site's data loader, the internal audit and findings records, and the planner spreadsheet. 1,135 tracked files against 1,438. A REMOVAL THAT BREAKS THE APP IS NOT A REMOVAL, and two nearly shipped: deploy/site-profile-universal.json still named all seventeen plugins. It is the file docs/DEPLOY.md tells a site to provision from, so a fresh install would have failed at `flask plugin apply-profile` with PluginError - the first thing a receiving site does, broken by the branch meant to serve them. It now names the twelve that exist, and its comment says the two must agree. agent/ was never refreshed. Whoever populated this branch copied shopdb/, plugins/, frontend/ and tests/ from the site line and left the agent tree at its September state: 22 C# and PowerShell sources missing, including AgentCredentials, EnrollmentService, AgentHttpFactory and the fleet-alert client, plus one file the site line had deleted still present. The old tree is internally consistent, so it compiles, and nothing in CI builds it - every gate was green over a server that speaks enrollment and per-PC credentials to a bundled agent source that cannot. Resynced whole. DECISIONS THIS ENCODES, rather than defers: - The plugin-authoring lab builds printedparts, whose manifest depends on employees, so it could not stay. The lab remains on the site line and main ships no build-along tutorial. That is a real loss for an adopting developer and is recorded here rather than discovered later. - Recognition, Training and Recertification notifications are no longer seeded. Each splits one notification into a card per employee and renders a photo, which needs a plugin this branch does not bundle. Seeding them would offer an author a type that cannot resolve anybody. A site that installs employees gets them from that plugin's own seed. - Windows/IIS is documented as the legacy path throughout, and the README leads with Docker, because that is what a receiving site gets. The API description is regenerated for THIS branch - 347 paths and 483 operations, down from 415 and 573 - so the published contract describes what is here rather than what the site line serves. docs/CONFIG.md lost the two measuring-tool label keys the code no longer declares, which two lanes had decided opposite ways. Suite: 3124 passed, 6 skipped. Naming and style gates pass. The docs gates run rather than skip, and every index line count is derived from the file it names.
86 lines
3.0 KiB
Python
86 lines
3.0 KiB
Python
"""Allow indefinite policy action holds (policyactionholds.expiresat nullable).
|
|
|
|
0005 created expiresat NOT NULL because every hold was time-boxed: a hold that
|
|
nobody remembered to clear would expire on its own and policy would resume. That
|
|
self-healing property was the point of the column.
|
|
|
|
Admins now need to hold an action for work that cannot be bounded up front, so a
|
|
null expiresat is permitted and means indefinite - the hold stands until it is
|
|
released by hand. Everything reading this table must test
|
|
`expiresat IS NULL OR expiresat > now`; testing only the comparison silently
|
|
drops indefinite holds and lets policy resume against an admin who asked it not
|
|
to.
|
|
|
|
No backfill: existing rows all carry a real expiry and keep it. Widening
|
|
NOT NULL to NULL rewrites no data.
|
|
|
|
Idempotent: the alter is skipped when the column is already nullable, so a test
|
|
DB built by db.create_all() from the current model is left alone.
|
|
|
|
Revision ID: computers0006holdindefinite
|
|
Revises: computers0005policyactionholds
|
|
|
|
The id is kept short deliberately: alembic_version.version_num is VARCHAR(32),
|
|
and a longer id applies the DDL and then fails on the stamp, leaving the DB
|
|
migrated but recorded as un-migrated.
|
|
"""
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
|
|
|
|
revision = 'computers0006holdindefinite'
|
|
down_revision = 'computers0005policyactionholds'
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def _expiresat_is_nullable(bind):
|
|
"""True when policyactionholds.expiresat already permits null.
|
|
|
|
Returns None when the table is absent entirely, which lets both directions
|
|
no-op rather than raising on a DB where the computers chain has not built
|
|
the table yet.
|
|
"""
|
|
insp = sa.inspect(bind)
|
|
if 'policyactionholds' not in set(insp.get_table_names()):
|
|
return None
|
|
for column in insp.get_columns('policyactionholds'):
|
|
if column['name'] == 'expiresat':
|
|
return bool(column.get('nullable'))
|
|
return None
|
|
|
|
|
|
def upgrade():
|
|
bind = op.get_bind()
|
|
nullable = _expiresat_is_nullable(bind)
|
|
if nullable is None or nullable:
|
|
return
|
|
|
|
op.alter_column('policyactionholds', 'expiresat',
|
|
existing_type=sa.DateTime(),
|
|
nullable=True)
|
|
|
|
|
|
def downgrade():
|
|
"""Re-impose NOT NULL, giving any indefinite hold a bounded expiry.
|
|
|
|
A straight alter would fail on the rows this feature exists to create, so
|
|
indefinite holds are first stamped with the current time - expiring them
|
|
rather than destroying them. That is the conservative direction: on
|
|
downgrade, policy resuming is safer than reconciliation staying suppressed
|
|
by a row the older code cannot represent. The audit row survives either way.
|
|
"""
|
|
bind = op.get_bind()
|
|
nullable = _expiresat_is_nullable(bind)
|
|
if nullable is None or not nullable:
|
|
return
|
|
|
|
op.execute(sa.text(
|
|
'UPDATE policyactionholds '
|
|
'SET expiresat = CURRENT_TIMESTAMP '
|
|
'WHERE expiresat IS NULL'))
|
|
|
|
op.alter_column('policyactionholds', 'expiresat',
|
|
existing_type=sa.DateTime(),
|
|
nullable=False)
|