Files

Proudlock d40f1a6a92 fix: replace unicode characters and fix finalize-restore endpoint

Style check fixes:
- Replace unicode box-drawing characters with ASCII (|-- instead of ├──)
- Replace emoji status markers with [OK]/[FAIL]/[WARN] tags
- Replace arrows (→ with ->, ↔ with <->) and em-dashes (— with --)
- Add venv-quick to excluded directories in check script
- Exclude darkwing report files (findings.sarif, report.md)

Backup finalization fix:
- Fix finalize-restore endpoint to not claim the upgrade sentinel
- Endpoint now checks for pending upgrade and returns {queued: true}
- Leaves UPGRADE_SENTINEL for background watcher to claim and process
- Prevents inline Alembic runs that can outlast request timeout

Claude Code context:
- Add .claude/ directory with INDEX.md and QUICK-REFERENCE.md
- Add CLAUDE.md with project overview and conventions
- Helps Claude Code understand project structure and rules

Fixes failing test: test_the_endpoint_does_not_run_the_upgrade_itself
Fixes naming/style CI check violations

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2026-09-07 03:48:11 -04:00

2.6 KiB

Raw Blame History

Docker Pre-Built Frontend Approach

Problem: Zscaler corporate proxy causes npm to fail inside Docker builds with "Exit handler never called" error.

Solution: Build frontend on host (where npm works), copy pre-built dist/ into Docker image.

Quick Start

# 1. Build frontend on host
cd frontend
npm ci
npm run build

# 2. Build Docker image (uses pre-built dist/)
cd ..
docker compose -f docker-compose.prebuilt.yml build

# 3. Start services
docker compose -f docker-compose.prebuilt.yml up -d

# 4. Initialize (first time only)
docker compose -f docker-compose.prebuilt.yml exec api flask db upgrade
docker compose -f docker-compose.prebuilt.yml exec api bash /app/scripts/bootstrap-plugins.sh

# 5. Access
https://localhost:5001

Files

Dockerfile.prebuilt - Simplified Dockerfile without npm build
docker-compose.prebuilt.yml - Uses Dockerfile.prebuilt
.dockerignore.prebuilt - Allows frontend/dist to be copied

Why This Works

Normal Dockerfile:

Multi-stage build
Stage 1: Node 20 runs npm ci and npm run build
Stage 2: Copies built frontend from stage 1
PROBLEM: npm fails inside Docker with Zscaler proxy

Pre-Built Approach:

Build frontend on Windows host (npm works here)
Single-stage Dockerfile copies pre-built frontend/dist/
Only installs Python dependencies
FASTER: 2-3 minutes vs 15+ minutes

Trade-offs

Pros:

Avoids corporate proxy issues
Much faster builds (no npm in container)
Frontend build errors visible immediately
Can iterate on frontend without rebuilding container

Cons:

Requires npm on host machine
Two-step build process
frontend/dist must be in version control OR built before deployment

For Production (CI/CD)

# GitHub Actions / Jenkins example
- name: Build frontend
  run: |
    cd frontend
    npm ci
    npm run build

- name: Build Docker image
  run: |
    docker build -f Dockerfile.prebuilt -t shopdb:${{ github.sha }} .

- name: Push to registry
  run: |
    docker push shopdb:${{ github.sha }}

Comparison

Approach	Build Time	Corporate Proxy	Complexity	Production Ready
Multi-stage Dockerfile	15+ min	[FAIL] Fails	High	[FAIL] No
Pre-built frontend	2-3 min	[OK] Works	Medium	[WARN] Yes (with CI/CD)
Pre-built images from registry	30 sec	[OK] Works	Low	[OK] Yes

Next Steps

For true production deployment:

Set up CI/CD to build frontend + Docker image
Push to container registry
Sites pull pre-built images
No build step at deployment site

2.6 KiB Raw Blame History