ge-aerospace/shopdb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Standardize UI consistency across ShopDB pages

Browse Source 
Security fixes:
- Add HTMLEncode to displaysubnets.asp output
- Add HTMLEncode to displayapplications.asp URL attributes

Icon standardization:
- Use zmdi-plus-circle for all Add buttons (displaypcs, pcs, pclist, computers, listpcs)
- Use zmdi-edit for all Edit tab icons (displayapplication, displayprinter, displaysubnet, displaydevice)
- Replace icon-note with zmdi icons throughout

Layout consistency:
- Standardize title row margin-bottom to 15px across all pages
- Add table-hover class to all data tables
- Fix editpc.asp title from "Edit Equipment" to "Edit PC"
- Fix editpc.asp back link to point to displaypcs.asp

Terminology:
- Change "Make" to "Vendor" in displayprinters.asp
- Standardize Back button text to "Back to [Page]" format

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
cproudlock
2025-12-10 14:20:35 -05:00
parent 6522a8699e
commit 8194f5cdf0
21 changed files with 117 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
displayapplications.asp
View File

@@ -34,7 +34,7 @@
If filterType = "" Then filterType = "installable"
%>
<div style="margin-bottom:15px;">
<div style="display:flex; justify-content:space-between; align-items:center; margin-bottom:10px;">
<div style="display:flex; justify-content:space-between; align-items:center; margin-bottom:15px;">
<h5 class="card-title" style="margin:0;">Applications</h5>
<div>
<a href="./addapplication.asp" class="btn btn-primary">
@@ -83,34 +83,34 @@
set rs = objconn.Execute(strSQL)
while not rs.eof
response.write("<tr>")
While Not rs.EOF
Response.Write("<tr>")
' Show download icon if installpath is set, or if applicationlink is set as fallback
IF Not IsNull(rs("installpath")) And rs("installpath") <> "" THEN
response.write("<td><a href='" &rs("installpath") &"' title='Link To Installation Files' target='_blank'><i class='zmdi zmdi-download' style='color:#fff;' title='Click for Installation Files'></i></a></td>")
ELSEIF Not IsNull(rs("applicationlink")) And rs("applicationlink") <> "" THEN
response.write("<td><a href='" &rs("applicationlink") &"' title='Link To Application' target='_blank'><i class='zmdi zmdi-download' style='color:#fff;' title='Click for Application Link'></i></a></td>")
ELSE
response.write("<td>&nbsp;</td>")
END IF
IF Not IsNull(rs("documentationpath")) And rs("documentationpath") <> "" THEN
response.write("<td><a href='" &rs("documentationpath") &"' target='_blank'><i class='zmdi zmdi-info-outline' style='color:#fff;' title='Click for Documentation'></i></a></td>")
ELSE
response.write("<td>&nbsp;</td>")
END IF
response.write("<td title='" &rs("applicationnotes") &"'><a href='displayapplication.asp?appid=" &rs("appid") &"'>" &rs("appname") &"</a></td>")
response.write("<td font size='10px'>")
response.write(rs("teamname"))
response.write("</td>")
response.write("<td>")
response.write("<a href='MSTeams:/l/chat/0/0?users=" &rs("sso") &"@geaerospace.com' title='Click here to Chat on Teams'>" &rs("appowner") &"</a>")
response.write("</td>")
response.write("<td>")
response.write(rs("sso"))
response.write("</td>")
response.write("</tr>")
rs.movenext
wend
If Not IsNull(rs("installpath")) And rs("installpath") <> "" Then
Response.Write("<td><a href='" & Server.HTMLEncode(rs("installpath") & "") & "' title='Link To Installation Files' target='_blank'><i class='zmdi zmdi-download' style='color:#fff;' title='Click for Installation Files'></i></a></td>")
ElseIf Not IsNull(rs("applicationlink")) And rs("applicationlink") <> "" Then
Response.Write("<td><a href='" & Server.HTMLEncode(rs("applicationlink") & "") & "' title='Link To Application' target='_blank'><i class='zmdi zmdi-download' style='color:#fff;' title='Click for Application Link'></i></a></td>")
Else
Response.Write("<td>&nbsp;</td>")
End If
If Not IsNull(rs("documentationpath")) And rs("documentationpath") <> "" Then
Response.Write("<td><a href='" & Server.HTMLEncode(rs("documentationpath") & "") & "' target='_blank'><i class='zmdi zmdi-info-outline' style='color:#fff;' title='Click for Documentation'></i></a></td>")
Else
Response.Write("<td>&nbsp;</td>")
End If
Response.Write("<td title='" & Server.HTMLEncode(rs("applicationnotes") & "") & "'><a href='displayapplication.asp?appid=" & Server.HTMLEncode(rs("appid") & "") & "'>" & Server.HTMLEncode(rs("appname") & "") & "</a></td>")
Response.Write("<td style='font-size:10px;'>")
Response.Write(Server.HTMLEncode(rs("teamname") & ""))
Response.Write("</td>")
Response.Write("<td>")
Response.Write("<a href='MSTeams:/l/chat/0/0?users=" & Server.HTMLEncode(rs("sso") & "") & "@geaerospace.com' title='Click here to Chat on Teams'>" & Server.HTMLEncode(rs("appowner") & "") & "</a>")
Response.Write("</td>")
Response.Write("<td>")
Response.Write(Server.HTMLEncode(rs("sso") & ""))
Response.Write("</td>")
Response.Write("</tr>")
rs.MoveNext
Wend
objConn.Close
%>