Remove emojis from all markdown docs, add consolidation plan
- Strip emojis from 47 markdown files across docs/, sql/, and root - Add docs/DOCS_CONSOLIDATION_PLAN.md with plan to reduce 45 docs to 8 - Establish no-emoji rule for documentation going forward 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
cproudlock
@@ -8,7 +8,7 @@ Fixed multiple critical bugs in `api.asp` that prevented PowerShell data collect
|
||||
|
||||
## Bugs Fixed
|
||||
|
||||
### 1. ✅ **PC UPDATE Bug (InsertOrUpdatePC)**
|
||||
### 1. **PC UPDATE Bug (InsertOrUpdatePC)**
|
||||
**Lines:** 451-495
|
||||
**Symptom:** PC records could be inserted but not updated
|
||||
**Error:** `"Variable is undefined"`
|
||||
@@ -30,11 +30,11 @@ End If
|
||||
"modelnumberid = " & sqlModelId & ", " & _
|
||||
```
|
||||
|
||||
**Test Result:** ✅ Both INSERT and UPDATE now working correctly
|
||||
**Test Result:** Both INSERT and UPDATE now working correctly
|
||||
|
||||
---
|
||||
|
||||
### 2. ✅ **PC→Machine Relationship Bug (CreatePCMachineRelationship)**
|
||||
### 2. **PC→Machine Relationship Bug (CreatePCMachineRelationship)**
|
||||
**Lines:** 849-984
|
||||
**Symptom:** PowerShell scripts couldn't create PC→Machine relationships
|
||||
**Errors:** Multiple issues found and fixed
|
||||
@@ -69,14 +69,14 @@ cmdInsert.Parameters.Append cmdInsert.CreateParameter("@equipmentid", 3, 1, , CL
|
||||
**Problem:** Parameterized query helper function wasn't returning `machineid` value
|
||||
**Fix:** Switched to direct SQL execution with proper string sanitization
|
||||
|
||||
**Test Result:** ✅ PC→Machine relationships now created correctly
|
||||
**Test Result:** PC→Machine relationships now created correctly
|
||||
```
|
||||
PC 5459 (FINAL-TEST-PC) → Controls → Equipment 136 (machine 2021)
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### 3. ✅ **Network Interface Storage Bug (InsertNetworkInterfaces)**
|
||||
### 3. **Network Interface Storage Bug (InsertNetworkInterfaces)**
|
||||
**Lines:** 695-698
|
||||
**Symptom:** Would fail when storing network interface data
|
||||
**Error:** `"Variable is undefined"`
|
||||
@@ -93,11 +93,11 @@ If subnetMask <> "" Then paramSubnet = subnetMask Else paramSubnet = Null
|
||||
If gateway <> "" Then paramGateway = gateway Else paramGateway = Null
|
||||
```
|
||||
|
||||
**Status:** ✅ Already working (705 network interfaces stored), but now bug-proof
|
||||
**Status:** Already working (705 network interfaces stored), but now bug-proof
|
||||
|
||||
---
|
||||
|
||||
### 4. ✅ **Serial Port Config Bug (InsertCommConfigs)**
|
||||
### 4. **Serial Port Config Bug (InsertCommConfigs)**
|
||||
**Lines:** 751-755
|
||||
**Symptom:** Would fail when storing serial port configurations
|
||||
**Error:** `"Variable is undefined"`
|
||||
@@ -108,7 +108,7 @@ If gateway <> "" Then paramGateway = gateway Else paramGateway = Null
|
||||
|
||||
---
|
||||
|
||||
### 5. ✅ **DNC Config Bug (InsertDNCConfig)**
|
||||
### 5. **DNC Config Bug (InsertDNCConfig)**
|
||||
**Lines:** 830-848
|
||||
**Symptom:** Would fail when storing DNC configuration data
|
||||
**Error:** `"Variable is undefined"`
|
||||
@@ -135,7 +135,7 @@ If cnc <> "" Then pCnc = cnc Else pCnc = Null
|
||||
|
||||
---
|
||||
|
||||
### 6. ✅ **Warranty Data Bug (UpdateWarrantyData)**
|
||||
### 6. **Warranty Data Bug (UpdateWarrantyData)**
|
||||
**Lines:** 1012-1014, 1032-1034
|
||||
**Symptom:** Would fail when storing warranty information
|
||||
**Error:** `"Variable is undefined"`
|
||||
@@ -146,7 +146,7 @@ If cnc <> "" Then pCnc = cnc Else pCnc = Null
|
||||
|
||||
---
|
||||
|
||||
### 7. ✅ **Application Version Bug (GetOrCreateApplication)**
|
||||
### 7. **Application Version Bug (GetOrCreateApplication)**
|
||||
**Line:** 1301
|
||||
**Symptom:** Would fail when storing application with version
|
||||
**Error:** `"Variable is undefined"`
|
||||
@@ -161,57 +161,57 @@ If cnc <> "" Then pCnc = cnc Else pCnc = Null
|
||||
|
||||
| Function | IIf() Bugs | Status |
|
||||
|----------|-----------|--------|
|
||||
| InsertOrUpdatePC | 5 | ✅ Fixed |
|
||||
| InsertNetworkInterfaces | 4 | ✅ Fixed |
|
||||
| InsertCommConfigs | 5 | ✅ Fixed |
|
||||
| InsertDNCConfig | 19 | ✅ Fixed |
|
||||
| UpdateWarrantyData (UPDATE) | 3 | ✅ Fixed |
|
||||
| UpdateWarrantyData (INSERT) | 3 | ✅ Fixed |
|
||||
| GetOrCreateApplication | 1 | ✅ Fixed |
|
||||
| CreatePCMachineRelationship (logic) | N/A | ✅ Fixed |
|
||||
| **TOTAL** | **33 + 3 logic bugs** | **✅ ALL FIXED** |
|
||||
| InsertOrUpdatePC | 5 | Fixed |
|
||||
| InsertNetworkInterfaces | 4 | Fixed |
|
||||
| InsertCommConfigs | 5 | Fixed |
|
||||
| InsertDNCConfig | 19 | Fixed |
|
||||
| UpdateWarrantyData (UPDATE) | 3 | Fixed |
|
||||
| UpdateWarrantyData (INSERT) | 3 | Fixed |
|
||||
| GetOrCreateApplication | 1 | Fixed |
|
||||
| CreatePCMachineRelationship (logic) | N/A | Fixed |
|
||||
| **TOTAL** | **33 + 3 logic bugs** | ** ALL FIXED** |
|
||||
|
||||
---
|
||||
|
||||
## Data Collection Status
|
||||
|
||||
### ✅ **Working Correctly**
|
||||
### **Working Correctly**
|
||||
|
||||
1. **PC Records**
|
||||
- INSERT new PCs: ✅ Working
|
||||
- UPDATE existing PCs: ✅ Working (FIXED)
|
||||
- Phase 2 schema (machinetypeid 33/34/35): ✅ Working
|
||||
- INSERT new PCs: Working
|
||||
- UPDATE existing PCs: Working (FIXED)
|
||||
- Phase 2 schema (machinetypeid 33/34/35): Working
|
||||
|
||||
2. **PC→Machine Relationships**
|
||||
- Automatic creation from PowerShell: ✅ Working (FIXED)
|
||||
- Correct relationship direction: ✅ Working (FIXED)
|
||||
- Phase 2 schema compatibility: ✅ Working (FIXED)
|
||||
- Automatic creation from PowerShell: Working (FIXED)
|
||||
- Correct relationship direction: Working (FIXED)
|
||||
- Phase 2 schema compatibility: Working (FIXED)
|
||||
- Database: 705+ relationships active
|
||||
|
||||
3. **Network/IP Information**
|
||||
- Stored in `communications` table: ✅ Working
|
||||
- Stored in `communications` table: Working
|
||||
- 705 network interfaces collected
|
||||
- Data: IP, MAC, subnet, gateway, DHCP status, interface name
|
||||
- Uses comstypeid=3 (Network_Interface): ✅ Correct
|
||||
- Uses comstypeid=3 (Network_Interface): Correct
|
||||
|
||||
4. **Installed Applications**
|
||||
- Stored in `installedapps` table: ✅ Working
|
||||
- Stored in `installedapps` table: Working
|
||||
- 331 application entries
|
||||
- Linked via machineid and appid: ✅ Correct
|
||||
- Linked via machineid and appid: Correct
|
||||
|
||||
5. **DNC Configuration**
|
||||
- Stored in `pc_dnc_config` table: ✅ Working (FIXED)
|
||||
- DualPath detection: ✅ Working (FIXED)
|
||||
- GE Registry architecture tracking: ✅ Working (FIXED)
|
||||
- Path names (LEFT/RIGHT): ✅ Working (FIXED)
|
||||
- Stored in `pc_dnc_config` table: Working (FIXED)
|
||||
- DualPath detection: Working (FIXED)
|
||||
- GE Registry architecture tracking: Working (FIXED)
|
||||
- Path names (LEFT/RIGHT): Working (FIXED)
|
||||
|
||||
6. **Serial Port Configs**
|
||||
- Stored in `pc_comm_config` table: ✅ Working (FIXED)
|
||||
- Baud rate, data bits, parity, stop bits: ✅ Working
|
||||
- Stored in `pc_comm_config` table: Working (FIXED)
|
||||
- Baud rate, data bits, parity, stop bits: Working
|
||||
|
||||
7. **Warranty Data**
|
||||
- Stored in `warranties` table: ✅ Working (FIXED)
|
||||
- End date, service level, status, days remaining: ✅ Working
|
||||
- Stored in `warranties` table: Working (FIXED)
|
||||
- End date, service level, status, days remaining: Working
|
||||
|
||||
---
|
||||
|
||||
@@ -229,7 +229,7 @@ curl -X POST "http://192.168.122.151:8080/api.asp" \
|
||||
-d "machineNo=2021"
|
||||
```
|
||||
|
||||
**Result:** ✅ SUCCESS
|
||||
**Result:** SUCCESS
|
||||
- PC created: machineid=5459
|
||||
- Relationship created: PC 5459 → Controls → Equipment 136
|
||||
|
||||
@@ -239,14 +239,14 @@ curl -X POST "http://192.168.122.151:8080/api.asp" \
|
||||
curl -X POST "..." -d "hostname=FINAL-TEST-PC" -d "serialNumber=UPDATED-SERIAL"
|
||||
```
|
||||
|
||||
**Result:** ✅ SUCCESS (Previously would FAIL with "Variable is undefined")
|
||||
**Result:** SUCCESS (Previously would FAIL with "Variable is undefined")
|
||||
|
||||
### Test 3: API Health Check
|
||||
```bash
|
||||
curl "http://192.168.122.151:8080/api.asp?action=getDashboardData"
|
||||
```
|
||||
|
||||
**Result:** ✅ SUCCESS
|
||||
**Result:** SUCCESS
|
||||
```json
|
||||
{
|
||||
"success": true,
|
||||
@@ -260,17 +260,17 @@ curl "http://192.168.122.151:8080/api.asp?action=getDashboardData"
|
||||
|
||||
## PowerShell Scripts Status
|
||||
|
||||
### ✅ **Ready to Use**
|
||||
### **Ready to Use**
|
||||
|
||||
**Update-PC-CompleteAsset.ps1**
|
||||
- Default API URL: `http://192.168.122.151:8080/api.asp` ✅
|
||||
- Data collection: Hardware, OS, Network, DNC, Serial, Applications ✅
|
||||
- API communication: ✅ All endpoints working
|
||||
- Phase 2 schema: ✅ Compatible
|
||||
- Default API URL: `http://192.168.122.151:8080/api.asp`
|
||||
- Data collection: Hardware, OS, Network, DNC, Serial, Applications
|
||||
- API communication: All endpoints working
|
||||
- Phase 2 schema: Compatible
|
||||
|
||||
**Invoke-RemoteAssetCollection.ps1**
|
||||
- Remote execution via WinRM: ✅ Ready
|
||||
- Default URL: ⚠️ Still points to old PHP API
|
||||
- Remote execution via WinRM: Ready
|
||||
- Default URL: Still points to old PHP API
|
||||
- **Recommendation:** Update default or use `-DashboardURL` parameter
|
||||
|
||||
---
|
||||
@@ -418,10 +418,10 @@ POST http://192.168.122.151:8080/api.asp
|
||||
```
|
||||
|
||||
**Actions:**
|
||||
- `updateCompleteAsset` - PC data collection (✅ FIXED)
|
||||
- `updatePrinterMapping` - Printer assignments (✅ Working)
|
||||
- `updateInstalledApps` - Application tracking (✅ Working)
|
||||
- `getDashboardData` - Health check (✅ Working)
|
||||
- `updateCompleteAsset` - PC data collection ( FIXED)
|
||||
- `updatePrinterMapping` - Printer assignments ( Working)
|
||||
- `updateInstalledApps` - Application tracking ( Working)
|
||||
- `getDashboardData` - Health check ( Working)
|
||||
|
||||
### Test Script
|
||||
|
||||
@@ -439,7 +439,7 @@ Runs all test scenarios:
|
||||
|
||||
---
|
||||
|
||||
**Status:** ✅ ALL BUGS FIXED AND TESTED
|
||||
**Status:** ALL BUGS FIXED AND TESTED
|
||||
**Date:** 2025-11-14
|
||||
**Tested By:** Claude Code (AI Assistant)
|
||||
**Production Ready:** YES
|
||||
|
||||
Reference in New Issue
Block a user