%
'=============================================================================
' FILE: editmacine.asp
' PURPOSE: Edit machine information with nested entity creation
' SECURITY: Parameterized queries, HTML encoding, input validation
' UPDATED: 2025-10-27 - Migrated to secure patterns
' REFACTORED: 2025-10-27 - Removed machinetypeid (now inherited from models table)
' NOTE: File has typo in name (macine vs machine) - preserved for compatibility
' NOTE: Machines now inherit machinetypeid from their model. Each model has one machine type.
'=============================================================================
%>
<%
'=============================================================================
' SECURITY: Validate machineid from querystring
'=============================================================================
Dim machineid
machineid = GetSafeInteger("QS", "machineid", 0, 1, 999999)
If machineid = 0 Then
Response.Write("
Error: Invalid machine ID.
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
'=============================================================================
' SECURITY: Get and validate all form inputs
'=============================================================================
Dim modelid, businessunitid, printerid, mapleft, maptop
modelid = GetSafeString("FORM", "modelid", "", 1, 50, "")
businessunitid = GetSafeString("FORM", "businessunitid", "", 1, 50, "")
printerid = GetSafeInteger("FORM", "printerid", 0, 0, 999999)
mapleft = GetSafeInteger("FORM", "mapleft", 0, 0, 9999)
maptop = GetSafeInteger("FORM", "maptop", 0, 0, 9999)
' Get form inputs for new business unit
Dim newbusinessunit
newbusinessunit = GetSafeString("FORM", "newbusinessunitname", "", 0, 50, "")
' Get form inputs for new model
Dim newmodelnumber, newvendorid, newmodelimage, newmodelmachinetypeid
newmodelnumber = GetSafeString("FORM", "newmodelnumber", "", 0, 255, "")
newvendorid = GetSafeString("FORM", "newvendorid", "", 0, 50, "")
newmodelimage = GetSafeString("FORM", "newmodelimage", "", 0, 255, "")
newmodelmachinetypeid = GetSafeString("FORM", "newmodelmachinetypeid", "", 0, 50, "")
' Get form inputs for new vendor
Dim newvendorname
newvendorname = GetSafeString("FORM", "newvendorname", "", 0, 50, "")
'=============================================================================
' Validate required fields
'=============================================================================
If modelid <> "new" And (Not IsNumeric(modelid)) Then
Response.Write("
Error: Invalid model ID.
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
If businessunitid <> "new" And (Not IsNumeric(businessunitid)) Then
Response.Write("
Error: Invalid business unit ID.
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
'=============================================================================
' SECURITY: Handle new business unit creation with parameterized query
'=============================================================================
If businessunitid = "new" Then
If Len(newbusinessunit) = 0 Then
Response.Write("
New business unit name is required
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
' Insert new business unit using parameterized query
Dim sqlNewBU
sqlNewBU = "INSERT INTO businessunits (businessunit, isactive) VALUES (?, 1)"
On Error Resume Next
Dim cmdNewBU
Set cmdNewBU = Server.CreateObject("ADODB.Command")
cmdNewBU.ActiveConnection = objConn
cmdNewBU.CommandText = sqlNewBU
cmdNewBU.CommandType = 1
cmdNewBU.Parameters.Append cmdNewBU.CreateParameter("@businessunit", 200, 1, 50, newbusinessunit)
cmdNewBU.Execute
If Err.Number <> 0 Then
Response.Write("
Error creating new business unit: " & Server.HTMLEncode(Err.Description) & "
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
' Get the newly created business unit ID
Dim rsNewBU
Set rsNewBU = objConn.Execute("SELECT LAST_INSERT_ID() AS newid")
businessunitid = 0
If Not rsNewBU.EOF Then
If Not IsNull(rsNewBU("newid")) Then
businessunitid = CLng(rsNewBU("newid"))
End If
End If
rsNewBU.Close
Set rsNewBU = Nothing
Set cmdNewBU = Nothing
On Error Goto 0
End If
'=============================================================================
' SECURITY: Handle new model creation with parameterized query
'=============================================================================
If modelid = "new" Then
If Len(newmodelnumber) = 0 Then
Response.Write("
New model number is required
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
If Len(newvendorid) = 0 Then
Response.Write("
Vendor is required for new model
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
If Len(newmodelmachinetypeid) = 0 Or Not IsNumeric(newmodelmachinetypeid) Then
Response.Write("
Machine type is required for new model
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
' Handle new vendor creation (nested)
If newvendorid = "new" Then
If Len(newvendorname) = 0 Then
Response.Write("
New vendor name is required
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
' Insert new vendor using parameterized query
Dim sqlNewVendor
sqlNewVendor = "INSERT INTO vendors (vendor, isactive, isprinter, ispc, ismachine) VALUES (?, 1, 0, 0, 1)"
On Error Resume Next
Dim cmdNewVendor
Set cmdNewVendor = Server.CreateObject("ADODB.Command")
cmdNewVendor.ActiveConnection = objConn
cmdNewVendor.CommandText = sqlNewVendor
cmdNewVendor.CommandType = 1
cmdNewVendor.Parameters.Append cmdNewVendor.CreateParameter("@vendor", 200, 1, 50, newvendorname)
cmdNewVendor.Execute
If Err.Number <> 0 Then
Response.Write("
Error creating new vendor: " & Server.HTMLEncode(Err.Description) & "
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
' Get the newly created vendor ID
Dim rsNewVendor
Set rsNewVendor = objConn.Execute("SELECT LAST_INSERT_ID() AS newid")
newvendorid = 0
If Not rsNewVendor.EOF Then
If Not IsNull(rsNewVendor("newid")) Then
newvendorid = CLng(rsNewVendor("newid"))
End If
End If
rsNewVendor.Close
Set rsNewVendor = Nothing
Set cmdNewVendor = Nothing
On Error Goto 0
End If
' Set default image if not specified
If newmodelimage = "" Then
newmodelimage = "default.png"
End If
' Insert new model using parameterized query (including machinetypeid)
Dim sqlNewModel
sqlNewModel = "INSERT INTO models (modelnumber, vendorid, machinetypeid, image, isactive) VALUES (?, ?, ?, ?, 1)"
On Error Resume Next
Dim cmdNewModel
Set cmdNewModel = Server.CreateObject("ADODB.Command")
cmdNewModel.ActiveConnection = objConn
cmdNewModel.CommandText = sqlNewModel
cmdNewModel.CommandType = 1
cmdNewModel.Parameters.Append cmdNewModel.CreateParameter("@modelnumber", 200, 1, 255, newmodelnumber)
cmdNewModel.Parameters.Append cmdNewModel.CreateParameter("@vendorid", 3, 1, , CLng(newvendorid))
cmdNewModel.Parameters.Append cmdNewModel.CreateParameter("@machinetypeid", 3, 1, , CLng(newmodelmachinetypeid))
cmdNewModel.Parameters.Append cmdNewModel.CreateParameter("@image", 200, 1, 255, newmodelimage)
cmdNewModel.Execute
If Err.Number <> 0 Then
Response.Write("
Error creating new model: " & Server.HTMLEncode(Err.Description) & "
")
Response.Write("
Go back")
objConn.Close
Response.End
End If
' Get the newly created model ID
Dim rsNewModel
Set rsNewModel = objConn.Execute("SELECT LAST_INSERT_ID() AS newid")
modelid = 0
If Not rsNewModel.EOF Then
If Not IsNull(rsNewModel("newid")) Then
modelid = CLng(rsNewModel("newid"))
End If
End If
rsNewModel.Close
Set rsNewModel = Nothing
Set cmdNewModel = Nothing
On Error Goto 0
End If
'=============================================================================
' SECURITY: Update machine using parameterized query
'=============================================================================
' Build UPDATE statement with parameterized query
' NOTE: machinetypeid is now inherited from models table and doesn't need to be updated
Dim strSQL, paramCount
paramCount = 0
strSQL = "UPDATE machines SET modelnumberid = ?, businessunitid = ?"
paramCount = 2
' Add optional printerid
If printerid > 0 Then
strSQL = strSQL & ", printerid = ?"
paramCount = paramCount + 1
End If
' Add optional map coordinates
If mapleft > 0 And maptop > 0 Then
strSQL = strSQL & ", mapleft = ?, maptop = ?"
paramCount = paramCount + 2
End If
strSQL = strSQL & " WHERE machineid = ?"
On Error Resume Next
Dim cmdUpdate
Set cmdUpdate = Server.CreateObject("ADODB.Command")
cmdUpdate.ActiveConnection = objConn
cmdUpdate.CommandText = strSQL
cmdUpdate.CommandType = 1
' Add parameters in order
cmdUpdate.Parameters.Append cmdUpdate.CreateParameter("@modelnumberid", 3, 1, , CLng(modelid))
cmdUpdate.Parameters.Append cmdUpdate.CreateParameter("@businessunitid", 3, 1, , CLng(businessunitid))
If printerid > 0 Then
cmdUpdate.Parameters.Append cmdUpdate.CreateParameter("@printerid", 3, 1, , CLng(printerid))
End If
If mapleft > 0 And maptop > 0 Then
cmdUpdate.Parameters.Append cmdUpdate.CreateParameter("@mapleft", 3, 1, , CLng(mapleft))
cmdUpdate.Parameters.Append cmdUpdate.CreateParameter("@maptop", 3, 1, , CLng(maptop))
End If
cmdUpdate.Parameters.Append cmdUpdate.CreateParameter("@machineid", 3, 1, , CLng(machineid))
cmdUpdate.Execute
If Err.Number <> 0 Then
Response.Write("
Error: " & Server.HTMLEncode(Err.Description) & "
")
Response.Write("
Go back")
Set cmdUpdate = Nothing
objConn.Close
Response.End
End If
Set cmdUpdate = Nothing
On Error Goto 0
%>
<%
'=============================================================================
' CLEANUP
'=============================================================================
objConn.Close
%>