Document the disk health field

Records why there are two sources and why they are not reconciled, so the next person does not simplify the ATA SMART path back in and silently blind the fleet on NVMe hardware.

Also notes that diskhealth is per physical device and is not the same list as disks, and that a null predictfailure is unknown rather than healthy.
This commit is contained in:
benjamin.baker
2026-09-05 06:26:06 -04:00
parent c2ec29e236
commit 71847d940a
2 changed files with 52 additions and 4 deletions

View File

@@ -136,8 +136,25 @@ inventory-snapshot plumbing and one migration.
Root Dispersion in the same seconds format BEFORE Phase Offset, so a
first-match parser silently reports network latency as clock skew. That bug
was written and caught here; do not rewrite it.
- **Disk errors / SMART predictive failure** - collect and surface on the
existing Storage card (Phase 4).
- **Disk errors / SMART predictive failure** - DONE. Landed as its own "Disk
health" card rather than folded into the Storage card as originally planned:
Storage is per VOLUME (C:, D:) and this is per PHYSICAL device, and one drive
can back several volumes or none the operator sees, so the two do not share a
key and could not be one table.
The important finding: the classic ATA SMART class
(`MSStorageDriver_FailurePredictStatus`) returns ZERO instances on an NVMe
machine. Verified on a two-NVMe box where both drives were present and
healthy. An agent collecting only that class would have reported an empty
disk health list on every modern endpoint and read as "no problems" - the
exact silent-healthy failure mode this telemetry exists to prevent. So the
agent collects BOTH `MSFT_PhysicalDisk` (the only NVMe-aware source) and
`Win32_DiskDrive.Status` (ATA/SATA, and hosts where the Storage namespace is
unavailable), and the server does not reconcile them - same reasoning as the
Phase 1 mapped-drive merge, where two disagreeing sources was the signal.
Note `MSFT_PhysicalDisk` returns raw enum INTEGERS through
ManagementObjectSearcher, not the friendly strings `Get-PhysicalDisk` prints
(Health=0 Op=2 Media=4 Bus=17 for a healthy NVMe); the mapping lives in the
collector so the wire stays self-describing.
- **NIC link speed and duplex** - collect, pair into the existing Network
interfaces collection, NOT surfaced yet.
- **Boot type** - fast startup vs true cold boot. Explains why uptime lies and
@@ -199,8 +216,12 @@ Depends on Phase 2 data existing.
- **Mapped drives card** - `Get-SmbMapping`-shaped. `Disconnected` in red,
`Ok` in green. Reuse existing badge/severity styling rather than inventing
new CSS. Room reserved for the future one-click fix action.
- **Storage card** - add disk error / SMART predictive failure to the existing
card rather than a new one.
- **Storage card** - superseded. Disk health shipped in Phase 2 as its own
"Disk health" card (position 18, directly under Storage) instead of being
folded in: Storage is per volume, disk health is per physical device, so they
do not share a key. Rows sort failure-first, then unknown, then OK - a failing
drive must not sit below the fold on a multi-disk box, and a drive that
stopped answering is a weaker claim of health than one that said OK.
- **Windows Update card** - BLOCKED, not scheduled. Depends on Phase 2 data
that is pinned pending a COM-interference investigation. Do not build the card
until the collection question is settled.