End-of-pipeline cleanup. No structural changes; documents what is done, what is left, and the discipline for future cleanup commits. Skill: - simplifying-python: end-of-session cleanup discipline. Inspired by Anthropic's open-sourced code-simplifier. Targets duplication, dead code, voodoo constants, stale comments, misnamed identifiers, unnecessary abstraction. Anti-targets: architecture, public API surface, schema, sweeping rewrites. Behavior preservation enforced by running pytest before and after. Simplify pass on shopdb/utils/responses.py: - error_response docstring claimed the error info lives at top level `error`. Implementation puts it under `data.error` (consistent with the success envelope). Implementation is correct; docstring updated. - paginated_response docstring used snake_case keys (`per_page`, `total_pages`, etc). Implementation uses lowercase concatenated per CONTRIBUTING.md. Docstring updated to match. Documentation: - docs/PLUGINS.md: bundled plugins (six, with what they track and caveats per ADR), planned plugins (measuringtools as the scaffold canary per ADR-005), distribution conventions for sister-site plugins per ADR-003, naming policy. - docs/ROADMAP.md: phase status table (0-5 done, 6 in progress), must-have work for 1.0 (Asset.mapx/mapy, equipment migration, printers retirement, frontend hook contract, per-plugin Alembic chains), nice-to-have (measuringtools plugin, frontend scaffolding, marketplace listing, surface-diff tooling), deferred (multi-tenancy, pip-installable plugins, event bus). Defines what 1.0.0 means as a contract. Test count unchanged: 101 passing. Naming/style check green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
176 lines
3.7 KiB
Python
176 lines
3.7 KiB
Python
"""Standardized API response helpers."""
|
|
|
|
from flask import jsonify, make_response
|
|
from typing import Any, Dict, List, Optional
|
|
from datetime import datetime
|
|
import uuid
|
|
|
|
|
|
class ErrorCodes:
|
|
"""Standard error codes."""
|
|
|
|
VALIDATION_ERROR = 'VALIDATION_ERROR'
|
|
NOT_FOUND = 'NOT_FOUND'
|
|
UNAUTHORIZED = 'UNAUTHORIZED'
|
|
FORBIDDEN = 'FORBIDDEN'
|
|
CONFLICT = 'CONFLICT'
|
|
INTERNAL_ERROR = 'INTERNAL_ERROR'
|
|
BAD_REQUEST = 'BAD_REQUEST'
|
|
PLUGIN_ERROR = 'PLUGIN_ERROR'
|
|
|
|
|
|
def api_response(
|
|
data: Any = None,
|
|
message: str = None,
|
|
status: str = 'success',
|
|
meta: Dict = None,
|
|
http_code: int = 200
|
|
):
|
|
"""
|
|
Create standardized API response.
|
|
|
|
Response format:
|
|
{
|
|
"status": "success" | "error",
|
|
"data": {...} | [...],
|
|
"message": "Optional message",
|
|
"meta": {
|
|
"timestamp": "2025-01-12T...",
|
|
"request_id": "uuid"
|
|
}
|
|
}
|
|
"""
|
|
response = {
|
|
'status': status,
|
|
'meta': {
|
|
'timestamp': datetime.utcnow().isoformat() + 'Z',
|
|
'requestid': str(uuid.uuid4())[:8],
|
|
**(meta or {})
|
|
}
|
|
}
|
|
|
|
if data is not None:
|
|
response['data'] = data
|
|
|
|
if message:
|
|
response['message'] = message
|
|
|
|
return make_response(jsonify(response), http_code)
|
|
|
|
|
|
def success_response(
|
|
data: Any = None,
|
|
message: str = None,
|
|
meta: Dict = None,
|
|
http_code: int = 200
|
|
):
|
|
"""Success response helper."""
|
|
return api_response(
|
|
data=data,
|
|
message=message,
|
|
meta=meta,
|
|
status='success',
|
|
http_code=http_code
|
|
)
|
|
|
|
|
|
def error_response(
|
|
code: str,
|
|
message: str,
|
|
details: Dict = None,
|
|
http_code: int = 400
|
|
):
|
|
"""Error response helper.
|
|
|
|
Response format:
|
|
{
|
|
"status": "error",
|
|
"data": {
|
|
"error": {
|
|
"code": "VALIDATION_ERROR",
|
|
"message": "Human-readable message",
|
|
"details": {...}
|
|
}
|
|
},
|
|
"meta": {
|
|
"timestamp": "...",
|
|
"requestid": "..."
|
|
}
|
|
}
|
|
"""
|
|
error_data = {
|
|
'code': code,
|
|
'message': message
|
|
}
|
|
if details:
|
|
error_data['details'] = details
|
|
|
|
return api_response(
|
|
data={'error': error_data},
|
|
status='error',
|
|
http_code=http_code
|
|
)
|
|
|
|
|
|
def api_error(
|
|
message: str,
|
|
code: str = ErrorCodes.BAD_REQUEST,
|
|
details: Dict = None,
|
|
http_code: int = 400
|
|
):
|
|
"""
|
|
Simplified error response helper.
|
|
|
|
Args:
|
|
message: Human-readable error message
|
|
code: Error code (default BAD_REQUEST)
|
|
details: Optional error details
|
|
http_code: HTTP status code (default 400)
|
|
"""
|
|
return error_response(code=code, message=message, details=details, http_code=http_code)
|
|
|
|
|
|
def paginated_response(
|
|
items: List,
|
|
page: int,
|
|
per_page: int,
|
|
total: int,
|
|
schema=None
|
|
):
|
|
"""Paginated list response.
|
|
|
|
Response format:
|
|
{
|
|
"status": "success",
|
|
"data": [...],
|
|
"meta": {
|
|
"pagination": {
|
|
"page": 1,
|
|
"perpage": 20,
|
|
"total": 150,
|
|
"totalpages": 8,
|
|
"hasnext": true,
|
|
"hasprev": false
|
|
}
|
|
}
|
|
}
|
|
"""
|
|
total_pages = (total + per_page - 1) // per_page if per_page > 0 else 0
|
|
|
|
if schema:
|
|
items = schema.dump(items, many=True)
|
|
|
|
return api_response(
|
|
data=items,
|
|
meta={
|
|
'pagination': {
|
|
'page': page,
|
|
'perpage': per_page,
|
|
'total': total,
|
|
'totalpages': total_pages,
|
|
'hasnext': page < total_pages,
|
|
'hasprev': page > 1
|
|
}
|
|
}
|
|
)
|