shopdb/DATEADDED_AND_NETWORK_DEVICES_FIX_2025-11-14.md

dateadded Column and Network Devices Fix - November 14, 2025

Summary

Fixed multiple issues preventing network devices (IDFs, Servers, Switches, Cameras, Access Points) from being saved and displayed correctly.

---

Issues Fixed

1. ✅ dateadded Column Errors

Problem: machines table doesn't have dateadded column, only lastupdated

Files Fixed:

• save_network_device.asp (lines 259, 327)
• pcs.asp (lines 125, 149)
• pclist.asp (lines 125, 149)
• listpcs.asp (lines 125, 149)
• computers.asp (lines 125, 149)

Changes:

' BEFORE:
INSERT INTO machines (..., dateadded, lastupdated) VALUES (..., NOW(), NOW())
SELECT m.dateadded FROM machines...
WHERE m.dateadded >= DATE_SUB(NOW(), INTERVAL ? DAY)

' AFTER:
INSERT INTO machines (..., lastupdated) VALUES (..., NOW())
SELECT m.lastupdated FROM machines...
WHERE m.lastupdated >= DATE_SUB(NOW(), INTERVAL ? DAY)

---

2. ✅ Wrong Machine Type IDs for Network Devices

Problem: save_network_device.asp was using incorrect machine type IDs

Incorrect Mapping (BEFORE):

• IDF: 34 (Engineering PC) ❌
• Server: 30 (doesn't exist) ❌
• Switch: 31 (doesn't exist) ❌
• Camera: 32 (doesn't exist) ❌
• Access Point: 33 (Standard PC) ❌

Correct Mapping (AFTER):

• IDF: 17 ✅
• Server: 20 ✅
• Switch: 19 ✅
• Camera: 18 ✅
• Access Point: 16 ✅

Impact: All new network devices will now be saved with correct machine types

---

3. ✅ View Not Finding Network Devices

Problem: vw_network_devices view was looking for IDFs in old idfs table instead of machines table

Fix: Updated view to query machines table with correct machine type IDs:

SELECT
    mt.machinetype AS device_type,
    m.machineid AS device_id,
    COALESCE(m.alias, m.machinenumber) AS device_name,
    ...
FROM machines m
JOIN machinetypes mt ON m.machinetypeid = mt.machinetypeid
WHERE m.machinetypeid IN (16,17,18,19,20)  -- Access Point, IDF, Camera, Switch, Server

---

4. ✅ Fixed Existing IDF Records

Action: Updated 2 existing IDFs that were saved with wrong machine type ID

UPDATE machines
SET machinetypeid = 17
WHERE machinetypeid = 34
  AND (alias LIKE 'IDF%' OR machinenumber LIKE 'IDF-%');

Result: 2 IDFs updated (machineid 5460, 5461)

---

Machine Types Reference

Network Devices (16-20):

• 16 = Access Point
• 17 = IDF
• 18 = Camera
• 19 = Switch
• 20 = Server

Equipment:

• 1-14 = Various manufacturing equipment
• 15 = Printer
• 21-32 = More manufacturing equipment

PCs (33-35):

• 33 = Standard PC
• 34 = Engineering PC
• 35 = Shopfloor PC

---

Testing Results

Test 1: Check View Contains IDFs

SELECT device_type, device_id, device_name
FROM vw_network_devices
WHERE device_type='IDF' AND isactive=1;

Result: ✅ 2 IDFs found (test, testidf2)

Test 2: Network Devices Page

curl "http://192.168.122.151:8080/network_devices.asp?filter=IDF"

Result: ✅ Both IDFs display correctly in the page

Test 3: Add New IDF

Result: ✅ New IDFs now save with machinetypeid=17 and appear immediately in list

---

Files Modified

1. save_network_device.asp

   • Line 42: Changed IDF machinetypeid from 34 to 17
   • Line 47: Changed Server machinetypeid from 30 to 20
   • Line 52: Changed Switch machinetypeid from 31 to 19
   • Line 57: Changed Camera machinetypeid from 32 to 18
   • Line 62: Changed Access Point machinetypeid from 33 to 16
   • Line 259: Removed dateadded from IDF INSERT
   • Line 327: Removed dateadded from device INSERT

2. pcs.asp

   • Line 125: Changed m.dateadded to m.lastupdated in SELECT
   • Line 149: Changed m.dateadded to m.lastupdated in WHERE

3. pclist.asp

   • Line 125: Changed m.dateadded to m.lastupdated in SELECT
   • Line 149: Changed m.dateadded to m.lastupdated in WHERE

4. listpcs.asp

   • Line 125: Changed m.dateadded to m.lastupdated in SELECT
   • Line 149: Changed m.dateadded to m.lastupdated in WHERE

5. computers.asp

   • Line 125: Changed m.dateadded to m.lastupdated in SELECT
   • Line 149: Changed m.dateadded to m.lastupdated in WHERE

6. vw_network_devices (SQL VIEW)

   • Recreated to pull network devices from machines table (machinetypeid 16-20)
   • Removed old IDFs table reference
   • Added proper JOINs to models, vendors, communications tables

---

Database Changes

machines table:

• 2 existing IDF records updated to machinetypeid=17

vw_network_devices view:

• Recreated to query machines table correctly

---

Status

• ✅ dateadded Errors: FIXED (6 files)
• ✅ Wrong Machine Type IDs: FIXED (save_network_device.asp)
• ✅ View Not Finding Devices: FIXED (vw_network_devices)
• ✅ Existing IDF Records: FIXED (2 records updated)
• ✅ Testing: PASSED (IDFs visible in network_devices.asp)

---

Next Steps

For New Devices:

• All new IDFs, Servers, Switches, Cameras, and Access Points will now be saved correctly
• They will appear immediately in network_devices.asp

For Existing Devices:

• If you find any devices that were saved with wrong machine type IDs, run:

  -- Check for misplaced devices
  SELECT machineid, alias, machinetypeid
  FROM machines
  WHERE machinetypeid IN (30,31,32,33,34)
    AND alias NOT IN (SELECT hostname FROM machines WHERE machinetypeid IN (33,34,35));
  

---

Date: 2025-11-14 Files Modified: 6 ASP files Database Changes: 1 view recreated, 2 records updated Status: ✅ ALL ISSUES RESOLVED