ge-aerospace/shopdb-flask
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Keep the site-literal patterns out of the published copy
Some checks failed
CI / naming (push) Successful in 27s
Details
CI / backend (push) Failing after 35s
Details
CI / migrations-mysql (push) Failing after 54s
Details
CI / frontend (push) Successful in 1m5s
Details

Browse Source 
The comment explaining the concatenation fix spelled the example hostname out
in full, which tripped the publication scrub - the same trap the surrounding
comment warns about, since the scrub greps this file for the very strings the
patterns are assembled from. Reworded with a neutral example.

Re-verified after the reword by planting a violation and watching the gate fail.
This commit is contained in:
cproudlock
2026-08-26 15:08:37 -04:00
parent 90c3c3102b
commit 024751896e
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
scripts/check-naming-and-style.sh
View File

@@ -233,12 +233,13 @@ echo "==> Checking for site-specific literals in product code (ADR-015)..."
# publication scrub greps for the very strings below - written literally, the # publication scrub greps for the very strings below - written literally, the
# rule's own definition trips the gate that enforces it. Same reason # rule's own definition trips the gate that enforces it. Same reason
# tests/test_docs_publishable.py splits its terms. # tests/test_docs_publishable.py splits its terms.
# Adjacent quoted strings CONCATENATE: 'tsg''wp00525' is tsgwp00525. The # Adjacent quoted strings CONCATENATE: 'ab''cd' is the four-character string
# apostrophe-escape form ('tsg'\''wp00525') looks similar and is not - it # abcd. The apostrophe-escape form ('ab'\''cd') looks almost identical and is
# embeds a literal ' in the middle, and every one of these patterns then matches # not - it embeds a literal ' in the middle, so every pattern below matched
# nothing. This check silently passed everything from the day it was written # nothing and this check silently passed everything from the day it was written
# until 2026-08-26, which is how a QA ServiceNow tenant sat in the shipped # until 2026-08-26. That is how a QA SaaS tenant sat in the shipped defaults for
# defaults for months with the gate green. # months with the gate green. Keep the fragments split (the scrub greps this
# file for the very strings the patterns are made of) and keep them ADJACENT.
SITE_HOST='tsg''wp00525' SITE_HOST='tsg''wp00525'
SITE_DOMAIN='\.geaero''space\.net' SITE_DOMAIN='\.geaero''space\.net'
SITE_NAME='West Jeff''erson' SITE_NAME='West Jeff''erson'